From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:36965 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728540AbeHMVMk (ORCPT ); Mon, 13 Aug 2018 17:12:40 -0400 Received: by mail-wr1-f67.google.com with SMTP id u12-v6so15097262wrr.4 for ; Mon, 13 Aug 2018 11:29:17 -0700 (PDT) Subject: Re: [PATCH] ath10k: retrieve MAC address from firmware if provided To: Brian Norris References: <20180810233948.144792-1-briannorris@chromium.org> <5B6F2A47.7070502@broadcom.com> Cc: Kalle Valo , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, govinds@codeaurora.org, Linux Kernel From: Arend van Spriel Message-ID: <5B71CDFB.60408@broadcom.com> (sfid-20180813_203030_235574_24B660E6) Date: Mon, 13 Aug 2018 20:29:15 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 8/13/2018 7:14 PM, Brian Norris wrote: > On Sat, Aug 11, 2018 at 11:26 AM Arend van Spriel > wrote: >> >> On 8/11/2018 1:39 AM, Brian Norris wrote: >>> Devices may provide their own MAC address via system firmware (e.g., >> >> You got me confused by using just "firmware" in the subject. > > Yeah...I started by writing this patch with device tree specifically > (of_get_mac_address()), and then later found that there were generic > "device" helpers for this, which can assist with other sorts of > firmware nodes. It was easier to put a name on a device tree patch > than on a "device" patch. I suppose "system firmware" might be a > better description? > >>> device tree), especially in the case where the device doesn't have a >>> useful EEPROM on which to store its MAC address (e.g., for integrated >>> Wifi). >>> >>> Use the generic device helper to retrieve the MAC address, and (if >>> present) honor it above the MAC address advertised by the card. >> >> But this put me back on track ;-) > > Let me know if you have a better way to clarify. I can resend with a > slightly modified subject (s/firmware/system firmware/), or let Kalle > do it, if that's the only thing to change. "system firmware" substitution works for me. Regards, Arend From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fpHaq-0002J3-OL for ath10k@lists.infradead.org; Mon, 13 Aug 2018 18:29:30 +0000 Received: by mail-wr1-x444.google.com with SMTP id h9-v6so15115714wro.3 for ; Mon, 13 Aug 2018 11:29:18 -0700 (PDT) Subject: Re: [PATCH] ath10k: retrieve MAC address from firmware if provided References: <20180810233948.144792-1-briannorris@chromium.org> <5B6F2A47.7070502@broadcom.com> From: Arend van Spriel Message-ID: <5B71CDFB.60408@broadcom.com> Date: Mon, 13 Aug 2018 20:29:15 +0200 MIME-Version: 1.0 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Brian Norris Cc: Kalle Valo , govinds@codeaurora.org, linux-wireless@vger.kernel.org, Linux Kernel , ath10k@lists.infradead.org On 8/13/2018 7:14 PM, Brian Norris wrote: > On Sat, Aug 11, 2018 at 11:26 AM Arend van Spriel > wrote: >> >> On 8/11/2018 1:39 AM, Brian Norris wrote: >>> Devices may provide their own MAC address via system firmware (e.g., >> >> You got me confused by using just "firmware" in the subject. > > Yeah...I started by writing this patch with device tree specifically > (of_get_mac_address()), and then later found that there were generic > "device" helpers for this, which can assist with other sorts of > firmware nodes. It was easier to put a name on a device tree patch > than on a "device" patch. I suppose "system firmware" might be a > better description? > >>> device tree), especially in the case where the device doesn't have a >>> useful EEPROM on which to store its MAC address (e.g., for integrated >>> Wifi). >>> >>> Use the generic device helper to retrieve the MAC address, and (if >>> present) honor it above the MAC address advertised by the card. >> >> But this put me back on track ;-) > > Let me know if you have a better way to clarify. I can resend with a > slightly modified subject (s/firmware/system firmware/), or let Kalle > do it, if that's the only thing to change. "system firmware" substitution works for me. Regards, Arend _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k