All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <michal.lkml@markovi.net>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kallsyms: reduce size a little on 64-bit
Date: Mon, 03 Sep 2018 05:24:23 -0600	[thread overview]
Message-ID: <5B8D19E702000078001E487E@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <CAK7LNAQZw88d08wEn=S7mVgEz86djuig6MYMgT_hWwBU5jzrCA@mail.gmail.com>

>>> On 02.09.18 at 19:12, <yamada.masahiro@socionext.com> wrote:
> 2018-08-29 0:00 GMT+09:00 Jan Beulich <JBeulich@suse.com>:
>> --- 4.19-rc1/scripts/kallsyms.c
>> +++ 4.19-rc1-kallsyms-reduce-size/scripts/kallsyms.c
>> @@ -182,6 +182,8 @@ static int symbol_in_range(struct sym_en
>>         for (i = 0; i < entries; ++i) {
>>                 ar = &ranges[i];
>>
>> +               if (!ar->end)
>> +                       continue;
>>                 if (s->addr >= ar->start && s->addr <= ar->end)
>>                         return 1;
>>         }
> 
> 
> What is this hunk doing?
> 
> At least, I cannot understand it from the patch description.

Hmm, I agree, it looks like it is addressing an unrelated issue. I'll
re-submit with it dropped. The patch here dates back many
years, so I suppose I noticed this other issue at the same time,
but then forgot to split out the extra change.

Jan

  reply	other threads:[~2018-09-03 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 15:00 [PATCH] kallsyms: reduce size a little on 64-bit Jan Beulich
2018-09-02 17:12 ` Masahiro Yamada
2018-09-03 11:24   ` Jan Beulich [this message]
2018-09-03 12:09 ` [PATCH v2] " Jan Beulich
2018-09-04  0:33   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B8D19E702000078001E487E@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.