From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xen.org>,
Wei Liu <wei.liu2@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 2/3] x86/sysctl: Clean up XEN_SYSCTL_cpu_hotplug
Date: Wed, 03 Apr 2019 03:38:05 -0600 [thread overview]
Message-ID: <5CA47EFD02000078002242E6@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <096706af-4199-b028-caf5-9c4a73ed4228@citrix.com>
>>> On 03.04.19 at 11:06, <andrew.cooper3@citrix.com> wrote:
> On 03/04/2019 09:53, Jan Beulich wrote:
>>>>> On 02.04.19 at 21:57, <andrew.cooper3@citrix.com> wrote:
>>> --- a/xen/arch/x86/sysctl.c
>>> +++ b/xen/arch/x86/sysctl.c
>>> @@ -137,27 +137,35 @@ long arch_do_sysctl(
>>> case XEN_SYSCTL_cpu_hotplug:
>>> {
>>> unsigned int cpu = sysctl->u.cpu_hotplug.cpu;
>>> + bool plug;
>>> + long (*fn)(void *) = NULL;
>>> + void *hcpu = NULL;
>> May I ask that you consistently initialize (or not) all three new
>> variables you introduce?
>
> I noticed this while posting. Not would allow the compiler to notice
> when fn wasn't selected, but hvcpu is going to end up with an
> initialiser by the next patch.
Right, I've noticed the need for hcpu to stay as is while looking at
patch 3. Before you remove the other initializer, though - are you
sure you don't need to instead add one, for older gcc to not choke?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-03 9:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 19:57 [PATCH 0/3] x86/smt: Runtime SMT controls Andrew Cooper
2019-04-02 19:57 ` [PATCH 1/3] xen/cpu: Distinguish "cpu already in that state" in cpu_{up, down}() Andrew Cooper
2019-04-03 8:49 ` Jan Beulich
2019-04-02 19:57 ` [PATCH 2/3] x86/sysctl: Clean up XEN_SYSCTL_cpu_hotplug Andrew Cooper
2019-04-03 8:53 ` Jan Beulich
2019-04-03 9:06 ` Andrew Cooper
2019-04-03 9:38 ` Jan Beulich [this message]
2019-04-04 13:31 ` Andrew Cooper
2019-04-02 19:57 ` [PATCH 3/3] x86/smt: Support for enabling/disabling SMT at runtime Andrew Cooper
2019-04-03 9:33 ` Jan Beulich
2019-04-03 10:17 ` Andrew Cooper
2019-04-03 10:44 ` Jan Beulich
2019-04-03 11:33 ` Andrew Cooper
2019-04-03 12:10 ` Jan Beulich
2019-04-11 8:16 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CA47EFD02000078002242E6@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.