All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: christian.koenig@amd.com, dri-devel@lists.freedesktop.org,
	chris@chris-wilson.co.uk
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unused function parameter
Date: Thu, 22 Sep 2022 10:28:55 +0100	[thread overview]
Message-ID: <5a176438-606f-6df9-c923-3d129a3ac276@linux.intel.com> (raw)
In-Reply-To: <20220922044311.7361-1-niranjana.vishwanathapura@intel.com>


On 22/09/2022 05:43, Niranjana Vishwanathapura wrote:
> The function parameter 'exclude' in funciton
> i915_sw_fence_await_reservation() is not used.
> Remove it.
> 
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++---
>   drivers/gpu/drm/i915/gem/i915_gem_clflush.c       | 2 +-
>   drivers/gpu/drm/i915/i915_sw_fence.c              | 1 -
>   drivers/gpu/drm/i915/i915_sw_fence.h              | 1 -
>   4 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> index aaa6708256d5..ecb8d71d36c0 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> @@ -1005,7 +1005,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane,
>   		 */
>   		if (intel_crtc_needs_modeset(crtc_state)) {
>   			ret = i915_sw_fence_await_reservation(&state->commit_ready,
> -							      old_obj->base.resv, NULL,
> +							      old_obj->base.resv,
>   							      false, 0,
>   							      GFP_KERNEL);
>   			if (ret < 0)
> @@ -1039,8 +1039,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane,
>   		struct dma_fence *fence;
>   
>   		ret = i915_sw_fence_await_reservation(&state->commit_ready,
> -						      obj->base.resv, NULL,
> -						      false,
> +						      obj->base.resv, false,
>   						      i915_fence_timeout(dev_priv),
>   						      GFP_KERNEL);
>   		if (ret < 0)
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_clflush.c b/drivers/gpu/drm/i915/gem/i915_gem_clflush.c
> index 0512afdd20d8..b3b398fe689c 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_clflush.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_clflush.c
> @@ -113,7 +113,7 @@ bool i915_gem_clflush_object(struct drm_i915_gem_object *obj,
>   		clflush = clflush_work_create(obj);
>   	if (clflush) {
>   		i915_sw_fence_await_reservation(&clflush->base.chain,
> -						obj->base.resv, NULL, true,
> +						obj->base.resv, true,
>   						i915_fence_timeout(i915),
>   						I915_FENCE_GFP);
>   		dma_resv_add_fence(obj->base.resv, &clflush->base.dma,
> diff --git a/drivers/gpu/drm/i915/i915_sw_fence.c b/drivers/gpu/drm/i915/i915_sw_fence.c
> index 6fc0d1b89690..cc2a8821d22a 100644
> --- a/drivers/gpu/drm/i915/i915_sw_fence.c
> +++ b/drivers/gpu/drm/i915/i915_sw_fence.c
> @@ -571,7 +571,6 @@ int __i915_sw_fence_await_dma_fence(struct i915_sw_fence *fence,
>   
>   int i915_sw_fence_await_reservation(struct i915_sw_fence *fence,
>   				    struct dma_resv *resv,
> -				    const struct dma_fence_ops *exclude,
>   				    bool write,
>   				    unsigned long timeout,
>   				    gfp_t gfp)
> diff --git a/drivers/gpu/drm/i915/i915_sw_fence.h b/drivers/gpu/drm/i915/i915_sw_fence.h
> index 619fc5a22f0c..f752bfc7c6e1 100644
> --- a/drivers/gpu/drm/i915/i915_sw_fence.h
> +++ b/drivers/gpu/drm/i915/i915_sw_fence.h
> @@ -91,7 +91,6 @@ int i915_sw_fence_await_dma_fence(struct i915_sw_fence *fence,
>   
>   int i915_sw_fence_await_reservation(struct i915_sw_fence *fence,
>   				    struct dma_resv *resv,
> -				    const struct dma_fence_ops *exclude,
>   				    bool write,
>   				    unsigned long timeout,
>   				    gfp_t gfp);

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

  parent reply	other threads:[~2022-09-22  9:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  4:43 [PATCH] drm/i915: Remove unused function parameter Niranjana Vishwanathapura
2022-09-22  4:43 ` [Intel-gfx] " Niranjana Vishwanathapura
2022-09-22  4:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2022-09-22  5:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-22  6:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-22  9:28 ` Tvrtko Ursulin [this message]
2022-09-22 21:39 [Intel-gfx] [PATCH] " Niranjana Vishwanathapura
2022-09-24  5:03 ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a176438-606f-6df9-c923-3d129a3ac276@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=niranjana.vishwanathapura@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.