All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Leitner <richard.leitner@skidata.com>
To: Wenlin Kang <wenlin.kang@windriver.com>,
	<openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-java][PATCH 1/2] openjdk-8: remove debuglink
Date: Wed, 13 Jun 2018 08:43:05 +0200	[thread overview]
Message-ID: <5a4429c9-f38d-f0e4-6197-d1eb2c66f565@skidata.com> (raw)
In-Reply-To: <b24f33ec-c9d9-5fd0-6edc-c3e0d9ab5e69@windriver.com>

On 06/13/2018 08:35 AM, Wenlin Kang wrote:
> On 2018年06月12日 20:47, Richard Leitner wrote:
>> On 06/12/2018 02:02 PM, Wenlin Kang wrote:

...

>>
>> Maybe you can add this (or a shortened version of it) to the commit
>> message.
>> Otherwise this patch is fine with me.
> 
> Hi Richard
> 
> What about changing the comments as below ?

That's fine with me. Thanks!

> 
> openjdk-8: remove debuglink
> 
> During openjdk-8 compiling, its debug file is xxx.debuginfo, and it will
> add libjvm.debuginfo as libjvm.so's debuglink section's file name, this
> name is different with that we will create and add in splitdebuginfo()
> of package.bbclass, in oe-core, the debug file name is the same with the
> corresponding executable file or library file, this will make we can't get
> symbol information when debug libjvm.so in gdb, so we must remove the
> previous debuglink before add it if it has existed(if a file has contained
> the debuglink section, it will not be changed when add again).
> 
>>
>> So please send a v2 of this series whenever you like!


      reply	other threads:[~2018-06-13  6:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07  9:24 [meta-java][PATCH 1/2] openjdk-8: remove debuglink Wenlin Kang
2018-06-07  9:24 ` [meta-java][PATCH 2/2] openjdk-8: combine the -dbg package Wenlin Kang
2018-06-08  7:39   ` Richard Leitner
2018-06-08  9:02     ` Wenlin Kang
2018-06-08  9:10       ` Wenlin Kang
2018-06-08 10:07       ` Richard Leitner
2018-06-11  6:31         ` Robert Yang
2018-06-12  7:59           ` Richard Leitner
2018-06-11  6:49         ` Wenlin Kang
2018-06-12  8:01   ` Richard Leitner
2018-06-12 10:59     ` Wenlin Kang
2018-06-12 11:09       ` Richard Leitner
2018-06-12 11:14         ` Wenlin Kang
2018-06-12 11:09 ` [meta-java][PATCH 1/2] openjdk-8: remove debuglink Richard Leitner
2018-06-12 11:35   ` Wenlin Kang
2018-06-12 12:02     ` Wenlin Kang
2018-06-12 12:47       ` Richard Leitner
2018-06-13  6:35         ` Wenlin Kang
2018-06-13  6:43           ` Richard Leitner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a4429c9-f38d-f0e4-6197-d1eb2c66f565@skidata.com \
    --to=richard.leitner@skidata.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=wenlin.kang@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.