All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path【请注意,邮件由sjg@google.com代发】
Date: Mon, 1 Apr 2019 10:46:24 +0800	[thread overview]
Message-ID: <5be54060-8efe-8152-f30f-c3979a033141@rock-chips.com> (raw)
In-Reply-To: <CAPnjgZ1pvC7KD-Se1j-A7sNc8PpH3RhXZiK=7KhtbQra=h1wgA@mail.gmail.com>

Hi Simon,


On 04/01/2019 10:00 AM, Simon Glass wrote:
> Hi Kever,
>
> On Sun, 31 Mar 2019 at 19:03, Kever Yang <kever.yang@rock-chips.com> wrote:
>> Hi Simon,
>>
>>
>> On 03/31/2019 05:18 AM, Simon Glass wrote:
>>> Hi Kever,
>>>
>>> On Wed, 27 Mar 2019 at 21:01, Kever Yang <kever.yang@rock-chips.com> wrote:
>>>> Rockchip use 'arch-rockchip' instead of arch-$(SOC) as common
>>>> header file path, so that we can get the correct path directly.
>>> Can you give a few more details on the reason for this change? I
>>> cannot see the benefit?
>> 1. 'rockchip' is not SOC name but vendor name, we'd better use correct name;
>> 2. the build system will include $(SOC)-u-boot.dtsi automatically
>> without modify
>>     $(SOC).dtsi or $(board).dtsi, if the $(SOC) default to 'rockchip',
>> we can't use
>>     this feature.
> OK I see.
>
> So far Rockchip has been designed so that a single U-Boot (proper) can
> support multiple SoCs, 

I don't understand, how can a single U-Boot(proper) support multiple
Rockchip SoCs,
it sounds awesome which is kernel like. But I thought we need different
build
with different source for different SoCs now.

For $(SOC)-u-boot.dtsi, another way is using $(BOARD)-u-boot.dtsi, but I
think in
most case, we can have one $(SOC)-u-boot.dtsi instead of many
$(BOARD)-u-boot.dtsi
for one SoC, so we need this feature.

Thinks,
- Kever
> although in practice we don't use that ability.
> So I don't think it is a big problem to drop it.
>
> Regards,
> Simon
>

  reply	other threads:[~2019-04-01  2:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28  3:01 [U-Boot] [PATCH 0/3] rockchip: correct SYS_SOC name for all rockchip SoCs Kever Yang
2019-03-28  3:01 ` [U-Boot] [PATCH 1/3] rockchip: arm: use 'arch-rockchip' for common header Kever Yang
2019-03-28  7:02   ` Philipp Tomsich
2019-04-01  7:12   ` Neil Armstrong
2019-04-01 13:13     ` Tom Rini
2019-04-02  0:58       ` Kever Yang
2019-05-01 13:06   ` Philipp Tomsich
2019-03-28  3:01 ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path Kever Yang
2019-03-30 21:18   ` Simon Glass
2019-04-01  1:02     ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path【请注意,邮件由sjg@google.com代发】 Kever Yang
2019-04-01  2:00       ` Simon Glass
2019-04-01  2:46         ` Kever Yang [this message]
2019-04-01 19:00           ` Simon Glass
2019-04-02  1:11             ` Kever Yang
2019-04-05  2:33               ` Simon Glass
2019-04-03 19:57     ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path Simon Glass
2019-04-04 13:11       ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path【请注意,邮件由sjg@google.com代发】 Kever Yang
2019-04-05  2:33         ` Simon Glass
2019-04-28 23:34   ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path Philipp Tomsich
2019-05-01 13:06   ` Philipp Tomsich
2019-03-28  3:01 ` [U-Boot] [PATCH 3/3] rockchip: correct ARCH_SOC name Kever Yang
2019-03-28  7:02   ` Philipp Tomsich
2019-03-28  9:31     ` Kever Yang
2019-05-01 13:06   ` Philipp Tomsich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5be54060-8efe-8152-f30f-c3979a033141@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.