From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754153AbcKULV1 (ORCPT ); Mon, 21 Nov 2016 06:21:27 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:65043 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752075AbcKULVY (ORCPT ); Mon, 21 Nov 2016 06:21:24 -0500 X-AuditID: cbfec7f2-f79556d000002c42-17-5832d8b07d74 Subject: Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage To: Lars-Peter Clausen , Krzysztof Kozlowski Cc: Sangbeom Kim , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org From: Sylwester Nawrocki Message-id: <5ca5b9a5-2355-2c9b-f0a9-bbc1375aa044@samsung.com> Date: Mon, 21 Nov 2016 12:21:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-version: 1.0 In-reply-to: <713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHe+7d7u5Ws9tmetJKWERlpE4NriWiZHStBIMgiSBX3tRyKpuz 7ItvlU7wLdNsSRqomJrObYhOE52ZkskSXzAyRROVTILMVkTSrtfAb7/nnB/nPP+Hh8RlZqEH mZCUymqSVIkKQiJoe/Pbfsw46R/t92r0ED02YsPostl5grbbjSK6prRKSP8cy8No0+cJIT1q rSToCns3RuutRUJ6pP4HRhsdL1Hodsa4mk0wHYZPIsbUoCcYc00GU/PVJmS6V+oIptDSgJgW y7iAWTXtjxJflgTHsokJaazGNyRGEj8wYxCktIrvTFuqiUzUK8pHJAlUIPzRJ+UjsRPd4P10 C5GPJKSMqkXw7v64iGvIqFUE8w4XXgqE3OICnJfqEPRYqxE3SEYtIjB7co6cugFTOcOIY1fq AlQuT27MwakODBaexHJMUEoo6C90OiJSSoVAVwpXFVAH4WP5Gs7xbioaelsbN6ZIqV3wq3Ra wLHYaXevlAv4iX5Q8agP49kLzE0rOH/LORG0FPjwCfeBqWezHA79mUsEz3L4MmAR8bwX9Hm9 GBcKqCIEg005iD9UIJjKLcZ46yT0DYwI+WUu8LDtMc4vkELeAxmvMFC6Pryph8GCfQnjX8qE QYmjERUjL8OWPIYtGQxbMlQjvAG5sjqtOo7VBvhoVWqtLinO53qy2oScX2lofeB7O1obPGFD FIkUO6SZL/yjZUJVmjZdbUNA4gpX6esJZ0kaq0q/y2qSr2p0iazWhjxJgcJd2lU9dklGxalS 2Vssm8Jq/ncxUuyRieQkXHzr162MdencWW+zHo9c/jZ0JLiV9MjybQw43EPtsegj2/uCZ3Q6 tSmCcMSUPafXZ1CzPsTt6KlWY/CH036OyvPhYbcH3QeztwVdUdmh80xW/s2/c6El8qgg6eJw xOzZ8nt0y9NnxQcklbXX+hoKouXeK1VrC8rmjHPtTQqBNl6l9MY1WtU/0OgF3EYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t/xa7q7bhhFGLw8wGRx5eIhJoupD5+w WZw/v4HdYsnk+awW3650MFlsenyN1eLyrjlsFjPO72Oy6NzVz2pxccUXJosN39cyOnB7bPjc xOaxc9Zddo9NqzrZPDYvqfdY8uYQq8e+t8vYPPq2rGL0WL/lKovH501yAZxRbjYZqYkpqUUK qXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W0rdLcMs4fn8W S8FGzop7WxawNTAeZO9i5OSQEDCRaJ/Qywxhi0lcuLeeDcQWEljCKHGiDSjOBWQ/Z5SY8vg8 K0hCWCBNonfWSSYQW0TAX2LJ25VsEEWbmCSuTDzNCuIwC+xkkpi36hsLSBWbgKFE79E+xi5G dg5eATuJPQUgURYBVYnb076CLRYViJDY9HUOWDWvgKDEj8n3wGxOoOp9b6cB2RxAI/Uk7l/U AgkzC8hLbF7zlnkCo8AsJB2zEKpmIalawMi8ilEktbQ4Nz232FCvODG3uDQvXS85P3cTIzBK tx37uXkH46WNwYcYBTgYlXh4G1YaRQixJpYVV+YeYpTgYFYS4T1yDSjEm5JYWZValB9fVJqT WnyI0RTohYnMUqLJ+cAEklcSb2hiaG5paGRsYWFuZKQkzlvy4Uq4kEB6YklqdmpqQWoRTB8T B6dUA2Ojc59wid6Oy3rrk1///SI8I9ahj1n9qH2yRcj8sxU8t05MmX56u1T12+bSf8F7dm3c FXhilhnD7S+XJy59s9G7svDxx9A7b8qvneSaOOXKZKn0P8vTbiTbqm89cODfqh+h3VEmJsuC BWMFrub3KXk+39P/03Pxpz3N39y36ilaLXvCssljbughJZbijERDLeai4kQA6r5OVugCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161121112120eucas1p2768aa4d075d30393651cb2e150988f6a X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161120192523epcas1p4f764b20d525d28059b85373276a4f725 X-RootMTR: 20161120192523epcas1p4f764b20d525d28059b85373276a4f725 References: <1479669895-19124-1-git-send-email-krzk@kernel.org> <1479669895-19124-3-git-send-email-krzk@kernel.org> <8b81b058-0ba9-f1bc-a0ed-d30604853110@samsung.com> <713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2016 11:34 AM, Lars-Peter Clausen wrote: > On 11/21/2016 11:30 AM, Sylwester Nawrocki wrote: >> > On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote: >>> >> >>> >> Not tested. The driver did not override .platform_name which looks >>> >> suspicious to me. However I did not want to add changes which could have >>> >> some visible impact on output code. >> > >> > The patch looks good to me. However the existing smdk64xx sound support >> > less so. I don't have smdk6410 set up for testing yet, possibly I get >> > around that next week. >> > Indeed it's strange .platform_name is not also "samsung-i2s.2". > > I think that is a fallout from commit a08485d8fdf6f ("ASoC: Samsung: Do not > register samsung audio dma device as pdev"). Given nobody noticed this in > the last 4 years maybe its time to drop this machine driver as well. Yeah, looks like since that commit things are broken. Even though nobody seems to be interested I'm inclined to not removing this machine driver just yet, otherwise there will not be any board in mainline I could test s3c64xx IP block related code changes. I'll try to find time to make this working again. -- Thanks, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Mon, 21 Nov 2016 12:21:17 +0100 Subject: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage In-Reply-To: <713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de> References: <1479669895-19124-1-git-send-email-krzk@kernel.org> <1479669895-19124-3-git-send-email-krzk@kernel.org> <8b81b058-0ba9-f1bc-a0ed-d30604853110@samsung.com> <713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de> Message-ID: <5ca5b9a5-2355-2c9b-f0a9-bbc1375aa044@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/21/2016 11:34 AM, Lars-Peter Clausen wrote: > On 11/21/2016 11:30 AM, Sylwester Nawrocki wrote: >> > On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote: >>> >> >>> >> Not tested. The driver did not override .platform_name which looks >>> >> suspicious to me. However I did not want to add changes which could have >>> >> some visible impact on output code. >> > >> > The patch looks good to me. However the existing smdk64xx sound support >> > less so. I don't have smdk6410 set up for testing yet, possibly I get >> > around that next week. >> > Indeed it's strange .platform_name is not also "samsung-i2s.2". > > I think that is a fallout from commit a08485d8fdf6f ("ASoC: Samsung: Do not > register samsung audio dma device as pdev"). Given nobody noticed this in > the last 4 years maybe its time to drop this machine driver as well. Yeah, looks like since that commit things are broken. Even though nobody seems to be interested I'm inclined to not removing this machine driver just yet, otherwise there will not be any board in mainline I could test s3c64xx IP block related code changes. I'll try to find time to make this working again. -- Thanks, Sylwester