From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7CDC07E96 for ; Tue, 6 Jul 2021 17:18:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72EE261C5B for ; Tue, 6 Jul 2021 17:18:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72EE261C5B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0oiD-0007l4-Lv for qemu-devel@archiver.kernel.org; Tue, 06 Jul 2021 13:18:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0oXc-0005xj-NU for qemu-devel@nongnu.org; Tue, 06 Jul 2021 13:07:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0oXa-0000eJ-28 for qemu-devel@nongnu.org; Tue, 06 Jul 2021 13:07:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625591241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/0/OEeAFGsfeeMhpEwQqN9UrFKHwWzSoT19/wSI5v8=; b=IQKV1yvSD4tuTU4/+XfioymgygvU9UicroWLGbqlbYtREe9n/9D5WXZHOKP9O9VSVIO24L NeIqfSq/jKy90CmoOd10LiX3e/mgvwKdwLj93E/rJ3HYILZlKPVICSJU9O8tPp5X6Y/kYH Dqqoaq2Il8RVxae3lRVNOeKCgueqCdQ= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-87-TP89qow6N5m8WJWS9rC5mg-1; Tue, 06 Jul 2021 13:07:20 -0400 X-MC-Unique: TP89qow6N5m8WJWS9rC5mg-1 Received: by mail-ej1-f71.google.com with SMTP id v5-20020a1709068585b02904eb913da73bso427451ejx.8 for ; Tue, 06 Jul 2021 10:07:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8/0/OEeAFGsfeeMhpEwQqN9UrFKHwWzSoT19/wSI5v8=; b=OwR0+bFrMvn92NQ2GrIunYYF9COUR8MgfELW9EAR+NxYK+Ercq0Duhr03ZwQlGQ2ho 8JXyIRzsYn8qaaHEwAGZ/xlt7DRGX6caFEQm/F7n5nPhcd9auOWm+wu06Mr2rF/uZgs5 UAhq2r0EdiLmAh1wsiFSkz/R2Rqoa9NEjOx0USxrnQ1cGd1HXMPrty0X19c/6/kYOtBN Idp2p+wXiBstTlyg5swTLORsrAXlZozcoO4f7ERi3TOI9HPuJGCJERLLRJCExQJzkek+ B1FaBg0ekbKaNcbQ6tHmZW8/WbdPO1V1hb5C6jR4xXpRgSXBNOFoio5WBwlrVKN2EJJE 4LLw== X-Gm-Message-State: AOAM5339qaY2jthVNWHWloROtfQu699tn55GeqUv+LLjTX3lg1EuqCZ+ q4D9mjNNStpqTnTsiJAsphP/Es14R3Zb4H1s3i9Z4bkTDA0VjqJGDvals+EynRMxhADz+kBmhGp 7RZkfs7aEgDb4sxc= X-Received: by 2002:a05:6402:35cd:: with SMTP id z13mr24228215edc.2.1625591238854; Tue, 06 Jul 2021 10:07:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwP10/m7zUEbupWSBw3E0Kit5kgTrsq9WiQeL0AsaTPkNdy5I7CNBfgN9YskwngFU2a6/CGA== X-Received: by 2002:a05:6402:35cd:: with SMTP id z13mr24228154edc.2.1625591238493; Tue, 06 Jul 2021 10:07:18 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id s7sm6243566ejd.88.2021.07.06.10.07.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 10:07:17 -0700 (PDT) Subject: Re: [PATCH v4 01/34] modules: add modinfo macros To: Eduardo Habkost , Gerd Hoffmann References: <20210624103836.2382472-1-kraxel@redhat.com> <20210624103836.2382472-2-kraxel@redhat.com> <20210624203728.q2zrkpm5c6qecl2v@habkost.net> From: Paolo Bonzini Message-ID: <5d9e28b4-5439-4c17-4c23-6de33ba786f4@redhat.com> Date: Tue, 6 Jul 2021 19:07:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210624203728.q2zrkpm5c6qecl2v@habkost.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand , qemu-devel@nongnu.org, Samuel Thibault , qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Halil Pasic , Christian Borntraeger , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Laurent Vivier , Thomas Huth , Richard Henderson , Peter Lieven , Greg Kurz , "Dr. David Alan Gilbert" , qemu-s390x@nongnu.org, Ronnie Sahlberg , Cleber Rosa , David Gibson , Kevin Wolf , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Cornelia Huck , Max Reitz , qemu-ppc@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24/06/21 22:37, Eduardo Habkost wrote: > On Thu, Jun 24, 2021 at 12:38:03PM +0200, Gerd Hoffmann wrote: >> Add macros for module info annotations. >> >> Instead of having that module meta-data stored in lists in util/module.c >> place directly in the module source code. >> > [...] >> +/* module implements QOM type */ >> +#define module_obj(name) modinfo(obj, name) > > Can we make OBJECT_DEFINE_TYPE*() use this macro automatically? > Yeah, that's possible. I would do it as a separate patch though, because Gerd is on vacation and he asked me to include it in a pull request before soft freeze. Thanks, Paolo