From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916B9C2D0D1 for ; Mon, 30 Dec 2019 05:49:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7122A20663 for ; Mon, 30 Dec 2019 05:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727173AbfL3FtK (ORCPT ); Mon, 30 Dec 2019 00:49:10 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:60860 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727142AbfL3FtK (ORCPT ); Mon, 30 Dec 2019 00:49:10 -0500 Received: from [192.168.9.205] (157-131-199-19.fiber.dynamic.sonic.net [157.131.199.19]) (authenticated bits=0) (User authenticated as andersk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xBU5mscK010955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 30 Dec 2019 00:48:57 -0500 Subject: Re: [PATCH AUTOSEL 5.4 056/187] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection" To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Luca Coelho , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org References: <20191227174055.4923-1-sashal@kernel.org> <20191227174055.4923-56-sashal@kernel.org> From: Anders Kaseorg Message-ID: <5dbea7a0-5c66-abe4-b1ef-bbfceccbb9bb@mit.edu> Date: Sun, 29 Dec 2019 21:48:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20191227174055.4923-56-sashal@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 12/27/19 9:38 AM, Sasha Levin wrote: > From: Anders Kaseorg > > [ Upstream commit db5cce1afc8d2475d2c1c37c2a8267dd0e151526 ] > > This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99. > > Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4 > attempted to fix the same bug (dead assignments to the local variable > cfg), but they did so in incompatible ways. When they were both merged, > independently of each other, the combination actually caused the bug to > reappear, leading to a firmware crash on boot for some cards. > > https://bugzilla.kernel.org/show_bug.cgi?id=205719 > > Signed-off-by: Anders Kaseorg > Acked-by: Luca Coelho > Signed-off-by: Kalle Valo > Signed-off-by: Sasha Levin This commit’s child 0df36b90c47d93295b7e393da2d961b2f3b6cde4 (part of the same bug 205719) is now enqueued for v5.4, but this one doesn’t seem to have made it yet, perhaps because I forgot to Cc: stable@ in the commit message. Can someone make sure this goes to v5.4 as well? Luca previously nominated it for v5.4 here: https://patchwork.kernel.org/patch/11269985/#23032785 Anders