From: George Dunlap <george.dunlap@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH 11/24] tools: tracing: handle more scheduling related events.
Date: Tue, 20 Sep 2016 15:37:02 +0100 [thread overview]
Message-ID: <5decffe5-2d04-4732-5369-932edbe9df1f@citrix.com> (raw)
In-Reply-To: <147145433038.25877.16124577573706461350.stgit@Solace.fritz.box>
On 17/08/16 18:18, Dario Faggioli wrote:
> There are some scheduling related trace records that
> are not being taken care of (and hence only dumped as
> raw records).
>
> Some of them are being introduced in this series, while
> other were just neglected by previous patches.
>
> Add support for them.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
> ---
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/xentrace/formats | 8 ++++
> tools/xentrace/xenalyze.c | 101 +++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 109 insertions(+)
>
> diff --git a/tools/xentrace/formats b/tools/xentrace/formats
> index adff681..3488a06 100644
> --- a/tools/xentrace/formats
> +++ b/tools/xentrace/formats
> @@ -42,6 +42,10 @@
> 0x00022004 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched:stolen_vcpu [ dom:vcpu = 0x%(2)04x%(3)04x, from = %(1)d ]
> 0x00022005 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched:picked_cpu [ dom:vcpu = 0x%(1)04x%(2)04x, cpu = %(3)d ]
> 0x00022006 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched:tickle [ cpu = %(1)d ]
> +0x00022007 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched:boost [ dom:vcpu = 0x%(1)04x%(2)04x ]
> +0x00022008 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched:unboost [ dom:vcpu = 0x%(1)04x%(2)04x ]
> +0x00022009 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched:schedule [ cpu = %(1)d, tasklet_scheduled = %(2)d, was_idle = %(3)d ]
> +0x0002200A CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched:ratelimit [ dom:vcpu = 0x%(1)04x%(2)04x, runtime = %(3)d ]
>
> 0x00022201 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched2:tick
> 0x00022202 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched2:runq_pos [ dom:vcpu = 0x%(1)08x, pos = %(2)d]
> @@ -61,12 +65,16 @@
> 0x00022210 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched2:load_check [ lrq_id[16]:orq_id[16] = 0x%(1)08x, delta = %(2)d ]
> 0x00022211 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched2:load_balance [ l_bavgload = 0x%(2)08x%(1)08x, o_bavgload = 0x%(4)08x%(3)08x, lrq_id[16]:orq_id[16] = 0x%(5)08x ]
> 0x00022212 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched2:pick_cpu [ b_avgload = 0x%(2)08x%(1)08x, dom:vcpu = 0x%(3)08x, rq_id[16]:new_cpu[16] = %(4)d ]
> +0x00022213 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched2:runq_candidate [ dom:vcpu = 0x%(1)08x, runq_pos = %(2)d tickled_cpu = %(3)d ]
> +0x00022214 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched2:schedule [ rq:cpu = 0x%(1)08x, tasklet[8]:idle[8]:smt_idle[8]:tickled[8] = %(2)08x ]
> +0x00022215 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) csched2:ratelimit [ dom:vcpu = 0x%(1)08x, runtime = %(2)d ]
>
> 0x00022801 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:tickle [ cpu = %(1)d ]
> 0x00022802 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:runq_pick [ dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget = 0x%(5)08x%(4)08x ]
> 0x00022803 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:burn_budget [ dom:vcpu = 0x%(1)08x, cur_budget = 0x%(3)08x%(2)08x, delta = %(4)d ]
> 0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [ dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget = 0x%(5)08x%(4)08x ]
> 0x00022805 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:sched_tasklet
> +0x00022806 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:schedule [ cpu[16]:tasklet[8]:idle[4]:tickled[4] = %(1)08x ]
>
> 0x00041001 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) domain_create [ dom = 0x%(1)08x ]
> 0x00041002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) domain_destroy [ dom = 0x%(1)08x ]
> diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
> index 58a8d41..aaff1d9 100644
> --- a/tools/xentrace/xenalyze.c
> +++ b/tools/xentrace/xenalyze.c
> @@ -7590,6 +7590,50 @@ void sched_process(struct pcpu_info *p)
> ri->dump_header, r->cpu);
> }
> break;
> + case TRC_SCHED_CLASS_EVT(CSCHED, 7): /* BOOST_START */
> + if(opt.dump_all) {
> + struct {
> + unsigned int domid, vcpuid;
> + } *r = (typeof(r))ri->d;
> +
> + printf(" %s csched: d%uv%u boosted\n",
> + ri->dump_header, r->domid, r->vcpuid);
> + }
> + break;
> + case TRC_SCHED_CLASS_EVT(CSCHED, 8): /* BOOST_END */
> + if(opt.dump_all) {
> + struct {
> + unsigned int domid, vcpuid;
> + } *r = (typeof(r))ri->d;
> +
> + printf(" %s csched: d%uv%u unboosted\n",
> + ri->dump_header, r->domid, r->vcpuid);
> + }
> + break;
> + case TRC_SCHED_CLASS_EVT(CSCHED, 9): /* SCHEDULE */
> + if(opt.dump_all) {
> + struct {
> + unsigned int cpu, tasklet, idle;
> + } *r = (typeof(r))ri->d;
> +
> + printf(" %s csched:schedule cpu %u, %s%s\n",
> + ri->dump_header, r->cpu,
> + r->tasklet ? ", tasklet scheduled" : "",
> + r->idle ? ", idle" : ", busy");
> + }
> + break;
> + case TRC_SCHED_CLASS_EVT(CSCHED, 10): /* RATELIMIT */
> + if(opt.dump_all) {
> + struct {
> + unsigned int domid, vcpuid;
> + unsigned int runtime;
> + } *r = (typeof(r))ri->d;
> +
> + printf(" %s csched:ratelimit, d%uv%u run only %u.%uus\n",
> + ri->dump_header, r->domid, r->vcpuid,
> + r->runtime / 1000, r->runtime % 1000);
> + }
> + break;
> /* CREDIT 2 (TRC_CSCHED2_xxx) */
> case TRC_SCHED_CLASS_EVT(CSCHED2, 1): /* TICK */
> case TRC_SCHED_CLASS_EVT(CSCHED2, 4): /* CREDIT_ADD */
> @@ -7779,6 +7823,50 @@ void sched_process(struct pcpu_info *p)
> ri->dump_header, r->domid, r->vcpuid, r->rqi, r->cpu);
> }
> break;
> + case TRC_SCHED_CLASS_EVT(CSCHED2, 20): /* RUNQ_CANDIDATE */
> + if (opt.dump_all) {
> + struct {
> + unsigned vcpuid:16, domid:16;
> + unsigned tickled_cpu, position;
> + } *r = (typeof(r))ri->d;
> +
> + printf(" %s csched2:runq_candidate d%uv%u, "
> + "pos in runq %u, ",
> + ri->dump_header, r->domid, r->vcpuid,
> + r->position);
> + if (r->tickled_cpu == (unsigned)-1)
> + printf("no cpu was tickled");
> + else
> + printf("cpu %u was tickled\n", r->tickled_cpu);
> + }
> + break;
> + case TRC_SCHED_CLASS_EVT(CSCHED2, 21): /* SCHEDULE */
> + if (opt.dump_all) {
> + struct {
> + unsigned cpu:16, rqi:16;
> + unsigned tasklet:8, idle:8, smt_idle:8, tickled:8;
> + } *r = (typeof(r))ri->d;
> +
> + printf(" %s csched2:schedule cpu %u, rq# %u%s%s%s%s\n",
> + ri->dump_header, r->cpu, r->rqi,
> + r->tasklet ? ", tasklet scheduled" : "",
> + r->idle ? ", idle" : ", busy",
> + r->idle ? (r->smt_idle ? ", SMT idle" : ", SMT busy") : "",
> + r->tickled ? ", tickled" : ", not tickled");
> + }
> + break;
> + case TRC_SCHED_CLASS_EVT(CSCHED2, 22): /* RATELIMIT */
> + if (opt.dump_all) {
> + struct {
> + unsigned int vcpuid:16, domid:16;
> + unsigned int runtime;
> + } *r = (typeof(r))ri->d;
> +
> + printf(" %s csched2:ratelimit, d%uv%u run only %u.%uus\n",
> + ri->dump_header, r->domid, r->vcpuid,
> + r->runtime / 1000, r->runtime % 1000);
> + }
> + break;
> /* RTDS (TRC_RTDS_xxx) */
> case TRC_SCHED_CLASS_EVT(RTDS, 1): /* TICKLE */
> if(opt.dump_all) {
> @@ -7831,6 +7919,19 @@ void sched_process(struct pcpu_info *p)
> if(opt.dump_all)
> printf(" %s rtds:sched_tasklet\n", ri->dump_header);
> break;
> + case TRC_SCHED_CLASS_EVT(RTDS, 6): /* SCHEDULE */
> + if (opt.dump_all) {
> + struct {
> + unsigned cpu:16, tasklet:8, idle:4, tickled:4;
> + } __attribute__((packed)) *r = (typeof(r))ri->d;
> +
> + printf(" %s rtds:schedule cpu %u, %s%s%s\n",
> + ri->dump_header, r->cpu,
> + r->tasklet ? ", tasklet scheduled" : "",
> + r->idle ? ", idle" : ", busy",
> + r->tickled ? ", tickled" : ", not tickled");
> + }
> + break;
> default:
> process_generic(ri);
> }
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-20 14:37 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 17:17 [PATCH 00/24] sched: Credit1 and Credit2 improvements... and soft-affinity for Credit2! Dario Faggioli
2016-08-17 17:17 ` [PATCH 01/24] xen: credit1: small optimization in Credit1's tickling logic Dario Faggioli
2016-09-12 15:01 ` George Dunlap
2016-08-17 17:17 ` [PATCH 02/24] xen: credit1: fix mask to be used for tickling in Credit1 Dario Faggioli
2016-08-17 23:42 ` Dario Faggioli
2016-09-12 15:04 ` George Dunlap
2016-08-17 17:17 ` [PATCH 03/24] xen: credit1: return the 'time remaining to the limit' as next timeslice Dario Faggioli
2016-09-12 15:14 ` George Dunlap
2016-09-12 17:00 ` Dario Faggioli
2016-09-14 9:34 ` George Dunlap
2016-09-14 13:54 ` Dario Faggioli
2016-08-17 17:18 ` [PATCH 04/24] xen: credit2: properly schedule migration of a running vcpu Dario Faggioli
2016-09-12 17:11 ` George Dunlap
2016-08-17 17:18 ` [PATCH 05/24] xen: credit2: make tickling more deterministic Dario Faggioli
2016-08-31 17:10 ` anshul makkar
2016-09-05 13:47 ` Dario Faggioli
2016-09-07 12:25 ` anshul makkar
2016-09-13 11:13 ` George Dunlap
2016-09-29 15:24 ` Dario Faggioli
2016-09-13 11:28 ` George Dunlap
2016-09-30 2:22 ` Dario Faggioli
2016-08-17 17:18 ` [PATCH 06/24] xen: credit2: implement yield() Dario Faggioli
2016-09-13 13:33 ` George Dunlap
2016-09-29 16:05 ` Dario Faggioli
2016-09-20 13:25 ` George Dunlap
2016-09-20 13:37 ` George Dunlap
2016-08-17 17:18 ` [PATCH 07/24] xen: sched: don't rate limit context switches in case of yields Dario Faggioli
2016-09-20 13:32 ` George Dunlap
2016-09-29 16:46 ` Dario Faggioli
2016-08-17 17:18 ` [PATCH 08/24] xen: tracing: add trace records for schedule and rate-limiting Dario Faggioli
2016-08-18 0:57 ` Meng Xu
2016-08-18 9:41 ` Dario Faggioli
2016-09-20 13:50 ` George Dunlap
2016-08-17 17:18 ` [PATCH 09/24] xen/tools: tracing: improve tracing of context switches Dario Faggioli
2016-09-20 14:08 ` George Dunlap
2016-08-17 17:18 ` [PATCH 10/24] xen: tracing: improve Credit2's tickle_check and burn_credits records Dario Faggioli
2016-09-20 14:35 ` George Dunlap
2016-09-29 17:23 ` Dario Faggioli
2016-09-29 17:28 ` George Dunlap
2016-09-29 20:53 ` Dario Faggioli
2016-08-17 17:18 ` [PATCH 11/24] tools: tracing: handle more scheduling related events Dario Faggioli
2016-09-20 14:37 ` George Dunlap [this message]
2016-08-17 17:18 ` [PATCH 12/24] xen: libxc: allow to set the ratelimit value online Dario Faggioli
2016-09-20 14:43 ` George Dunlap
2016-09-20 14:45 ` Wei Liu
2016-09-28 15:44 ` George Dunlap
2016-08-17 17:19 ` [PATCH 13/24] libxc: improve error handling of xc Credit1 and Credit2 helpers Dario Faggioli
2016-09-20 15:10 ` Wei Liu
2016-08-17 17:19 ` [PATCH 14/24] libxl: allow to set the ratelimit value online for Credit2 Dario Faggioli
2016-08-22 9:21 ` Ian Jackson
2016-09-05 14:02 ` Dario Faggioli
2016-08-22 9:28 ` Ian Jackson
2016-09-28 15:37 ` George Dunlap
2016-09-30 1:03 ` Dario Faggioli
2016-09-28 15:39 ` George Dunlap
2016-08-17 17:19 ` [PATCH 15/24] xl: " Dario Faggioli
2016-09-28 15:46 ` George Dunlap
2016-08-17 17:19 ` [PATCH 16/24] xen: sched: factor affinity helpers out of sched_credit.c Dario Faggioli
2016-09-28 15:49 ` George Dunlap
2016-08-17 17:19 ` [PATCH 17/24] xen: credit2: soft-affinity awareness in runq_tickle() Dario Faggioli
2016-09-01 10:52 ` anshul makkar
2016-09-05 14:55 ` Dario Faggioli
2016-09-07 13:24 ` anshul makkar
2016-09-07 13:31 ` Dario Faggioli
2016-09-28 20:44 ` George Dunlap
2016-08-17 17:19 ` [PATCH 18/24] xen: credit2: soft-affinity awareness fallback_cpu() and cpu_pick() Dario Faggioli
2016-09-01 11:08 ` anshul makkar
2016-09-05 13:26 ` Dario Faggioli
2016-09-07 12:52 ` anshul makkar
2016-09-29 11:11 ` George Dunlap
2016-08-17 17:19 ` [PATCH 19/24] xen: credit2: soft-affinity awareness in load balancing Dario Faggioli
2016-09-02 11:46 ` anshul makkar
2016-09-05 12:49 ` Dario Faggioli
2016-08-17 17:19 ` [PATCH 20/24] xen: credit2: kick away vcpus not running within their soft-affinity Dario Faggioli
2016-08-17 17:20 ` [PATCH 21/24] xen: credit2: optimize runq_candidate() a little bit Dario Faggioli
2016-08-17 17:20 ` [PATCH 22/24] xen: credit2: "relax" CSCHED2_MAX_TIMER Dario Faggioli
2016-09-30 15:30 ` George Dunlap
2016-08-17 17:20 ` [PATCH 23/24] xen: credit2: optimize runq_tickle() a little bit Dario Faggioli
2016-09-02 12:38 ` anshul makkar
2016-09-05 12:52 ` Dario Faggioli
2016-08-17 17:20 ` [PATCH 24/24] xen: credit2: try to avoid tickling cpus subject to ratelimiting Dario Faggioli
2016-08-18 0:11 ` [PATCH 00/24] sched: Credit1 and Credit2 improvements... and soft-affinity for Credit2! Dario Faggioli
2016-08-18 11:49 ` Dario Faggioli
2016-08-18 11:53 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5decffe5-2d04-4732-5369-932edbe9df1f@citrix.com \
--to=george.dunlap@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.