From: Hannes Reinecke <hare@suse.de>
To: Kashyap Desai <kashyap.desai@broadcom.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v4 5/5] scsi: set shost as hctx driver_data
Date: Mon, 1 Mar 2021 08:32:37 +0100 [thread overview]
Message-ID: <6060c485-3cf2-3f3a-a7f6-7d99101a53b5@suse.de> (raw)
In-Reply-To: <20210215074048.19424-6-kashyap.desai@broadcom.com>
On 2/15/21 8:40 AM, Kashyap Desai wrote:
> hctx->driver_data is not set for SCSI currently.
> Separately set hctx->driver_data = shost.
>
> Suggested-by: John Garry <john.garry@huawei.com>
> Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
> Reviewed-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/scsi_lib.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 8c29bf0e4cfd..f661c50f3b88 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1792,9 +1792,7 @@ static void scsi_mq_exit_request(struct blk_mq_tag_set *set, struct request *rq,
>
> static int scsi_mq_poll(struct blk_mq_hw_ctx *hctx)
> {
> - struct request_queue *q = hctx->queue;
> - struct scsi_device *sdev = q->queuedata;
> - struct Scsi_Host *shost = sdev->host;
> + struct Scsi_Host *shost = hctx->driver_data;
>
> if (shost->hostt->mq_poll)
> return shost->hostt->mq_poll(shost, hctx->queue_num);
> @@ -1802,6 +1800,15 @@ static int scsi_mq_poll(struct blk_mq_hw_ctx *hctx)
> return 0;
> }
>
> +static int scsi_init_hctx(struct blk_mq_hw_ctx *hctx, void *data,
> + unsigned int hctx_idx)
> +{
> + struct Scsi_Host *shost = data;
> +
> + hctx->driver_data = shost;
> + return 0;
> +}
> +
> static int scsi_map_queues(struct blk_mq_tag_set *set)
> {
> struct Scsi_Host *shost = container_of(set, struct Scsi_Host, tag_set);
> @@ -1869,15 +1876,14 @@ static const struct blk_mq_ops scsi_mq_ops_no_commit = {
> .cleanup_rq = scsi_cleanup_rq,
> .busy = scsi_mq_lld_busy,
> .map_queues = scsi_map_queues,
> + .init_hctx = scsi_init_hctx,
> .poll = scsi_mq_poll,
> };
>
>
> static void scsi_commit_rqs(struct blk_mq_hw_ctx *hctx)
> {
> - struct request_queue *q = hctx->queue;
> - struct scsi_device *sdev = q->queuedata;
> - struct Scsi_Host *shost = sdev->host;
> + struct Scsi_Host *shost = hctx->driver_data;
>
> shost->hostt->commit_rqs(shost, hctx->queue_num);
> }
> @@ -1898,6 +1904,7 @@ static const struct blk_mq_ops scsi_mq_ops = {
> .cleanup_rq = scsi_cleanup_rq,
> .busy = scsi_mq_lld_busy,
> .map_queues = scsi_map_queues,
> + .init_hctx = scsi_init_hctx,
> .poll = scsi_mq_poll,
> };
>
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2021-03-01 7:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 7:40 [PATCH v4 0/5] io_uring iopoll in scsi layer Kashyap Desai
2021-02-15 7:40 ` [PATCH v4 1/5] add io_uring with IOPOLL support " Kashyap Desai
2021-02-15 7:40 ` Kashyap Desai
2021-02-15 7:40 ` [PATCH v4 2/5] megaraid_sas: iouring iopoll support Kashyap Desai
2021-02-15 7:40 ` [PATCH v4 3/5] scsi_debug : " Kashyap Desai
2021-02-15 7:40 ` [PATCH v4 4/5] scsi_debug: add new defer type for mq poll Kashyap Desai
2021-03-01 7:32 ` Hannes Reinecke
2021-02-15 7:40 ` [PATCH v4 5/5] scsi: set shost as hctx driver_data Kashyap Desai
2021-03-01 7:32 ` Hannes Reinecke [this message]
2021-03-04 3:27 ` [PATCH v4 0/5] io_uring iopoll in scsi layer Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6060c485-3cf2-3f3a-a7f6-7d99101a53b5@suse.de \
--to=hare@suse.de \
--cc=kashyap.desai@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.