From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Brian Foster <bfoster@redhat.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"huangjh.jy@fujitsu.com" <huangjh.jy@fujitsu.com>
Subject: Re: [PATCH] xfs/145: Remove useless -f option for xfs_quota command
Date: Sun, 25 Apr 2021 02:10:02 +0000 [thread overview]
Message-ID: <6084DDAC.8090201@fujitsu.com> (raw)
In-Reply-To: <YIKr47vkI1PsjJeY@bfoster>
on 2021/4/23 19:13, Brian Foster wrote:
> On Thu, Apr 22, 2021 at 01:05:43PM +0800, Yang Xu wrote:
>> Since it is a xfs specifal case, we don't need to use foreign filesystem mode.
>>
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>> Signed-off-by: Jinhui Huang<huangjh.jy@fujitsu.com>
>> ---
>
> Seems reasonable. Any particular reason for this change, or just an
> observation?
I tested this case on Centos7.9 and then I got this failure
/usr/sbin/xfs_quota: invalid option -- 'f'
so I sent this patch.
When I tested this case on unpatched upstream kernel, it still pass. So
this case does need some special requirements(like xfsprogs version, or
other kernel config)?
Best Regards
Yang Xu
>
> Reviewed-by: Brian Foster<bfoster@redhat.com>
>
>> tests/xfs/145 | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/xfs/145 b/tests/xfs/145
>> index 3b3c375d..3ccbb923 100755
>> --- a/tests/xfs/145
>> +++ b/tests/xfs/145
>> @@ -51,7 +51,7 @@ $FILEFRAG_PROG -v $SCRATCH_MNT/testy 2>&1 | grep -q delalloc || \
>> rm -f $SCRATCH_MNT/testy
>>
>> echo "Run test program"
>> -$XFS_QUOTA_PROG -f -x -c 'report -ap' $SCRATCH_MNT>> $seqres.full
>> +$XFS_QUOTA_PROG -x -c 'report -ap' $SCRATCH_MNT>> $seqres.full
>> $here/src/chprojid_fail $SCRATCH_MNT/blah
>>
>> # The regression we're testing for is an accounting bug involving delalloc
>> @@ -64,7 +64,7 @@ $FILEFRAG_PROG -v $SCRATCH_MNT/blah 2>&1 | grep -q delalloc || \
>> echo "file didn't get delalloc extents, test invalid?"
>>
>> # Make a note of current quota status for diagnostic purposes
>> -$XFS_QUOTA_PROG -f -x -c 'report -ap' $SCRATCH_MNT>> $seqres.full
>> +$XFS_QUOTA_PROG -x -c 'report -ap' $SCRATCH_MNT>> $seqres.full
>>
>> # success, all done
>> status=0
>> --
>> 2.23.0
>>
>
prev parent reply other threads:[~2021-04-25 2:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 5:05 [PATCH] xfs/145: Remove useless -f option for xfs_quota command Yang Xu
2021-04-23 11:13 ` Brian Foster
2021-04-25 2:10 ` xuyang2018.jy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6084DDAC.8090201@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=huangjh.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.