All of lore.kernel.org
 help / color / mirror / Atom feed
From: xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test
Date: Wed, 26 May 2021 04:00:09 +0000	[thread overview]
Message-ID: <60ADC7EC.5080706@fujitsu.com> (raw)
In-Reply-To: <YK0GqLg9AUrOxPdx@yuki>

Hi Cyril
> Hi!
>>> stx_attributes_mask shows what's supported in stx_attributes.
>>> Set supp_{append,compr,immutable,nodump} attributes only on filesystems
>>> which actually support it.
>>>
>>> Also merge duplicate code.
>>>
>>> ---------------
>>> v2->v3:
>>> 1.add kernel version check for stx_attributes_mask
>>> 2. use test_flag(int) instead of test_flagged and test_unflagged
>>> ---------------
>>>
>>> Signed-off-by: Yang Xu<xuyang2018.jy@cn.fujitsu.com>
>>> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>>
>> Reviewed-by: Li Wang<liwang@redhat.com>
>>
>> This patch makes sense to me, I'm not sure if any blocker issue for
>> holding the apply process. If _no_ I would help to merge it:).
>
> See:
>
> https://github.com/linux-test-project/ltp/issues/557
>
> Basically this change hides a kernel bug.
I don't think it is a kernel bug and it is only an non-supported feature 
before linux 5.1 when not using ext4 driver for ext2.

> I've proposed to create a
> separate test for kernel that makes sure that all flags that are
> supposed to be enabled are enabled for new enough kernels, then we can
> apply this patch.
But not all fs support all flags, like xfs it doesn't support 
STATX_ATTR_COMPRESSED flag even now.

[1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/xfs/xfs_iops.c#n611
>


  reply	other threads:[~2021-05-26  4:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 10:34 [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test Yang Xu
2019-08-02 11:50 ` Cyril Hrubis
2019-08-20  6:33   ` [LTP] [PATCH v2] " Yang Xu
2019-08-27  9:25     ` Petr Vorel
2019-08-27  9:58       ` Petr Vorel
2019-08-27 10:16         ` Cyril Hrubis
2019-09-11 10:22           ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-09-11 12:47             ` Cyril Hrubis
2019-09-12  3:28               ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-10-25  3:53               ` [LTP] [PATCH] " Yang Xu
2019-10-31 10:03                 ` Yang Xu
2021-05-25 13:18                 ` Li Wang
2021-05-25 14:16                   ` Cyril Hrubis
2021-05-26  4:00                     ` xuyang2018.jy [this message]
2021-05-26  8:31                       ` Li Wang
2021-05-26 10:02                         ` xuyang2018.jy
2021-11-10 13:28                 ` Richard Palethorpe
2021-11-11  3:25                   ` xuyang2018.jy
2019-08-28  3:56       ` [LTP] [PATCH v2] " Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60ADC7EC.5080706@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.