From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24EE1C433F5 for ; Thu, 23 Sep 2021 13:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06B6261090 for ; Thu, 23 Sep 2021 13:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241395AbhIWN67 (ORCPT ); Thu, 23 Sep 2021 09:58:59 -0400 Received: from mail-dm6nam08on2079.outbound.protection.outlook.com ([40.107.102.79]:43360 "EHLO NAM04-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235976AbhIWN66 (ORCPT ); Thu, 23 Sep 2021 09:58:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ed8fMpEkq6CnGe034dLBhiDiUTz1Yts+g4zQpjob1D2iU44znToKFFkfhXWejHEuhVqupEukeNOX7NlB4VmDw9+6ltlWkyJ5B8tZ8b4EgM7dbSwp1BzfQ+ic+nRVsD22igPxCRh25orKg71rUDtLFfh2IL6dna1mnB3lX5UphTHSNuduZNwPEVyMqwmNvzBktzYBcq9g7JAidUPmrm1aFUSoiUZyHPyxk3Q3e8Iv94YSh7kH/R9mPh6BBvqWDfYDFsTv2LLQitqfKuiBiYHA5u5TR/yTQEaLSW6S/Q4IFS5OeU1qfPXtUtX48BejpRo4edf9knKXmkLSBCZUQrb0kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fuRrMtGUpJYB192uQ5rJqL2JRpK1mp70DkeCjo6MwvI=; b=N108xyZtB78FzVXQqdnpv9QsFKlwYykm7Q6E6CK3VL0tDfifcINoIyQ4BEmmr/ftVMIn6YlwAOnIDZS1mMfrkjt9NibIST4cxV6ppeCan7uwZ7RAc6mAxjAjI2F2GMQx6aiKzppwrvsnaK8JPZs0MrGFuo9oPOtoxjOoSJyXjdLsJ4oU56dB/A1vyq4dOyjT8m/qTgC6sa3x2ugfXKZOj6HS1b/0z9qT1m+ag1OeMFbfUc0K7HP6pnKR86UBilszDQE+aqbnmlwQrPtLflvbDjPvn1lsJmc0iq+XKIMnk5STCm67/GGPqR2CL4YORRCdDfwrnAC5Qi8ge5H3aAmbmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.36) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fuRrMtGUpJYB192uQ5rJqL2JRpK1mp70DkeCjo6MwvI=; b=szZfX2jf0626s/zX+x2AVhd4d2ff78VJgfB6sYWbjMJma5fuAKxWT+mBL3/EEAa0AgFq4+0TuuGNHT3NoixrNLKaqP/bjcLwewk510q/P5b2DTYvCSUfg/4hTys+CpYX01nwC2hv+BSlGT3rey5yik9Cuzo7h2Tl5Cwm1O1SjnedmjYPSGw0YreJtuH9fQATKh71dHVcHLJBubHouMu7tCS17uyZrKyF9Sk8PCucnGwcf663051NQCWXqw+0G07WGJ2m2J+LFtO//5WDhGh7DBrKOT76S+GhqUX6yRToPWzE2um+vQDTbhVTiU3DUskBkNtMTVgmVEnCuOZmjm1GXw== Received: from DM5PR19CA0060.namprd19.prod.outlook.com (2603:10b6:3:116::22) by BN6PR12MB1827.namprd12.prod.outlook.com (2603:10b6:404:fd::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Thu, 23 Sep 2021 13:57:23 +0000 Received: from DM6NAM11FT041.eop-nam11.prod.protection.outlook.com (2603:10b6:3:116:cafe::16) by DM5PR19CA0060.outlook.office365.com (2603:10b6:3:116::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Thu, 23 Sep 2021 13:57:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.36) smtp.mailfrom=nvidia.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.36 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.36; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.36) by DM6NAM11FT041.mail.protection.outlook.com (10.13.172.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4544.13 via Frontend Transport; Thu, 23 Sep 2021 13:57:22 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 23 Sep 2021 13:57:22 +0000 Received: from [172.27.15.96] (172.20.187.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 23 Sep 2021 13:57:18 +0000 Subject: Re: [PATCH mlx5-next 3/7] vfio/pci_core: Make the region->release() function optional To: Leon Romanovsky , Doug Ledford , Jason Gunthorpe CC: Yishai Hadas , Alex Williamson , Bjorn Helgaas , "David S. Miller" , Jakub Kicinski , "Kirti Wankhede" , , , , , , Saeed Mahameed References: From: Max Gurtovoy Message-ID: <60b22817-442f-c7ac-3dce-8f8a57c12c4b@nvidia.com> Date: Thu, 23 Sep 2021 16:57:16 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aefb4f5c-ff32-4044-3c8d-08d97e9a1171 X-MS-TrafficTypeDiagnostic: BN6PR12MB1827: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qM7GV6SyZiJBzuV+iXIb0HkaXd5weNSUaNsZSptBIHRR8IFqM4780pH7ctpHIUarRL05WHmd/SLQ/pEU+t9ZjNmXUmFVR0qHZb2XMqqNP3VeUe3netUfFePQME6VFzfu4s3A0e9dmIMEegQ+W0b/6ss4vMTNLfX/egxwLFfcdU/o3qoqdZE/zXNBSsJ4vNSc49WAU6o1SeHxvWrx5SnCMzYHUUl4y7oc7HyXTtNzqh7bEEMwjSIurL9veI5OL5C+2/PhfqlnNhjbjb5qHLMjK+C+lHN2SFwy4aCPXS9JMlPCNJRi+7pAWxi7K/gR0niDNM9h0ksnIQ5n4YKqxXhYu0iCxeHJh/oLtrLTfCcx8FGEzjVw/t/2qr6b7/tVosYfC1zbl+BnSSSTLwXMWHUoXCu6KDKu6akgVA8uNTsVOQP9T3ioModwmVngFS+RGVmD7U2Cg+01a+gKQvSta3Or9+k8IcAPLA7px/KSU5+Q7L5t5nZBeAgCQ6hMNi9icE8zyIVHBaEE2bnG1JTMo+Z08jwZcroUvbKfY4RYdVAy567bBrFPqvatQ341mu5+A6uLFG4kwjMWw+Yy+aKwiK00aSetAKHLbTeXU5fuTHa8R12mvBxmD2FlespQYbkOQnlMvRWkpfm+pOBqiN8UHsZlAYJWwyysOGsaZwTG40I6+G97DM70OKqxjc8HlcjTQaODXUjhgnsATbaF/cE3iZZhDWH3BPGTLYCP6ZqtjC0XDwY= X-Forefront-Antispam-Report: CIP:216.228.112.36;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid05.nvidia.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(508600001)(83380400001)(186003)(53546011)(16526019)(356005)(336012)(36860700001)(82310400003)(26005)(7416002)(4326008)(31696002)(2906002)(31686004)(36906005)(8936002)(70586007)(8676002)(16576012)(316002)(54906003)(86362001)(2616005)(5660300002)(7636003)(70206006)(36756003)(110136005)(6636002)(107886003)(426003)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2021 13:57:22.9574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aefb4f5c-ff32-4044-3c8d-08d97e9a1171 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.36];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT041.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1827 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 9/22/2021 1:38 PM, Leon Romanovsky wrote: > From: Yishai Hadas > > Make the region->release() function optional as in some cases there is > nothing to do by driver as part of it. > > This is needed for coming patch from this series once we add > mlx5_vfio_cpi driver to support live migration but we don't need a mlx5_vfio_pci *typo > migration release function. > > Signed-off-by: Yishai Hadas > Signed-off-by: Leon Romanovsky > --- > drivers/vfio/pci/vfio_pci_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c > index 68198e0f2a63..3ddc3adb24de 100644 > --- a/drivers/vfio/pci/vfio_pci_core.c > +++ b/drivers/vfio/pci/vfio_pci_core.c > @@ -341,7 +341,8 @@ void vfio_pci_core_disable(struct vfio_pci_core_device *vdev) > vdev->virq_disabled = false; > > for (i = 0; i < vdev->num_regions; i++) > - vdev->region[i].ops->release(vdev, &vdev->region[i]); > + if (vdev->region[i].ops->release) > + vdev->region[i].ops->release(vdev, &vdev->region[i]); > > vdev->num_regions = 0; > kfree(vdev->region); Looks good, Reviewed-by: Max Gurtovoy