From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6C4C47082 for ; Sat, 29 May 2021 15:23:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9DDC611EE for ; Sat, 29 May 2021 15:23:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9DDC611EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shipmail.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 766956E217; Sat, 29 May 2021 15:23:20 +0000 (UTC) Received: from ste-pvt-msa1.bahnhof.se (ste-pvt-msa1.bahnhof.se [213.80.101.70]) by gabe.freedesktop.org (Postfix) with ESMTPS id 457BB6E217 for ; Sat, 29 May 2021 15:23:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTP id 26DFF3FB4F; Sat, 29 May 2021 17:23:16 +0200 (CEST) Authentication-Results: ste-pvt-msa1.bahnhof.se; dkim=pass (1024-bit key; unprotected) header.d=shipmail.org header.i=@shipmail.org header.b="mlpu/hVo"; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at bahnhof.se Received: from ste-pvt-msa1.bahnhof.se ([127.0.0.1]) by localhost (ste-pvt-msa1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hVMSEvI7OeIM; Sat, 29 May 2021 17:23:15 +0200 (CEST) Received: by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTPA id 88AD13FB33; Sat, 29 May 2021 17:23:14 +0200 (CEST) Received: from [192.168.0.209] (h-155-4-205-35.A357.priv.bahnhof.se [155.4.205.35]) by mail1.shipmail.org (Postfix) with ESMTPSA id 262793600DD; Sat, 29 May 2021 17:23:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1622301794; bh=5mdr/iu1/EZeMAkwEh7XJb0J+fHjgQw9ZUmaysPq2YA=; h=Subject:To:References:From:Date:In-Reply-To:From; b=mlpu/hVoYIEt127bg7s7LCLbtTVnYPJ4cqjirCp8mS/2IdDjNJO5Rv+OT2K+Hf3z7 wjR09/rQRHQl5dqlEHLtPSABvATn9foq9WcExd6fLE7/x6R6fXDyAVcJny80W2Kdhd WU4rf2+7U6LWbit+aQnkF7jW4R1HqgW6f3D0Q5yU= Subject: Re: ttm_resource_manager::use_tt To: Zack Rusin , =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel References: <3ed92523-df06-87cd-f926-e632b780f69b@vmware.com> <54e4bb04-602b-b1d3-7361-8badce45206a@vmware.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= Message-ID: <60c9d566-608e-95c1-59d1-4d5051c1997e@shipmail.org> Date: Sat, 29 May 2021 17:23:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <54e4bb04-602b-b1d3-7361-8badce45206a@vmware.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 5/28/21 9:30 PM, Zack Rusin wrote: > On 5/22/21 3:13 AM, Christian König wrote: >> Hi Zack, >> >> IIRC that was for the VMW_PL_GMR type, wasn't it? >> >> As far as I have seen that backend was just giving out unique numbers >> and it looked questionable that we allocated pages for that. >> >> E.g. when you set that flag then for each allocation we also allocate >> a TTM tt structure and a corresponding page. >> > > Got ya. Yea, it's a little messy. I think it's correct. Those unique > numbers are just identifiers for the bo's but the actual memory for > them is regular system memory (e.g. we just tell our virtual hardware, > here's some guest system pages and here's a unique id that we'll be > using the refer to them). > > Yes, allocating pages for that memory type is correct. The main difference to other hardware here is that on other hardware those are bound to gpu using a range in a translation table. With vmwgfx they are bound using a slot with a unique integer.. /Thomas