From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C60BC4727E for ; Thu, 1 Oct 2020 20:19:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5E852074B for ; Thu, 1 Oct 2020 20:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733078AbgJAUTX (ORCPT ); Thu, 1 Oct 2020 16:19:23 -0400 Received: from smtprelay0169.hostedemail.com ([216.40.44.169]:60940 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726581AbgJAUTX (ORCPT ); Thu, 1 Oct 2020 16:19:23 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 283CD180A7FF8; Thu, 1 Oct 2020 20:19:22 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: mice75_5c06f2d2719e X-Filterd-Recvd-Size: 2850 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Thu, 1 Oct 2020 20:19:19 +0000 (UTC) Message-ID: <61445711991c2d6eb7c8fb05bed2814458e2593b.camel@perches.com> Subject: Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo") From: Joe Perches To: Segher Boessenkool , Miguel Ojeda Cc: Kees Cook , "Paul E . McKenney" , Nick Desaulniers , Lai Jiangshan , Josh Triplett , Steven Rostedt , LKML , rcu@vger.kernel.org, Clang-Built-Linux ML , Mathieu Desnoyers , Sedat Dilek , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Date: Thu, 01 Oct 2020 13:19:18 -0700 In-Reply-To: <20201001193937.GM28786@gate.crashing.org> References: <20200929192549.501516-1-ndesaulniers@google.com> <133589afbe999347454dfcc46ae782897bf9e3a2.camel@perches.com> <46f69161e60b802488ba8c8f3f8bbf922aa3b49b.camel@perches.com> <417ffa3fd3fba5d4a481db6a0b0c9b48cbbb17c4.camel@perches.com> <46040e2776a4848add06126ce1cb8f846709294f.camel@perches.com> <20201001193937.GM28786@gate.crashing.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-10-01 at 14:39 -0500, Segher Boessenkool wrch/ote: > Hi! > > On Thu, Oct 01, 2020 at 12:15:39PM +0200, Miguel Ojeda wrote: > > > So it looks like the best option is to exclude these > > > 2 files from conversion. > > > > Agreed. Nevertheless, is there any reason arch/powerpc/* should not be > > compiling cleanly with compiler.h? (CC'ing the rest of the PowerPC > > reviewers and ML). > > You need to #include compiler_types.h to get this #define? Actually no, you need to add #include to both files and then it builds properly. Ideally though nothing should include this file directly. > (The twice-defined thing is a warning, not an error. It should be fixed > of course, but it is less important; although it may be pointing to a > deeper problem.) > > > Segher