All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Stefano Stabellini <stefano.stabellini@xilinx.com>,
	andrew.cooper3@citrix.com, george.dunlap@citrix.com,
	iwj@xenproject.org, julien@xen.org, wl@xen.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 2/2] xen: add (EXPERT) to one-line descriptions when appropriate
Date: Tue, 26 Jan 2021 10:26:36 +0100	[thread overview]
Message-ID: <61899bf7-dbd0-dd38-473f-b0a88cb6e87a@suse.com> (raw)
In-Reply-To: <20210125212747.26676-2-sstabellini@kernel.org>

On 25.01.2021 22:27, Stefano Stabellini wrote:
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -103,7 +103,7 @@ config HVM
>  	  If unsure, say Y.
>  
>  config XEN_SHSTK
> -	bool "Supervisor Shadow Stacks"
> +	bool "Supervisor Shadow Stacks (EXPERT)"
>  	depends on HAS_AS_CET_SS && EXPERT
>  	default y
>  	---help---

I agree with this addition, but I'm afraid I'm at least uncertain
about all the other ones made here, where ...

> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -12,7 +12,7 @@ config CORE_PARKING
>  	bool
>  
>  config GRANT_TABLE
> -	bool "Grant table support" if EXPERT
> +	bool "Grant table support (EXPERT)" if EXPERT
>  	default y

... like e.g. here, it's only the prompt that's conditional. IOW
like with the respective uses of UNSUPPORTED in some of the Arm
changes in patch 1, especially when the option's default is "yes"
it's not the feature that is an expert one, but its turning off
is considered an expert change. Which I don't think should be
expressed this way.

Jan


  reply	other threads:[~2021-01-26  9:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 21:27 [PATCH v4 0/2] introduce UNSUPPORTED Stefano Stabellini
2021-01-25 21:27 ` [PATCH v4 1/2] xen: EXPERT clean-up and " Stefano Stabellini
2021-01-26  9:22   ` Jan Beulich
2021-01-26 11:06     ` Bertrand Marquis
2021-01-26 11:11       ` Jan Beulich
2021-01-26 11:17         ` Bertrand Marquis
2021-01-26 13:08           ` Jan Beulich
2021-01-26 13:17             ` Ian Jackson
2021-01-26 13:19               ` Jan Beulich
2021-01-26 13:20                 ` Bertrand Marquis
2021-01-26 15:18                   ` Marek Marczykowski-Górecki
2021-01-26 15:23               ` Jan Beulich
2021-01-26 18:28             ` Stefano Stabellini
2021-01-26 13:51   ` Julien Grall
2021-01-26 14:23     ` Bertrand Marquis
2021-01-26 18:26     ` Stefano Stabellini
2021-01-25 21:27 ` [PATCH v4 2/2] xen: add (EXPERT) to one-line descriptions when appropriate Stefano Stabellini
2021-01-26  9:26   ` Jan Beulich [this message]
2021-01-26 18:36     ` Stefano Stabellini
2021-01-26 11:08   ` Bertrand Marquis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61899bf7-dbd0-dd38-473f-b0a88cb6e87a@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=stefano.stabellini@xilinx.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.