From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH for-next] io_uring: ensure IOSQE_ASYNC file table grabbing works, with SQPOLL
Date: Tue, 8 Sep 2020 15:22:47 -0600 [thread overview]
Message-ID: <622649c5-e30d-bc3c-4709-bbe60729cca1@kernel.dk> (raw)
In-Reply-To: <8f6871c4-1344-8556-25a7-5c875aebe4a5@gmail.com>
On 9/8/20 2:58 PM, Pavel Begunkov wrote:
> On 08/09/2020 20:48, Jens Axboe wrote:
>> Fd instantiating commands like IORING_OP_ACCEPT now work with SQPOLL, but
>> we have an error in grabbing that if IOSQE_ASYNC is set. Ensure we assign
>> the ring fd/file appropriately so we can defer grab them.
>
> IIRC, for fcheck() in io_grab_files() to work it should be under fdget(),
> that isn't the case with SQPOLL threads. Am I mistaken?
>
> And it looks strange that the following snippet will effectively disable
> such requests.
>
> fd = dup(ring_fd)
> close(ring_fd)
> ring_fd = fd
Not disagreeing with that, I think my initial posting made it clear
it was a hack. Just piled it in there for easier testing in terms
of functionality.
But the next question is how to do this right...
--
Jens Axboe
next prev parent reply other threads:[~2020-09-08 21:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 17:48 [PATCH for-next] io_uring: ensure IOSQE_ASYNC file table grabbing works, with SQPOLL Jens Axboe
2020-09-08 20:58 ` Pavel Begunkov
2020-09-08 21:22 ` Jens Axboe [this message]
2020-09-08 22:54 ` Jens Axboe
2020-09-09 0:48 ` Josef
2020-09-09 7:09 ` Pavel Begunkov
2020-09-09 13:10 ` Jens Axboe
2020-09-09 13:53 ` Jens Axboe
2020-09-09 15:48 ` Pavel Begunkov
2020-09-09 16:07 ` Jens Axboe
2020-09-10 12:37 ` Pavel Begunkov
2020-09-10 13:11 ` Jens Axboe
2020-09-10 18:18 ` Jens Axboe
2020-09-10 21:01 ` Jens Axboe
2020-09-10 22:11 ` Jens Axboe
2020-09-10 23:04 ` Jens Axboe
2020-09-11 19:23 ` Pavel Begunkov
2020-09-11 20:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=622649c5-e30d-bc3c-4709-bbe60729cca1@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.