From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cleber Rosa <crosa@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: Re: [PATCH v2] tests/acceptance: Test case for detecting -object crashes
Date: Mon, 26 Oct 2020 09:16:14 +0100 [thread overview]
Message-ID: <6280d778-8fcb-346b-b41d-66282d892e42@redhat.com> (raw)
In-Reply-To: <20201013180120.GB1065819@localhost.localdomain>
On 10/13/20 8:01 PM, Cleber Rosa wrote:
> On Tue, Oct 13, 2020 at 01:46:11PM -0400, Eduardo Habkost wrote:
>> On Sun, Oct 11, 2020 at 11:18:59PM -0400, Cleber Rosa wrote:
>>> On Sat, Oct 10, 2020 at 09:54:16AM +0200, Philippe Mathieu-Daudé wrote:
>>>> On 10/9/20 10:29 PM, Eduardo Habkost wrote:
>>>>> Add a simple test case that will run QEMU directly (without QMP)
>>>>> just to check for crashes when using `-object`.
>>>>>
>>>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>>>> ---
>>>>> Changes v1 -> v2:
>>>>> * "Running command:" log message instead of "Command:" (Cleber)
>>>>> * Use universal_newlines=True instead of encoding='utf-8' (Cleber)
>>>>> * Rename devices() to get_devices() (Cleber)
>>>>> * Use @avocado.fail_on(subprocess.CalledProcessError) (Cleber)
>>>>> * Reword test_crash() docstring (Cleber)
>>>>> * Reorder imports
>>>>
>>>> Assuming:
>>>> Based-on: <20201008202713.1416823-1-ehabkost@redhat.com>
>>>>
>>>> I get:
>>>>
>>>> (1/2) tests/acceptance/object_option.py:ObjectOption.test_help:
>>>> qemu-system-avr: No machine specified, and there is no default
>>>> Use -machine help to list supported machines
>>>> FAIL: CalledProcessError(1, ['./qemu-system-avr', '-object', 'help']) (0.19
>>>> s)
>>>> (2/2) tests/acceptance/object_option.py:ObjectOption.test_crash:
>>>> qemu-system-avr: No machine specified, and there is no default
>>>> Use -machine help to list supported machines
>>>> FAIL: CalledProcessError(1, ['./qemu-system-avr', '-object', 'help']) (0.18
>>>> s)
>>>>
>>>
>>> Did you influence (test parameter?) the QEMU binary to be used?
>>
>> I'm assuming this was triggered by "make check-acceptance". I
>
> The output shows test 1/2 and 2/2, so I don't think it was triggered
> by "make check-acceptance".
I tested it in a build dir configured with:
../configure --target-list=avr-softmmu
I will test it again during the week.
>
>> will change the test case to use '-machine none', which should
>> work on all architectures.
>>
>
> +1, sounds good!
> - Cleber.
>
>> --
>> Eduardo
>
next prev parent reply other threads:[~2020-10-26 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 20:29 [PATCH v2] tests/acceptance: Test case for detecting -object crashes Eduardo Habkost
2020-10-10 7:54 ` Philippe Mathieu-Daudé
2020-10-12 3:18 ` Cleber Rosa
2020-10-13 17:46 ` Eduardo Habkost
2020-10-13 18:01 ` Cleber Rosa
2020-10-26 8:16 ` Philippe Mathieu-Daudé [this message]
2020-10-26 8:17 ` Philippe Mathieu-Daudé
2020-10-26 12:07 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6280d778-8fcb-346b-b41d-66282d892e42@redhat.com \
--to=philmd@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.