From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6174C433FE for ; Fri, 10 Dec 2021 18:22:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238381AbhLJS00 (ORCPT ); Fri, 10 Dec 2021 13:26:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48998 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232317AbhLJS00 (ORCPT ); Fri, 10 Dec 2021 13:26:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639160570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nZEdGnstxQ8PoTabR6E6wRag+oPqL+RCSE7JPAUHZTU=; b=ekoEHwa0TuOrQ5vnyq1bIQIEO7gbyMww9VEkh0bKPi9jMRqIp39HV3CVvzlACeBIrJmkWN plDhQg5k0GmDyb1GP8KrCeyJZgo41jgg+OHI/Bt3pnA1+PjH+em19oK4Tpztv03MXVo5dD E20XcsJ443LTnoCCPBDgcEsRz7Bj/vQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-43TWk63LNrGNowg1GuuTXw-1; Fri, 10 Dec 2021 13:22:49 -0500 X-MC-Unique: 43TWk63LNrGNowg1GuuTXw-1 Received: by mail-wr1-f69.google.com with SMTP id q15-20020adfbb8f000000b00191d3d89d09so2610990wrg.3 for ; Fri, 10 Dec 2021 10:22:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nZEdGnstxQ8PoTabR6E6wRag+oPqL+RCSE7JPAUHZTU=; b=auRwQwgOC7cpjnAF0lKEpKW4hJ2xeVmj81BQL93NxQIdEnVJCpHCeHHBhYuwI0JL15 fQtsr62VULviuvdmHUDsRCEOXkaAZCHYRayHUR7LXq4c6DcPKv0H9lwGp0z/f0F+n64U m8QCvEl3HTOxH8H/i8sMIQZAbiR3jKeSJ3KWwoJYpSQnJOOnF+p5F//53nKAL5SfQ1Uq F5f7CZnj8plNg013kL8j3vFuvCnS2g2fu8NseX4Ytl9l1de/petfZpBs6uoowd4diqtk v8nrOu4w7Ff6cH6ERI9rUJJrSqUXKj5xLxAP75JTd95USdf8bQR3xnaQ6Ge399RAVkFg rwhA== X-Gm-Message-State: AOAM533pCrcgImkdUQN+t5OUxNn4cenYipzKEk8OZG+4645A7kGCxbGk 2a31ICne8pX0SsED0XetmEOq2tk0mympHnkeUCBgWjIdlJXpKzcNKS8T25csL9Bbv4RU4JDDYK4 milmM4c5vjajGSmQwYeuSxQ== X-Received: by 2002:adf:eac4:: with SMTP id o4mr713927wrn.690.1639160568198; Fri, 10 Dec 2021 10:22:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6nhHXYerqIXAuvpATTJJeDQXMUHYl68D08WgHnAzNZ7gCdpfn4qi7oHPJKgkEEBsrCS8LsQ== X-Received: by 2002:adf:eac4:: with SMTP id o4mr713883wrn.690.1639160567889; Fri, 10 Dec 2021 10:22:47 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id a1sm4209149wri.89.2021.12.10.10.22.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 10:22:47 -0800 (PST) Message-ID: <628226e2-6e1c-a05d-fc00-82c7496da38d@redhat.com> Date: Fri, 10 Dec 2021 19:22:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 1/3] spi: Revert "spi: Remove unused function spi_busnum_to_master()" Content-Language: en-US To: Lucas tanure , Andy Shevchenko , Stefan Binding Cc: Mark Brown , "Rafael J . Wysocki" , Len Brown , Mark Gross , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@opensource.cirrus.com References: <20211202162421.7628-1-sbinding@opensource.cirrus.com> <85e9e11d-a4fc-44a9-55c2-3a4d2de7769d@opensource.cirrus.com> From: Hans de Goede In-Reply-To: <85e9e11d-a4fc-44a9-55c2-3a4d2de7769d@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 12/10/21 19:10, Lucas tanure wrote: > On 12/3/21 11:14, Hans de Goede wrote: >> Hi, >> >> On 12/3/21 12:06, Andy Shevchenko wrote: >>> On Thu, Dec 02, 2021 at 04:24:19PM +0000, Stefan Binding wrote: >>>> From: Lucas Tanure >>>> >>>> Revert commit bdc7ca008e1f ("spi: Remove unused function >>>> spi_busnum_to_master()") >>>> This function is needed for the spi version of i2c multi >>>> instantiate driver. >>> >>> I understand the intention, but I have no clue from this series (it lacks of >>> proper cover letter, it lacks of much better and justified commit message in >>> the patch 3) what is the actual issue. Without these to be provided it's no go >>> for the series. Please, provide much better description what is the actual >>> issue you are trying to solve (from patch 3 my guts telling me that this can >>> be achieved differently without this code being involved). >> >> Yes I assume that eventually there will be a follow-up which will >> actually add some new ACPI HIDs to the new bus-multi-instantiate.c file ? >> > Yes, we are developing an HDA sound driver for the HID CSC3551, > which is used for laptops that use SPI or I2C. > And in that series is where we plan to put a patch to add that HID. > >> Can we please have (some of) those patches as part of the next >> version, so that we can see how you will actually use this? > The series is this one https://lkml.org/lkml/2021/11/23/723, but > the SPI HID was not ready to be sent in that version, but will be > part of the next submission. > >> >> Also I'm wondering is this actually about ACPI device's having multiple >> SpiSerialBusV2 resources in a single _CRS resource list ? > yes, a single _CRS with 2 or 4 SpiSerialBusV2 inside. > >> >> Or do you plan to use this for devices with only a single >> I2cSerialBusV2 or SpiSerialBusV2 resource to e.g. share IRQ lookup >> code between the 2 cases ? > No, the minimum number SpiSerialBusV2 or I2cSerialBusV2 inside the > _CRS is two. > >> >> If you plan to use this for devices with only a single >> I2cSerialBusV2 or SpiSerialBusV2 resource, then I'm going to have to >> nack this. >> >> Each ACPI HID which needs to be handled in this code also needs an >> entry in the i2c_multi_instantiate_ids[] list in drivers/acpi/scan.c >> which is code which ends up loaded on every single ACPI system, so >> we really only want to add HIDs there for the special case of having >> multiple I2cSerialBusV2 or SpiSerialBusV2 resources in a single >> ACPI Device / ACPI fwnode. >> >> If you are looking to use this as a way to share code for other reasons >> (which is a good goal to strive for!) please find another way, such >> as e.g. adding some helper functions to drivers/gpio/gpiolib-acpi.c >> (note there already are a couple of helpers there which you may use). > No, we only want to multi instantiate SPI or I2C devices from a single _CRS. Ok, that is fine, thank you for clarifying things. Regards, Hans