Re: [PATCH meta-oe 6/9] vlc: Imported from OE classic

From: Koen Kooi <koen@dominion.thruhere.net>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH meta-oe 6/9] vlc: Imported from OE classic
Date: Fri, 26 Aug 2011 09:55:22 +0200	[thread overview]
Message-ID: <6302E210-41EB-42C8-9B4F-446C5D8A8F4E@dominion.thruhere.net> (raw)
In-Reply-To: <1314318504-9524-7-git-send-email-joelagnel@ti.com>

Op 26 aug. 2011, om 02:28 heeft Joel A Fernandes het volgende geschreven:

> Signed-off-by: Joel A Fernandes <joelagnel@ti.com>
> ---
> vlc is not an mplayer depdency, but libdvdcss is an mplayer depedency and it is included in the recipes/vlc directory in oe-classic. I have imported vlc as well for completeness.
> 
> meta-oe/recipes-multimedia/vlc/vlc.inc        |   61 +++++++++++++++++++++++++
> meta-oe/recipes-multimedia/vlc/vlc_1.1.4.1.bb |   51 +++++++++++++++++++++
> 2 files changed, 112 insertions(+), 0 deletions(-)
> create mode 100644 meta-oe/recipes-multimedia/vlc/vlc.inc
> create mode 100644 meta-oe/recipes-multimedia/vlc/vlc_1.1.4.1.bb
> 
> diff --git a/meta-oe/recipes-multimedia/vlc/vlc.inc b/meta-oe/recipes-multimedia/vlc/vlc.inc
> new file mode 100644
> index 0000000..0435e87
> --- /dev/null
> +++ b/meta-oe/recipes-multimedia/vlc/vlc.inc
> @@ -0,0 +1,61 @@
> +DESCRIPTION = "Video player and streamer - davinci edition"
> +HOMEPAGE = "http://www.videolan.org"
> +LICENSE = "GPL"

Which version?

> +PRIORITY = "optional"

That field isn't used anymore

> +SECTION = "multimedia"
> +
> +DEPENDS = "libfribidi libtool hal gettext libgcrypt schroedinger virtual/libsdl qt4-x11-free dbus libxml2 gnutls tremor faad2 ffmpeg flac \
> +           ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad libid3tag liba52 mpeg2dec', d)}"
> +
> +INC_PR = "r4"

reset that

> 
> +++ b/meta-oe/recipes-multimedia/vlc/vlc_1.1.4.1.bb
> @@ -0,0 +1,51 @@
> +# This recipe packages vlc as a library as well, so qt4 dependencies
> +# can be avoided when ony the library is installed.
> +# Would be cool if when newer vlc is added to OE and older ones are phased
> +# out that could be made the default.

Can be made the default now?

> +
> +require vlc.inc

> +
> +PR = "${INC_PR}.1"
> +
> +SRC_URI[md5sum] = "ce17c335b38b322949694313173fcd49"
> +SRC_URI[sha256sum] = "61c9ea30a17ea40c6ccbfd507026e5c83ad9e0691f221d3667c8e49696d7c2aa"

Why isn't anll of the below in the .inc?

> +# ffmpeg from git (library version => 52) is required
> +# libtool-native must be >= 2.2.4
> +DEPENDS += "libdvdcss libdvdread lua5.1-native lua5.1"
> +RDEPENDS_${PN} += "lua5.1"
> +
> +EXTRA_OECONF += "\
> +	--enable-dvdread \
> +"
> +
> +LEAD_SONAME = "libvlc.so.5"
> +
> +PACKAGES =+ "libvlc-dbg libvlc-dev libvlc"
> +
> +FILES_libvlc-dev = "${libdir}/lib*.so"
> +
> +FILES_libvlc-dbg = "\
> +	${libdir}/.debug \
> +	${libdir}/vlc/meta_engine/.debug \
> +	${libdir}/vlc/audio_filter/.debug ${libdir}/vlc/audio_output/.debug \
> +	${libdir}/vlc/demux/.debug ${libdir}/vlc/control/.debug \
> +	${libdir}/vlc/gui/.debug ${libdir}/vlc/packetizer/.debug \
> +	${libdir}/vlc/audio_mixer/.debug ${libdir}/vlc/stream_out/.debug \
> +	${libdir}/vlc/mux/.debug ${libdir}/vlc/access/.debug \
> +	${libdir}/vlc/visualization/.debug ${libdir}/vlc/access_filter/.debug \
> +	${libdir}/vlc/access_output/.debug ${libdir}/vlc/video_output/.debug \
> +	${libdir}/vlc/services_discovery/.debug ${libdir}/vlc/video_chroma/.debug \
> +	${libdir}/vlc/video_codec/.debug ${libdir}/vlc/video_filter/.debug \
> +	${libdir}/vlc/misc/.debug ${libdir}/vlc/codec/.debug \
> +	"
> +
> +FILES_libvlc = "${libdir}/lib*.so.*"
> +
> +FILES_${PN} += "${bindir}/vlc \
> +	${datadir}/applications \
> +	${datadir}/vlc/ \
> +	"
> +
> +FILES_${PN}-dbg	+= "${libdir}/vlc/*/.debug"
> +