All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Phillip Potter <phil@philpotter.co.uk>, gregkh@linuxfoundation.org
Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev, fabioaiuto83@gmail.com
Subject: Re: [PATCH 0/7] staging: rtl8188eu: replace driver with better version
Date: Thu, 22 Jul 2021 20:56:33 -0500	[thread overview]
Message-ID: <630e139c-85e5-f006-6b64-e368847251fc@lwfinger.net> (raw)
In-Reply-To: <20210723004214.912295-1-phil@philpotter.co.uk>

On 7/22/21 7:42 PM, Phillip Potter wrote:
> I had to break this patchset up a bit to get around the file size limits
> on the mailing list, and also I removed the hostapd stuff which is
> userspace related and therefore not required.
> 
> The driver currently in staging is older and less functional than the
> version on Larry Finger's GitHub account, branch v5.2.2.4. This series
> of patches therefore:
> 
> (1) Removes the current driver from staging.
> (2) Imports the GitHub version mentioned above in its place.
> 
> There is plenty of work to do to this driver, including to its Makefile,
> but it is at least buildable/usable for now.
> 
> Phillip Potter (7):
>    staging: rtl8188eu: remove existing staging driver
>    staging: rtl8188eu: introduce new core dir for RTL8188eu driver
>    staging: rtl8188eu: introduce new hal dir for RTL8188eu driver
>    staging: rtl8188eu: introduce new os_dep dir for RTL8188eu driver
>    staging: rtl8188eu: introduce new include dir for RTL8188eu driver
>    staging: rtl8188eu: introduce new supporting files for RTL8188eu
>      driver
>    staging: rtl8188eu: attach newly imported driver to build system

Phillip,

Patch 3/7 fails with a
drivers/staging/rtl8188eu/hal/phydm_precomp.h: already exists in error:
working directory. When I deleted the file, the patch applied.

Patch 5/7 fails with a drivers/staging/rtl8188eu/include/hal_data.h: already 
exists in working directory. Again it applied when I manually deleted that file.

Patches 2-6 all have trailing whitespace warnings.

I have started testing. Unfortunately, my GitHub version has a fault in that it 
runs systemd-udevd at 100% of a CPU. So far, I have found that an older commit 
works fine. As soon as I find the fault, I will let you know.

Larry




  parent reply	other threads:[~2021-07-23  1:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23  0:42 [PATCH 0/7] staging: rtl8188eu: replace driver with better version Phillip Potter
2021-07-23  0:42 ` [PATCH 1/7] staging: rtl8188eu: remove existing staging driver Phillip Potter
2021-07-23  0:42 ` [PATCH 2/7] staging: rtl8188eu: introduce new core dir for RTL8188eu driver Phillip Potter
2021-07-23  0:42 ` [PATCH 3/7] staging: rtl8188eu: introduce new hal " Phillip Potter
2021-07-23  0:42 ` [PATCH 4/7] staging: rtl8188eu: introduce new os_dep " Phillip Potter
2021-07-23 17:33   ` kernel test robot
2021-07-23 17:33     ` kernel test robot
2021-07-23 17:33   ` [RFC PATCH] staging: rtl8188eu: fix duplicated inclusion kernel test robot
2021-07-23 17:33     ` kernel test robot
2021-07-23  0:42 ` [PATCH 5/7] staging: rtl8188eu: introduce new include dir for RTL8188eu driver Phillip Potter
2021-07-23  0:42 ` [PATCH 6/7] staging: rtl8188eu: introduce new supporting files " Phillip Potter
2021-07-23  7:29   ` Fabio Aiuto
2021-07-23 11:09   ` Greg KH
2021-07-23 11:19     ` Phillip Potter
2021-07-23 11:19       ` Phillip Potter
2021-07-23  0:42 ` [PATCH 7/7] staging: rtl8188eu: attach newly imported driver to build system Phillip Potter
2021-07-23  7:19   ` kernel test robot
2021-07-23  7:19     ` kernel test robot
2021-07-23 14:33   ` kernel test robot
2021-07-23 14:33     ` kernel test robot
2021-07-23  1:56 ` Larry Finger [this message]
2021-07-23  7:29   ` [PATCH 0/7] staging: rtl8188eu: replace driver with better version Phillip Potter
2021-07-23  7:29     ` Phillip Potter
2021-07-23 11:01 ` Greg KH
2021-07-23 11:05   ` Phillip Potter
2021-07-23 11:05     ` Phillip Potter
2021-07-23 21:08 ` Larry Finger
2021-07-23 21:27   ` Phillip Potter
2021-07-23 21:27     ` Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=630e139c-85e5-f006-6b64-e368847251fc@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.