All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Mauro S." <mau.salvi@tin.it>,
	"xenomai@xenomai.org" <xenomai@xenomai.org>
Subject: Re: [PATCH] utils/net/rtnet.in: fixes after shellcheck inspection
Date: Thu, 5 May 2022 15:03:28 +0200	[thread overview]
Message-ID: <63e4b7c7-bc03-6ca1-f4e1-ac8b77d8826b@siemens.com> (raw)
In-Reply-To: <4e8c2890-bab4-ea31-4db3-0866b389db3e@tin.it>

On 03.05.22 10:22, Mauro S. via Xenomai wrote:
> Signed-off-by: Mauro Salvini <mau.salvi@tin.it>
> ---
>  utils/net/rtnet.in | 76 +++++++++++++++++++++++-----------------------
>  1 file changed, 38 insertions(+), 38 deletions(-)
> 
> diff --git a/utils/net/rtnet.in b/utils/net/rtnet.in
> index f81a7bb0a..06e796cd2 100644
> --- a/utils/net/rtnet.in
> +++ b/utils/net/rtnet.in
> @@ -9,7 +9,7 @@ RTNETCFG="@sysconfdir@/rtnet.conf"
> 
>  debug_func() {
>      echo "$*"
> -    eval $*
> +    eval "$*"

That may not work for all inputs as it breaks up formerly quoted
arguments and separates them by $IFS. You rather want "$@" to preserve
their structure.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux


  reply	other threads:[~2022-05-05 13:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03  8:22 [PATCH] utils/net/rtnet.in: fixes after shellcheck inspection Mauro S.
2022-05-05 13:03 ` Jan Kiszka [this message]
2022-05-05 15:12   ` [PATCH v2] " Mauro S.
2022-05-05 15:25     ` Jan Kiszka
2022-05-05 15:39       ` Mauro S.
2022-05-12  7:00         ` [PATCH v3] " Mauro S.
2022-06-23  6:37           ` Mauro S.
2022-06-23  7:46             ` Jan Kiszka
2022-06-23  8:05               ` Mauro S.
2022-06-23  8:37                 ` Jan Kiszka
2022-06-23  8:48                   ` Mauro S.
2022-06-23  8:59                     ` Jan Kiszka
2022-06-23  9:16                       ` Mauro S.
2022-06-23  9:35                         ` Jan Kiszka
2022-06-23 10:16                           ` Mauro S.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63e4b7c7-bc03-6ca1-f4e1-ac8b77d8826b@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=mau.salvi@tin.it \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.