From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes Date: Mon, 7 Oct 2019 17:29:20 +0300 Message-ID: <654d00a7-d802-d116-84c4-7c614d0fe272@ti.com> References: <20191003165539.50318-1-tony@atomide.com> <03ca02c1-2816-17cd-03fd-5b72e5d0ec96@ti.com> <39E48EC6-65FE-419B-BBE8-E72CB44B517D@goldelico.com> <20191006145348.GD4740@pendragon.ideasonboard.com> <20191006223958.67725fdf@aktux> <20191007064035.72016c78@aktux> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191007064035.72016c78@aktux> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andreas Kemnade , Laurent Pinchart Cc: Tony Lindgren , Linux-OMAP , Discussions about the Letux Kernel , linux-arm-kernel , Jyri Sarha List-Id: linux-omap@vger.kernel.org On 07/10/2019 07:40, Andreas Kemnade wrote: >>> That's really weird, the driver name, the SPI device table and the OF >>> device table are the same (except for the "omapdss," prefix that we >>> don't add anymore in omapdss-boot-init.c). Would you be able to >>> investigate what broke ? >>> >> in earlier times: >> >> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias >> spi:tpo,td028ttec1 >> >> now in 5.4-rc1: >> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias >> spi:td028ttec1 >> >> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko >> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko >> license: GPL >> description: Toppoly TD028TTEC1 panel driver >> author: H. Nikolaus Schaller >> srcversion: 6B3E224BCD3D76253CF361C >> alias: of:N*T*Ctoppoly,td028ttec1C* >> alias: of:N*T*Ctoppoly,td028ttec1 >> alias: of:N*T*Ctpo,td028ttec1C* >> alias: of:N*T*Ctpo,td028ttec1 >> alias: spi:toppoly,td028ttec1 >> alias: spi:tpo,td028ttec1 >> depends: drm >> intree: Y >> name: panel_tpo_td028ttec1 >> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8 >> >> That alias is not in the list. >> > some more research: > in former times > of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1 > now it strips the tpo prefix because there is no omapdss prefix anymore. I haven't studied this more yet, but yes, I can see of_modalias_node stripping the vendor prefix on purpose. I do wonder how this is supposed to work, it would make more sense to me to keep the vendor prefix. Is the spi_device_id supposed to be without vendor prefix? With a quick grep, this seems to be the case. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2FDC47404 for ; Mon, 7 Oct 2019 14:29:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5389221655 for ; Mon, 7 Oct 2019 14:29:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kkd3QXsM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="vBWXUXEM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5389221655 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GQRQOlPKSLzSAnk67qJeqBCnet1kirp8CmX6ivOer44=; b=kkd3QXsMdeZsvzYWu85/XZJ25 Rjgy2XTsYPwCRILYRuKbn3L67pHcTLMZ1Lxc8spVxTcpihiN45z3D9WVoAlAZ8jKFDlrxEnaF0aYs I9HoNYvW04wKrULwrs/4MyB6vF06O/oLaTUsjIfAFKYm3h8+FZei3Psx5ZxL4ZVs0kdcbQh95lhyT XKQxQGPN3+1P4kl5AM94g/QcB5RH9nVEYWejvHwlJHw9fI6nSsd/K5P0ikNau3gtbHy/aZ/2htt+3 7ml4jJXASzFWn1B9T9aQR0XG+tLVcAYFODg5g74q0Wz5mLsyg1PKvfaKW7pOcHbFplixmbfdQGUc/ Z7dZNDNsg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHU1A-0004Zs-Lv; Mon, 07 Oct 2019 14:29:44 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHU17-0004ZJ-UK for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2019 14:29:43 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x97ETOAJ036075; Mon, 7 Oct 2019 09:29:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1570458564; bh=PG51P+fRN0Li8qnqF66zYDUyUyJJyL6KBk3a4211uss=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=vBWXUXEMjVMQLU4OXY6lPd0Ftvui3MRu4YzPSrpaSNlutfAxLrv9f5g1oqlY8aiYE ZXx44HY6sivNhZltYBOD7LBKlNHg+311ZRPweOt5UoGjdKUBupbpdKOIrY5zetWi2s zNd3mbToshhDlirrnJOVU8keoHrg+OyeGt41/WG0= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id x97ETOI4009904; Mon, 7 Oct 2019 09:29:24 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 7 Oct 2019 09:29:23 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 7 Oct 2019 09:29:23 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x97ETLtD017644; Mon, 7 Oct 2019 09:29:22 -0500 Subject: Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes To: Andreas Kemnade , Laurent Pinchart References: <20191003165539.50318-1-tony@atomide.com> <03ca02c1-2816-17cd-03fd-5b72e5d0ec96@ti.com> <39E48EC6-65FE-419B-BBE8-E72CB44B517D@goldelico.com> <20191006145348.GD4740@pendragon.ideasonboard.com> <20191006223958.67725fdf@aktux> <20191007064035.72016c78@aktux> From: Tomi Valkeinen Message-ID: <654d00a7-d802-d116-84c4-7c614d0fe272@ti.com> Date: Mon, 7 Oct 2019 17:29:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191007064035.72016c78@aktux> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_072942_104084_5F19448D X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , Linux-OMAP , Discussions about the Letux Kernel , linux-arm-kernel , Jyri Sarha Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/10/2019 07:40, Andreas Kemnade wrote: >>> That's really weird, the driver name, the SPI device table and the OF >>> device table are the same (except for the "omapdss," prefix that we >>> don't add anymore in omapdss-boot-init.c). Would you be able to >>> investigate what broke ? >>> >> in earlier times: >> >> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias >> spi:tpo,td028ttec1 >> >> now in 5.4-rc1: >> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias >> spi:td028ttec1 >> >> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko >> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko >> license: GPL >> description: Toppoly TD028TTEC1 panel driver >> author: H. Nikolaus Schaller >> srcversion: 6B3E224BCD3D76253CF361C >> alias: of:N*T*Ctoppoly,td028ttec1C* >> alias: of:N*T*Ctoppoly,td028ttec1 >> alias: of:N*T*Ctpo,td028ttec1C* >> alias: of:N*T*Ctpo,td028ttec1 >> alias: spi:toppoly,td028ttec1 >> alias: spi:tpo,td028ttec1 >> depends: drm >> intree: Y >> name: panel_tpo_td028ttec1 >> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8 >> >> That alias is not in the list. >> > some more research: > in former times > of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1 > now it strips the tpo prefix because there is no omapdss prefix anymore. I haven't studied this more yet, but yes, I can see of_modalias_node stripping the vendor prefix on purpose. I do wonder how this is supposed to work, it would make more sense to me to keep the vendor prefix. Is the spi_device_id supposed to be without vendor prefix? With a quick grep, this seems to be the case. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel