All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Mark Hatle <mark.hatle@windriver.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/4] gstreamer-plugins-bad: replace openssl dependency with nettle for hls plugin
Date: Wed, 9 Aug 2017 14:05:15 +0300	[thread overview]
Message-ID: <6628fe6d-b0f0-666c-5ece-d51b3697bb9a@linux.intel.com> (raw)
In-Reply-To: <46243f22-8359-490d-d7fa-aa2ce3280fa8@windriver.com>

On 08/08/2017 09:55 PM, Mark Hatle wrote:
> For now I'm fine with 1.0 support.  So something like:
> 
> # ensure OpenSSL is used for HLS AES description instead of nettle
> # (OpenSSL is a shared dependency with dtls)
> PACKAGECONFIG[hls_openssl10]             = "--enable-hls
> --with-hls-crypto=openssl,--disable-hls,openssl10"
> 
> PACKAGECONFIG[hls]             = "--enable-hls
> --with-hls-crypto=nettle,--disable-hls,nettle"

Sure, I can amend the patch.

> But my concern is changing the choice of encryption engine could break various
> existing uses.  (Like I said, -I- don't have that use, but I expect others do..
> perhaps not with gstreamer-plugins-bad though?)

You can say the same thing about almost anything that goes into master. 
In this case it doesn't matter, as there is a trivial way to revert the 
choice, but if the change was more involved, I would appreciate more 
specific evidence that this indeed causes real problems.

Alex


  parent reply	other threads:[~2017-08-09 11:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 15:30 [PATCH 0/4] Add openssl 1.1 Alexander Kanavin
2017-08-08 15:30 ` [PATCH 1/4] openssl: add a 1.1 version Alexander Kanavin
2017-08-08 15:30 ` [PATCH 2/4] openssh: depend on openssl 1.0 Alexander Kanavin
2017-08-08 15:30 ` [PATCH 3/4] cryptodev-tests: " Alexander Kanavin
2017-08-08 15:30 ` [PATCH 4/4] gstreamer-plugins-bad: replace openssl dependency with nettle for hls plugin Alexander Kanavin
2017-08-08 15:58   ` Mark Hatle
2017-08-08 17:35     ` Alexander Kanavin
2017-08-08 18:55       ` Mark Hatle
2017-08-08 22:54         ` Andre McCurdy
2017-08-09 11:05         ` Alexander Kanavin [this message]
2017-08-08 19:14       ` Burton, Ross
2017-08-08 20:41         ` Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6628fe6d-b0f0-666c-5ece-d51b3697bb9a@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.