From: Richard Weinberger <richard@nod.at>
To: chuck lever <chuck.lever@oracle.com>
Cc: Steve Dickson <steved@redhat.com>,
linux-nfs <linux-nfs@vger.kernel.org>,
david <david@sigma-star.at>, bfields <bfields@fieldses.org>,
luis turcitu <luis.turcitu@appsbroker.com>,
david young <david.young@appsbroker.com>,
david oberhollenzer <david.oberhollenzer@sigma-star.at>,
trond myklebust <trond.myklebust@hammerspace.com>,
anna schumaker <anna.schumaker@netapp.com>,
chris chilvers <chris.chilvers@appsbroker.com>
Subject: Re: [PATCH 1/5] Implement reexport helper library
Date: Tue, 10 May 2022 15:59:35 +0200 (CEST) [thread overview]
Message-ID: <688492887.48288.1652191175099.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <1A6F1763-C95B-4678-B622-6D3300AF087E@oracle.com>
----- Ursprüngliche Mail -----
> Von: "chuck lever" <chuck.lever@oracle.com>
> An: "Steve Dickson" <steved@redhat.com>
> CC: "richard" <richard@nod.at>, "linux-nfs" <linux-nfs@vger.kernel.org>, "david" <david@sigma-star.at>, "bfields"
> <bfields@fieldses.org>, "luis turcitu" <luis.turcitu@appsbroker.com>, "david young" <david.young@appsbroker.com>,
> "david oberhollenzer" <david.oberhollenzer@sigma-star.at>, "trond myklebust" <trond.myklebust@hammerspace.com>, "anna
> schumaker" <anna.schumaker@netapp.com>, "chris chilvers" <chris.chilvers@appsbroker.com>
> Gesendet: Dienstag, 10. Mai 2022 15:48:49
> Betreff: Re: [PATCH 1/5] Implement reexport helper library
>> On May 10, 2022, at 9:32 AM, Steve Dickson <steved@redhat.com> wrote:
>>
>> Hello,
>>
>> On 5/2/22 4:50 AM, Richard Weinberger wrote:
>>> This internal library contains code that will be used by various
>>> tools within the nfs-utils package to deal better with NFS re-export,
>>> especially cross mounts.
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> configure.ac | 12 ++
>>> support/Makefile.am | 4 +
>>> support/reexport/Makefile.am | 6 +
>>> support/reexport/reexport.c | 285 +++++++++++++++++++++++++++++++++++
>>> support/reexport/reexport.h | 39 +++++
>>> 5 files changed, 346 insertions(+)
>>> create mode 100644 support/reexport/Makefile.am
>>> create mode 100644 support/reexport/reexport.c
>>> create mode 100644 support/reexport/reexport.h
>>> diff --git a/configure.ac b/configure.ac
>>> index 93626d62..86bf8ba9 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -274,6 +274,17 @@ AC_ARG_ENABLE(nfsv4server,
>>> fi
>>> AM_CONDITIONAL(CONFIG_NFSV4SERVER, [test "$enable_nfsv4server" = "yes" ])
>>> +AC_ARG_ENABLE(reexport,
>>> + [AC_HELP_STRING([--enable-reexport],
>>> + [enable support for re-exporting NFS mounts @<:@default=no@:>@])],
>>> + enable_reexport=$enableval,
>>> + enable_reexport="no")
>>> + if test "$enable_reexport" = yes; then
>>> + AC_DEFINE(HAVE_REEXPORT_SUPPORT, 1,
>>> + [Define this if you want NFS re-export support
>>> compiled in])
>>> + fi
>>> + AM_CONDITIONAL(CONFIG_REEXPORT, [test "$enable_reexport" = "yes" ])
>>> +
>> To get this moving I'm going to add a --disable-reexport flag
>
> Hi Steve, no-one has given a reason why disabling support
> for re-exports would be necessary. Therefore, can't this
> switch just be removed?
Sure can we remove it. My idea was that new/experimental features should be opt-in.
Thanks,
//richard
next prev parent reply other threads:[~2022-05-10 14:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 8:50 [PATCH 0/5] nfs-utils: Improving NFS re-exports Richard Weinberger
2022-05-02 8:50 ` [PATCH 1/5] Implement reexport helper library Richard Weinberger
2022-05-10 13:32 ` Steve Dickson
2022-05-10 13:48 ` Chuck Lever III
2022-05-10 13:59 ` Richard Weinberger [this message]
2022-05-10 14:04 ` Steve Dickson
2022-05-10 14:17 ` Chuck Lever III
2022-05-10 20:08 ` Steve Dickson
2022-05-10 20:32 ` Richard Weinberger
2022-05-10 20:37 ` Chuck Lever III
2022-05-02 8:50 ` [PATCH 2/5] exports: Implement new export option reexport= Richard Weinberger
2022-05-10 14:32 ` Steve Dickson
2022-05-10 16:06 ` Richard Weinberger
2022-05-10 19:26 ` Steve Dickson
2022-05-02 8:50 ` [PATCH 3/5] export: Implement logic behind reexport= Richard Weinberger
2022-05-02 8:50 ` [PATCH 4/5] export: Avoid fsid= conflicts Richard Weinberger
2022-05-02 8:50 ` [PATCH 5/5] reexport: Make state database location configurable Richard Weinberger
2022-05-02 16:17 ` [PATCH 0/5] nfs-utils: Improving NFS re-exports J. Bruce Fields
2022-05-02 22:46 ` Steve Dickson
2022-05-03 0:00 ` Chuck Lever III
2022-05-23 7:53 ` Richard Weinberger
2022-05-23 14:25 ` Chuck Lever III
2022-05-23 14:29 ` bfields
2022-05-23 14:31 ` bfields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=688492887.48288.1652191175099.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=chris.chilvers@appsbroker.com \
--cc=chuck.lever@oracle.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=david.young@appsbroker.com \
--cc=david@sigma-star.at \
--cc=linux-nfs@vger.kernel.org \
--cc=luis.turcitu@appsbroker.com \
--cc=steved@redhat.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.