From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc: <linux-arm-msm@vger.kernel.org>, <hemantk@codeaurora.org>,
<linux-kernel@vger.kernel.org>, <carl.yin@quectel.com>,
<loic.poulain@linaro.org>, <kvalo@codeaurora.org>
Subject: Re: [RESEND PATCH] bus: mhi: core: Remove pre_init flag used for power purposes
Date: Tue, 4 May 2021 11:33:59 -0600 [thread overview]
Message-ID: <68e9bf2a-9de1-a731-25d8-537d4f3423d8@quicinc.com> (raw)
In-Reply-To: <20210407050730.GC8675@work>
On 4/6/2021 11:07 PM, Manivannan Sadhasivam wrote:
> On Thu, Apr 01, 2021 at 02:41:49PM -0700, Bhaumik Bhatt wrote:
>> Some controllers can choose to skip preparation for power up.
>> In that case, device context is initialized based on the pre_init
>> flag not being set during mhi_prepare_for_power_up(). There is no
>> reason MHI host driver should maintain and provide controllers
>> with two separate paths for preparing MHI.
>>
>> Going forward, all controllers will be required to call the
>> mhi_prepare_for_power_up() API followed by their choice of sync
>> or async power up. This allows MHI host driver to get rid of the
>> pre_init flag and sets up a common way for all controllers to use
>> MHI. This also helps controllers fail early on during preparation
>> phase in some failure cases.
>>
>> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
>
> I hope Jeff is also okay with this patch for AIC100.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
Sorry for the non-response. This has minimal impact. No concerns from me.
next prev parent reply other threads:[~2021-05-04 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 21:41 [RESEND PATCH] bus: mhi: core: Remove pre_init flag used for power purposes Bhaumik Bhatt
2021-04-02 18:20 ` Hemant Kumar
2021-04-07 5:07 ` Manivannan Sadhasivam
2021-05-04 17:33 ` Jeffrey Hugo [this message]
2021-04-07 6:50 ` Manivannan Sadhasivam
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68e9bf2a-9de1-a731-25d8-537d4f3423d8@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=bbhatt@codeaurora.org \
--cc=carl.yin@quectel.com \
--cc=hemantk@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.