On 13.07.21 16:19, Julien Grall wrote: > Hi Jan, > > On 13/07/2021 15:14, Jan Beulich wrote: >>> And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. >> >> Even that doesn't seem right to me, at least in principle. There >> shouldn't >> be a build time setting when it may vary at runtime. IOW on Arm I think a >> runtime query to the hypervisor would be needed instead. > > Yes, we want to be able to use the same userspace/OS without rebuilding > to a specific hypervisor page size. This define is used for accessing data of other domains. See the define for XEN_PAGE_SIZE in xen/include/public/io/ring.h So it should be a constant (minimal) page size for all hypervisors and guests of an architecture. Juergen