All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Cc: fabrizio.castro@bp.renesas.com,
	boris.brezillon@free-electrons.com, Songjun.Wu@atmel.com,
	peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	laurent.pinchart@ideasonboard.com, voice.shen@atmel.com
Subject: Re: [PATCH 1/4] drm/bridge: sii902x: add input_bus_flags
Date: Mon, 25 Feb 2019 13:48:14 +0100	[thread overview]
Message-ID: <6e921dbf-5e2d-5d56-1458-44bf300b10e9@samsung.com> (raw)
In-Reply-To: <55145f406e698651b99bc7a35421cd38548c1d79.1551090126.git.jsarha@ti.com>

On 25.02.2019 12:23, Jyri Sarha wrote:
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> The driver always sets InputBusFmt:EDGE to 0 (falling edge).
>
> Add drm_bridge_timings's input_bus_flags to reflect that the bridge
> samples on falling edges.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

 --
Regards
Andrzej
> ---
>  drivers/gpu/drm/bridge/sii902x.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
> index bfa902013aa4..1afa000141d5 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -459,6 +459,12 @@ static int sii902x_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id)
>  	return 0;
>  }
>  
> +static const struct drm_bridge_timings default_sii902x_timings = {
> +	.input_bus_flags = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE
> +		 | DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE
> +		 | DRM_BUS_FLAG_DE_HIGH,
> +};
> +
>  static int sii902x_probe(struct i2c_client *client,
>  			 const struct i2c_device_id *id)
>  {
> @@ -529,6 +535,7 @@ static int sii902x_probe(struct i2c_client *client,
>  
>  	sii902x->bridge.funcs = &sii902x_bridge_funcs;
>  	sii902x->bridge.of_node = dev->of_node;
> +	sii902x->bridge.timings = &default_sii902x_timings;
>  	drm_bridge_add(&sii902x->bridge);
>  
>  	i2c_set_clientdata(client, sii902x);


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-02-25 12:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 11:23 [PATCH 0/4] drm/bridge: sii902x: HDMI-audio support and some fixes Jyri Sarha
2019-02-25 11:23 ` [PATCH 1/4] drm/bridge: sii902x: add input_bus_flags Jyri Sarha
2019-02-25 12:48   ` Andrzej Hajda [this message]
2019-02-25 18:15   ` kbuild test robot
2019-02-25 18:22   ` kbuild test robot
2019-02-25 11:23 ` [PATCH 2/4] drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID Jyri Sarha
2019-02-25 12:48   ` Andrzej Hajda
2019-02-25 11:23 ` [PATCH 3/4] drm/bridge: sii902x: Implement HDMI audio support Jyri Sarha
2019-02-25 13:57   ` Andrzej Hajda
2019-02-25 14:40     ` Jyri Sarha
2019-02-25 21:44   ` kbuild test robot
2019-02-25 21:44   ` [PATCH] drm/bridge: sii902x: fix semicolon.cocci warnings kbuild test robot
2019-02-25 11:23 ` [PATCH 4/4] drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz Jyri Sarha
2019-02-25 13:01   ` Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e921dbf-5e2d-5d56-1458-44bf300b10e9@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=Songjun.Wu@atmel.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=voice.shen@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.