From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC51C433E0 for ; Thu, 21 Jan 2021 21:38:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 767EB23A5D for ; Thu, 21 Jan 2021 21:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727729AbhAUVhu (ORCPT ); Thu, 21 Jan 2021 16:37:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726862AbhAUVgu (ORCPT ); Thu, 21 Jan 2021 16:36:50 -0500 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5706C06174A; Thu, 21 Jan 2021 13:36:09 -0800 (PST) Received: by mail-lj1-x22e.google.com with SMTP id p13so4237643ljg.2; Thu, 21 Jan 2021 13:36:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YVqgssMQdQhf9y4JoWK0z3t3swC1/ivpAtAAVdvhll4=; b=s/o8iP3f3g2RyAf0tsVr2o+psJr/byantEoQeD3hFGfAIysCZTR59lyN5PZ3XKN1qW /xvkhqeg2suJDIb+8ByOo5mgTbwsHJH5qM1SAQCd2h+0QO8zG/L6pjwWlbcC6COTaOyl +KGRl3IcRVFS5tXYbGgL0MShb+stQyDjOK2zhlF5rxntfW5yFJVU1SVWo6IWbIxuhhrR 5k5QLe5ddFfQYycgWlOjNSP+BMjPQjmyhC5pMqVKxujTrP+F4NMckZfULHmo8HA8Szga Fl7DbYX+KTT+VSgn2b3v+T9CRDx9K7lk4APaIfekExKBDRBcP8vlYQyWUbFCm9yIkcCG EUdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YVqgssMQdQhf9y4JoWK0z3t3swC1/ivpAtAAVdvhll4=; b=HK68l1QWyfb4eUQ03GfUvyeXyLq2+wj2ttouSAv90VaZtZTHezM8zk3of0S38OABtW eR2rXZiRfTPHXIgesLH17jYIFo38J9qDCINmcNfw+11zD2PGqbksgy4Gzu+EZPwJJoIR 3YTwS2tFm8lhs6M9LupYsGUpV9Y5NixrfQ0eKGeKuE5GISLgxJUPalpi8KbXD5+5c9gD 15ifsVD0+zlODTJk5vG/CUmCUm6IldQJwUZnayW/enaKZ+gMpjiKW8Ba2dvfPwaPgvbG yv9qDFkpp2oKdrdvf/xAIHs9v1EZmx5kTVQVIicdcT5ypdNCbxKCxCfgaZnojO3vZVGB vAmg== X-Gm-Message-State: AOAM531E4R1c+kql3ocWVKU4qvawpVVVuw5gM+5+Rc8JbCLflSkOgvc8 QvDnRLe8AVc/uiMWXiSaGVN02Vnsil8= X-Google-Smtp-Source: ABdhPJwIPaV85WcNNtbxmI3PgM7773oygI3tszwUBIQeJepq5sb+YObOjRnU/5o3/Z0ZlU4qsIoo8Q== X-Received: by 2002:a05:651c:2049:: with SMTP id t9mr693818ljo.58.1611264968032; Thu, 21 Jan 2021 13:36:08 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id p3sm652233lfu.271.2021.01.21.13.36.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 13:36:07 -0800 (PST) Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() To: Viresh Kumar , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding , Jonathan Hunter Cc: linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> From: Dmitry Osipenko Message-ID: <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> Date: Fri, 22 Jan 2021 00:36:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 21.01.2021 14:17, Viresh Kumar пишет: > dev_pm_opp_set_bw() is getting removed and dev_pm_opp_set_opp() should > be used instead. Migrate to the new API. > > Signed-off-by: Viresh Kumar > --- > drivers/devfreq/tegra30-devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 117cad7968ab..d2477d7d1f66 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -647,7 +647,7 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq, > return PTR_ERR(opp); > } > > - ret = dev_pm_opp_set_bw(dev, opp); > + ret = dev_pm_opp_set_opp(dev, opp); > dev_pm_opp_put(opp); > > return ret; > This patch introduces a very serious change that needs to be fixed. Now dev_pm_opp_set_opp() changes both clock rate and bandwidth, this is unacceptable for this driver because it shall not touch the clock rate. I think dev_pm_opp_set_bw() can't be removed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC42C433E0 for ; Thu, 21 Jan 2021 21:37:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 865FB206BE for ; Thu, 21 Jan 2021 21:37:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 865FB206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ySfmzZ/krtP+RJufvw77WLeZ7TwQT7Ccjn0f8yX0hJ8=; b=XJng9iFV6aqavdLS/YSxMZHnW V55sWA+kD/r+g/XHDlYdEYU7RhU26KnD9KJWKMJYQJSA0WE7SSgDycxOR9pY7XmcFPySOnAKhExJb 0PaJ9ukMIUzkwEV+TxW+hNf1KJLl5r3U3llonbuCYDitBMLNneLMz2xNNDCGeEUKDrFWUy60JXwJp 3WYej8SIgb7OjSW/W4Q9snbgIfzfzzASpVdfaXsgJwAdUQaD2iYhfjUiAO7QkCBWIbthwmOHXyv9+ OMvoKVfjZyQef7WACkb2oh0c9cNxTwgIDVo9GI2FNQ9SRttNydSXmu8y0PwzS7VBjccPtb5paCRjU Vm5MUsn4Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2hci-0003vD-75; Thu, 21 Jan 2021 21:36:12 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2hcg-0003ur-0V for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 21:36:10 +0000 Received: by mail-lj1-x235.google.com with SMTP id l12so1676158ljc.3 for ; Thu, 21 Jan 2021 13:36:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YVqgssMQdQhf9y4JoWK0z3t3swC1/ivpAtAAVdvhll4=; b=s/o8iP3f3g2RyAf0tsVr2o+psJr/byantEoQeD3hFGfAIysCZTR59lyN5PZ3XKN1qW /xvkhqeg2suJDIb+8ByOo5mgTbwsHJH5qM1SAQCd2h+0QO8zG/L6pjwWlbcC6COTaOyl +KGRl3IcRVFS5tXYbGgL0MShb+stQyDjOK2zhlF5rxntfW5yFJVU1SVWo6IWbIxuhhrR 5k5QLe5ddFfQYycgWlOjNSP+BMjPQjmyhC5pMqVKxujTrP+F4NMckZfULHmo8HA8Szga Fl7DbYX+KTT+VSgn2b3v+T9CRDx9K7lk4APaIfekExKBDRBcP8vlYQyWUbFCm9yIkcCG EUdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YVqgssMQdQhf9y4JoWK0z3t3swC1/ivpAtAAVdvhll4=; b=jLE017dwF5MiDxhUvtxfOiKtVwTIjoRdVMxfx+RY5O8jiYLaXu1erxapreJmJhCvTb jrW76OavFIgPIszv5VwHERkKBjDIBO9m7nrwG8WeXfw15SWZNyPca4UM5tUGfuYz6o6K TdH/ZFOG0n5K1YwavritPUGwUtxh+hLDP4SRx0dBUNObT66I+EZ4RQS+xwnwsbfCSH+v ASR1H2vGQAYAoN+bZU3B2F66uhYFi0g5LbtwHG4ctCXPL6gBHK4BENTHtE1YIrlmXXM2 0AJ7oFeOr0qMwFYuHDypIvU3/wYz9eOWes8v4S3MmOR+QDPU5ZgdQ2SUnLdzvL5Tg7zj 8wrQ== X-Gm-Message-State: AOAM531Skboro7rBnXfEW0W0IPbtaXAnZSIkbaM9k+Xl1PfUzgXlNxp6 rW1HsrtUnBaTMZuPuD7gX1U= X-Google-Smtp-Source: ABdhPJwIPaV85WcNNtbxmI3PgM7773oygI3tszwUBIQeJepq5sb+YObOjRnU/5o3/Z0ZlU4qsIoo8Q== X-Received: by 2002:a05:651c:2049:: with SMTP id t9mr693818ljo.58.1611264968032; Thu, 21 Jan 2021 13:36:08 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id p3sm652233lfu.271.2021.01.21.13.36.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 13:36:07 -0800 (PST) Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() To: Viresh Kumar , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding , Jonathan Hunter References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> From: Dmitry Osipenko Message-ID: <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> Date: Fri, 22 Jan 2021 00:36:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_163610_072795_233461CC X-CRM114-Status: GOOD ( 20.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vincent Guittot , linux-pm@vger.kernel.org, Stephen Boyd , Rafael Wysocki , linux-kernel@vger.kernel.org, Sibi Sankar , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjEuMDEuMjAyMSAxNDoxNywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gZGV2X3BtX29wcF9z ZXRfYncoKSBpcyBnZXR0aW5nIHJlbW92ZWQgYW5kIGRldl9wbV9vcHBfc2V0X29wcCgpIHNob3Vs ZAo+IGJlIHVzZWQgaW5zdGVhZC4gTWlncmF0ZSB0byB0aGUgbmV3IEFQSS4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBWaXJlc2ggS3VtYXIgPHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPgo+IC0tLQo+ICBk cml2ZXJzL2RldmZyZXEvdGVncmEzMC1kZXZmcmVxLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2RldmZyZXEvdGVncmEzMC1kZXZmcmVxLmMgYi9kcml2ZXJzL2RldmZyZXEvdGVncmEzMC1kZXZm cmVxLmMKPiBpbmRleCAxMTdjYWQ3OTY4YWIuLmQyNDc3ZDdkMWY2NiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2RldmZyZXEvdGVncmEzMC1kZXZmcmVxLmMKPiArKysgYi9kcml2ZXJzL2RldmZyZXEv dGVncmEzMC1kZXZmcmVxLmMKPiBAQCAtNjQ3LDcgKzY0Nyw3IEBAIHN0YXRpYyBpbnQgdGVncmFf ZGV2ZnJlcV90YXJnZXQoc3RydWN0IGRldmljZSAqZGV2LCB1bnNpZ25lZCBsb25nICpmcmVxLAo+ ICAJCXJldHVybiBQVFJfRVJSKG9wcCk7Cj4gIAl9Cj4gIAo+IC0JcmV0ID0gZGV2X3BtX29wcF9z ZXRfYncoZGV2LCBvcHApOwo+ICsJcmV0ID0gZGV2X3BtX29wcF9zZXRfb3BwKGRldiwgb3BwKTsK PiAgCWRldl9wbV9vcHBfcHV0KG9wcCk7Cj4gIAo+ICAJcmV0dXJuIHJldDsKPiAKClRoaXMgcGF0 Y2ggaW50cm9kdWNlcyBhIHZlcnkgc2VyaW91cyBjaGFuZ2UgdGhhdCBuZWVkcyB0byBiZSBmaXhl ZC4KCk5vdyBkZXZfcG1fb3BwX3NldF9vcHAoKSBjaGFuZ2VzIGJvdGggY2xvY2sgcmF0ZSBhbmQg YmFuZHdpZHRoLCB0aGlzIGlzCnVuYWNjZXB0YWJsZSBmb3IgdGhpcyBkcml2ZXIgYmVjYXVzZSBp dCBzaGFsbCBub3QgdG91Y2ggdGhlIGNsb2NrIHJhdGUuCgpJIHRoaW5rIGRldl9wbV9vcHBfc2V0 X2J3KCkgY2FuJ3QgYmUgcmVtb3ZlZC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK