From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77445C433E2 for ; Sat, 18 Jul 2020 14:15:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DF4320724 for ; Sat, 18 Jul 2020 14:15:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727091AbgGROPb (ORCPT ); Sat, 18 Jul 2020 10:15:31 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:50442 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbgGROPb (ORCPT ); Sat, 18 Jul 2020 10:15:31 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07484;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0U33fh2O_1595081725; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U33fh2O_1595081725) by smtp.aliyun-inc.com(127.0.0.1); Sat, 18 Jul 2020 22:15:25 +0800 Subject: Re: [PATCH v16 20/22] mm/vmscan: use relock for move_pages_to_lru To: Alexander Duyck Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups@vger.kernel.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , Andrey Ryabinin , Jann Horn References: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> <1594429136-20002-21-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: <7176001a-fa58-3281-7c6b-b25eea54bd15@linux.alibaba.com> Date: Sat, 18 Jul 2020 22:15:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/7/18 上午5:44, Alexander Duyck 写道: >> if (unlikely(PageCompound(page))) { >> spin_unlock_irq(&lruvec->lru_lock); >> + lruvec = NULL; >> destroy_compound_page(page); >> - spin_lock_irq(&lruvec->lru_lock); >> } else >> list_add(&page->lru, &pages_to_free); >> > It seems like this should just be rolled into patch 19. Otherwise if > you are wanting to consider it as a "further optimization" type patch > you might pull some of the optimizations you were pushing in patch 18 > into this patch as well and just call it out as adding relocks where > there previously were none. This patch is picked from Hugh Dickin's version in my review. It could be fine to have a extra patch which no harm for anyone. :) Thanks Alex