All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Eric Dumazet <eric.dumazet@gmail.com>
Cc: Young Xiao <92siuyang@gmail.com>,
	davem@davemloft.net, kuznet@ms2.inr.ac.ru,
	yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options
Date: Fri, 31 May 2019 07:50:06 -0700	[thread overview]
Message-ID: <727c4b18-0d7b-b3c6-e0bb-41b3fe5902d3@gmail.com> (raw)
In-Reply-To: <20190531062911.c6jusfbzgozqk2cu@gondor.apana.org.au>



On 5/30/19 11:29 PM, Herbert Xu wrote:
> On Thu, May 30, 2019 at 10:17:04AM -0700, Eric Dumazet wrote:
>>
>> xfrm6_transport_output() seems buggy as well,
>> unless the skbs are linearized before entering these functions ?
> 
> The headers that it's moving should be linearised.  Is there
> something else I'm missing?
> 

What do you mean by should ?

Are they currently already linearized before the function is called,
or is it missing and a bug needs to be fixed ?



  reply	other threads:[~2019-05-31 14:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30 15:28 [PATCH] ipv6: Prevent overrun when parsing v6 header options Young Xiao
2019-05-30 17:17 ` Eric Dumazet
2019-05-31  3:04   ` Yang Xiao
2019-05-31 17:35     ` Eric Dumazet
2019-06-04  6:59       ` Yang Xiao
2019-06-04 13:29         ` Eric Dumazet
2019-05-31  6:29   ` Herbert Xu
2019-05-31 14:50     ` Eric Dumazet [this message]
2019-05-31 14:54       ` Herbert Xu
2019-05-31 15:57         ` Eric Dumazet
2019-05-31 16:12           ` Yang Xiao
  -- strict thread matches above, loose matches on Subject: below --
2020-12-27 14:11 Defang Bo
2020-12-28 23:03 ` David Miller
2019-04-12  3:34 Young Xiao
2019-04-17  3:45 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=727c4b18-0d7b-b3c6-e0bb-41b3fe5902d3@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=92siuyang@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.