From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB175C433FE for ; Fri, 11 Dec 2020 03:31:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73EEF23BF0 for ; Fri, 11 Dec 2020 03:31:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405224AbgLKDaQ (ORCPT ); Thu, 10 Dec 2020 22:30:16 -0500 Received: from linux.microsoft.com ([13.77.154.182]:40524 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395109AbgLKD3k (ORCPT ); Thu, 10 Dec 2020 22:29:40 -0500 Received: from [192.168.86.31] (c-71-197-163-6.hsd1.wa.comcast.net [71.197.163.6]) by linux.microsoft.com (Postfix) with ESMTPSA id 1A7BF20B717A; Thu, 10 Dec 2020 19:28:59 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1A7BF20B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1607657339; bh=rcijWVVTMTzX5ZOWnSTyFBk2pvV6w0RdbNA7Gje7iD4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TBF+wcoIRE6sji0On6Qc1ljAt2RENrh6+/tBpIIOKUNLezGTP/fFVBE7O/nIVjs4b wbRoHeZbMuuwiRsQGmskUBvQS7MgN+f7pn9ysGEfHLolD01YG9kxEofHnE9IONRVq8 a2K5As5n+9Cyv1c3U1xLNVqaGYvEgof4qdJYhquw= Subject: Re: [PATCH v7 5/8] IMA: limit critical data measurement based on a label To: Tyler Hicks Cc: zohar@linux.ibm.com, stephen.smalley.work@gmail.com, casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, paul@paul-moore.com, sashal@kernel.org, jmorris@namei.org, nramas@linux.microsoft.com, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com References: <20201209194212.5131-1-tusharsu@linux.microsoft.com> <20201209194212.5131-6-tusharsu@linux.microsoft.com> <20201210231505.GJ489768@sequoia> From: Tushar Sugandhi Message-ID: <730f52ec-4b78-9aac-6c2e-c1ca63c929f1@linux.microsoft.com> Date: Thu, 10 Dec 2020 19:28:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201210231505.GJ489768@sequoia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-12-10 3:15 p.m., Tyler Hicks wrote: > On 2020-12-09 11:42:09, Tushar Sugandhi wrote: >> System administrators should be able to limit which kernel subsystems >> they want to measure the critical data for. To enable that, an IMA policy >> condition to choose specific kernel subsystems is needed. This policy >> condition would constrain the measurement of the critical data based on >> a label for the given subsystems. >> >> Add a new IMA policy condition - "data_source:=" to the IMA func >> CRITICAL_DATA to allow measurement of various kernel subsystems. This >> policy condition would enable the system administrators to restrict the >> measurement to the labels listed in "data_source:=". >> >> Limit the measurement to the labels that are specified in the IMA >> policy - CRITICAL_DATA+"data_source:=". If "data_sources:=" is not >> provided with the func CRITICAL_DATA, the data from all the >> supported kernel subsystems is measured. >> >> Signed-off-by: Tushar Sugandhi > > This patch will look good once all the IMA_DATA_SOURCE stuff is moved > over from patch #4. > > Tyler > Sounds good. Will do. ~Tushar >> --- >> Documentation/ABI/testing/ima_policy | 2 ++ >> security/integrity/ima/ima_policy.c | 26 +++++++++++++++++++++++++- >> 2 files changed, 27 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/ABI/testing/ima_policy b/Documentation/ABI/testing/ima_policy >> index 6ec7daa87cba..0f4ee9e0a455 100644 >> --- a/Documentation/ABI/testing/ima_policy >> +++ b/Documentation/ABI/testing/ima_policy >> @@ -52,6 +52,8 @@ Description: >> template:= name of a defined IMA template type >> (eg, ima-ng). Only valid when action is "measure". >> pcr:= decimal value >> + data_source:= [label] >> + label:= a unique string used for grouping and limiting critical data. >> >> default policy: >> # PROC_SUPER_MAGIC >> diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c >> index 9a8ee80a3128..7486d09a3f60 100644 >> --- a/security/integrity/ima/ima_policy.c >> +++ b/security/integrity/ima/ima_policy.c >> @@ -934,7 +934,7 @@ enum { >> Opt_uid_lt, Opt_euid_lt, Opt_fowner_lt, >> Opt_appraise_type, Opt_appraise_flag, >> Opt_permit_directio, Opt_pcr, Opt_template, Opt_keyrings, >> - Opt_err >> + Opt_data_source, Opt_err >> }; >> >> static const match_table_t policy_tokens = { >> @@ -971,6 +971,7 @@ static const match_table_t policy_tokens = { >> {Opt_pcr, "pcr=%s"}, >> {Opt_template, "template=%s"}, >> {Opt_keyrings, "keyrings=%s"}, >> + {Opt_data_source, "data_source=%s"}, >> {Opt_err, NULL} >> }; >> >> @@ -1350,6 +1351,23 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry) >> >> entry->flags |= IMA_KEYRINGS; >> break; >> + case Opt_data_source: >> + ima_log_string(ab, "data_source", args[0].from); >> + >> + if (entry->data_source) { >> + result = -EINVAL; >> + break; >> + } >> + >> + entry->data_source = ima_alloc_rule_opt_list(args); >> + if (IS_ERR(entry->data_source)) { >> + result = PTR_ERR(entry->data_source); >> + entry->data_source = NULL; >> + break; >> + } >> + >> + entry->flags |= IMA_DATA_SOURCE; >> + break; >> case Opt_fsuuid: >> ima_log_string(ab, "fsuuid", args[0].from); >> >> @@ -1730,6 +1748,12 @@ int ima_policy_show(struct seq_file *m, void *v) >> seq_puts(m, " "); >> } >> >> + if (entry->flags & IMA_DATA_SOURCE) { >> + seq_puts(m, "data_source="); >> + ima_show_rule_opt_list(m, entry->data_source); >> + seq_puts(m, " "); >> + } >> + >> if (entry->flags & IMA_PCR) { >> snprintf(tbuf, sizeof(tbuf), "%d", entry->pcr); >> seq_printf(m, pt(Opt_pcr), tbuf); >> -- >> 2.17.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF76EC4361B for ; Fri, 11 Dec 2020 03:29:16 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2560522DBF for ; Fri, 11 Dec 2020 03:29:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2560522DBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-1DtDXC5mP6OO66Ycf5f_gg-1; Thu, 10 Dec 2020 22:29:13 -0500 X-MC-Unique: 1DtDXC5mP6OO66Ycf5f_gg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 976281054F8D; Fri, 11 Dec 2020 03:29:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 768F110016F5; Fri, 11 Dec 2020 03:29:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4F3404E58F; Fri, 11 Dec 2020 03:29:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0BB3T617025465 for ; Thu, 10 Dec 2020 22:29:06 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1EC642011541; Fri, 11 Dec 2020 03:29:06 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A7662011540 for ; Fri, 11 Dec 2020 03:29:02 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A1E8780018D for ; Fri, 11 Dec 2020 03:29:02 +0000 (UTC) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by relay.mimecast.com with ESMTP id us-mta-298-YTzNx9JBN0WgUZzp-uSlLw-1; Thu, 10 Dec 2020 22:29:00 -0500 X-MC-Unique: YTzNx9JBN0WgUZzp-uSlLw-1 Received: from [192.168.86.31] (c-71-197-163-6.hsd1.wa.comcast.net [71.197.163.6]) by linux.microsoft.com (Postfix) with ESMTPSA id 1A7BF20B717A; Thu, 10 Dec 2020 19:28:59 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1A7BF20B717A To: Tyler Hicks References: <20201209194212.5131-1-tusharsu@linux.microsoft.com> <20201209194212.5131-6-tusharsu@linux.microsoft.com> <20201210231505.GJ489768@sequoia> From: Tushar Sugandhi Message-ID: <730f52ec-4b78-9aac-6c2e-c1ca63c929f1@linux.microsoft.com> Date: Thu, 10 Dec 2020 19:28:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201210231505.GJ489768@sequoia> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com Cc: sashal@kernel.org, paul@paul-moore.com, snitzer@redhat.com, selinux@vger.kernel.org, stephen.smalley.work@gmail.com, jmorris@namei.org, zohar@linux.ibm.com, linux-kernel@vger.kernel.org, nramas@linux.microsoft.com, linux-security-module@vger.kernel.org, casey@schaufler-ca.com, linux-integrity@vger.kernel.org, dm-devel@redhat.com, gmazyland@gmail.com, agk@redhat.com Subject: Re: [dm-devel] [PATCH v7 5/8] IMA: limit critical data measurement based on a label X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" On 2020-12-10 3:15 p.m., Tyler Hicks wrote: > On 2020-12-09 11:42:09, Tushar Sugandhi wrote: >> System administrators should be able to limit which kernel subsystems >> they want to measure the critical data for. To enable that, an IMA policy >> condition to choose specific kernel subsystems is needed. This policy >> condition would constrain the measurement of the critical data based on >> a label for the given subsystems. >> >> Add a new IMA policy condition - "data_source:=" to the IMA func >> CRITICAL_DATA to allow measurement of various kernel subsystems. This >> policy condition would enable the system administrators to restrict the >> measurement to the labels listed in "data_source:=". >> >> Limit the measurement to the labels that are specified in the IMA >> policy - CRITICAL_DATA+"data_source:=". If "data_sources:=" is not >> provided with the func CRITICAL_DATA, the data from all the >> supported kernel subsystems is measured. >> >> Signed-off-by: Tushar Sugandhi > > This patch will look good once all the IMA_DATA_SOURCE stuff is moved > over from patch #4. > > Tyler > Sounds good. Will do. ~Tushar >> --- >> Documentation/ABI/testing/ima_policy | 2 ++ >> security/integrity/ima/ima_policy.c | 26 +++++++++++++++++++++++++- >> 2 files changed, 27 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/ABI/testing/ima_policy b/Documentation/ABI/testing/ima_policy >> index 6ec7daa87cba..0f4ee9e0a455 100644 >> --- a/Documentation/ABI/testing/ima_policy >> +++ b/Documentation/ABI/testing/ima_policy >> @@ -52,6 +52,8 @@ Description: >> template:= name of a defined IMA template type >> (eg, ima-ng). Only valid when action is "measure". >> pcr:= decimal value >> + data_source:= [label] >> + label:= a unique string used for grouping and limiting critical data. >> >> default policy: >> # PROC_SUPER_MAGIC >> diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c >> index 9a8ee80a3128..7486d09a3f60 100644 >> --- a/security/integrity/ima/ima_policy.c >> +++ b/security/integrity/ima/ima_policy.c >> @@ -934,7 +934,7 @@ enum { >> Opt_uid_lt, Opt_euid_lt, Opt_fowner_lt, >> Opt_appraise_type, Opt_appraise_flag, >> Opt_permit_directio, Opt_pcr, Opt_template, Opt_keyrings, >> - Opt_err >> + Opt_data_source, Opt_err >> }; >> >> static const match_table_t policy_tokens = { >> @@ -971,6 +971,7 @@ static const match_table_t policy_tokens = { >> {Opt_pcr, "pcr=%s"}, >> {Opt_template, "template=%s"}, >> {Opt_keyrings, "keyrings=%s"}, >> + {Opt_data_source, "data_source=%s"}, >> {Opt_err, NULL} >> }; >> >> @@ -1350,6 +1351,23 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry) >> >> entry->flags |= IMA_KEYRINGS; >> break; >> + case Opt_data_source: >> + ima_log_string(ab, "data_source", args[0].from); >> + >> + if (entry->data_source) { >> + result = -EINVAL; >> + break; >> + } >> + >> + entry->data_source = ima_alloc_rule_opt_list(args); >> + if (IS_ERR(entry->data_source)) { >> + result = PTR_ERR(entry->data_source); >> + entry->data_source = NULL; >> + break; >> + } >> + >> + entry->flags |= IMA_DATA_SOURCE; >> + break; >> case Opt_fsuuid: >> ima_log_string(ab, "fsuuid", args[0].from); >> >> @@ -1730,6 +1748,12 @@ int ima_policy_show(struct seq_file *m, void *v) >> seq_puts(m, " "); >> } >> >> + if (entry->flags & IMA_DATA_SOURCE) { >> + seq_puts(m, "data_source="); >> + ima_show_rule_opt_list(m, entry->data_source); >> + seq_puts(m, " "); >> + } >> + >> if (entry->flags & IMA_PCR) { >> snprintf(tbuf, sizeof(tbuf), "%d", entry->pcr); >> seq_printf(m, pt(Opt_pcr), tbuf); >> -- >> 2.17.1 >> -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel