Re: [PATCH] ubifs: Correctly initialize c->min_log_bytes

[Richard Weinberger <richard@nod.at>]

----- Ursprüngliche Mail -----
> Von: "richard" <richard@nod.at>
> An: "linux-mtd" <linux-mtd@lists.infradead.org>
> CC: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "richard" <richard@nod.at>
> Gesendet: Donnerstag, 25. Juli 2019 22:56:27
> Betreff: [PATCH] ubifs: Correctly initialize c->min_log_bytes

> Currently on a freshly mounted UBIFS, c->min_log_bytes is 0.
> This can lead to a log overrun and make commits fail.
> 
> Recent kernels will report the following assert:
> UBIFS assert failed: c->lhead_lnum != c->ltail_lnum, in fs/ubifs/log.c:412
> 
> c->min_log_bytes can have two states, 0 and c->leb_size.
> It controls how much bytes of the log area are reserved for non-bud
> nodes such as commit nodes.
> 
> After a commit it has to be set to c->leb_size such that we have always
> enought space for a commit. While a commit runs it can be 0 to make the
> remaining bytes of the log available to writers.
> 
> Having it set to 0 right after mount is wrong since no space for commits
> is reserved.
> 
> Reported-and-tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Richard Weinberger <richard@nod.at>

Fixes: 1e51764a3c2ac ("UBIFS: add new flash file system")

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/