Re: [PATCH] ALSA: HDA: Add jack detection for HDMI

[Stephen Warren <swarren@nvidia.com>]

Takashi Iwai wrote at Tuesday, May 24, 2011 12:10 PM:
> > Takashi Iwai wrote at Monday, May 23, 2011 11:40 PM:
> > > ---
> > > diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
> > > index 74b0560..cd96b1d 100644
> > > --- a/sound/pci/hda/hda_eld.c
> > > +++ b/sound/pci/hda/hda_eld.c
> > > @@ -477,6 +477,8 @@ static void hdmi_print_eld_info(struct snd_info_entry
> > > *entry,
> > >
> > >  	snd_iprintf(buffer, "monitor_present\t\t%d\n", e->monitor_present);
> > >  	snd_iprintf(buffer, "eld_valid\t\t%d\n", e->eld_valid);
> > > +	if (!e->eld_valid)
> > > +		return;
> > >  	snd_iprintf(buffer, "monitor_name\t\t%s\n", e->monitor_name);
> > >  	snd_iprintf(buffer, "connection_type\t\t%s\n",
> > >  				eld_connection_type_names[e->conn_type]);

> ---
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 3229018..4dbe8d6 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -707,6 +707,7 @@ static void hdmi_intrinsic_event(struct hda_codec
> *codec, unsigned int res)
>  	if (index < 0)
>  		return;
> 
> +	memset(&spec->sink_eld[index], 0, sizeof(spec->sink_eld[index]));
>  	if (spec->old_pin_detect) {
>  		if (pind)
>  			hdmi_present_sense(codec, tag, &spec->sink_eld[index]);

Both:
Tested-by: Stephen Warren <swarren@nvidia.com>

Thanks.

-- 
nvpublic