From: Shuah Khan <skhan@linuxfoundation.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>,
shuah@kernel.org, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 2/4] selftest/vm: verify remap destination address in mremap_test
Date: Thu, 21 Apr 2022 13:31:56 -0600 [thread overview]
Message-ID: <76cd8347-a8d0-3b56-a202-17ba2a73503d@linuxfoundation.org> (raw)
In-Reply-To: <20220420215721.4868-2-sidhartha.kumar@oracle.com>
On 4/20/22 3:57 PM, Sidhartha Kumar wrote:
> Because mremap does not have a MAP_FIXED_NOREPLACE flag, it can destroy
> existing mappings. This causes a segfault when regions such as text are
> remapped and the permissions are changed.
>
> Verify the requested mremap destination address does not overlap any
> existing mappings by using mmap's MAP_FIXED_NOREPLACE flag. Keep
> incrementing the destination address until a valid mapping is found or
> fail the current test once the max address is reached.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> v2:
> -rename remap_region_valid() to is_remap_region_valid().
> -change return value of is_remap_region_valid() to bool.
> -take out overflow check from is_remap_region_valid() to
> inside caller.
> -fail just the current test on overflow rather than existing
> the program
> -fix alignment of mmap calls
> -change "can't" to "couldn't" in error message
> -increment mremap destination address by dest_alignment
> rather than src_alignment
>
Thank you.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Andrew, please let me know if you would like me to take this
through kselftest tree.
next prev parent reply other threads:[~2022-04-21 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 21:57 [PATCH v2 1/4] selftest/vm: verify mmap addr in mremap_test Sidhartha Kumar
2022-04-20 21:57 ` [PATCH v2 2/4] selftest/vm: verify remap destination address " Sidhartha Kumar
2022-04-21 19:31 ` Shuah Khan [this message]
2022-04-21 20:03 ` Andrew Morton
2022-04-20 21:57 ` [PATCH v2 3/4] selftest/vm: support xfail " Sidhartha Kumar
2022-04-20 21:57 ` [PATCH v2 4/4] selftest/vm: add skip support to mremap_test Sidhartha Kumar
2022-04-21 19:31 ` [PATCH v2 1/4] selftest/vm: verify mmap addr in mremap_test Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76cd8347-a8d0-3b56-a202-17ba2a73503d@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.