All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: "Paul Cercueil" <paul@crapouillou.net>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Guido Günther" <agx@sigxcpu.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: Document "label" property
Date: Tue, 21 Dec 2021 12:29:04 +0100	[thread overview]
Message-ID: <7718b4c6-59f8-c728-87ae-3c85e992e300@metafoo.de> (raw)
In-Reply-To: <20211221104354.35073-1-paul@crapouillou.net>

On 12/21/21 11:43 AM, Paul Cercueil wrote:
> All iio devices can have a label, which will be carried on to userspace
> as a sysfs attribute. This is useful when having several iio devices
> that represent different instances of the same hardware, as the name
> attribute would then not be enough to differentiate between them.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>   Documentation/devicetree/bindings/iio/common.yaml | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/common.yaml b/Documentation/devicetree/bindings/iio/common.yaml
> index f845b41d74c4..a90ad7718ecf 100644
> --- a/Documentation/devicetree/bindings/iio/common.yaml
> +++ b/Documentation/devicetree/bindings/iio/common.yaml
> @@ -32,6 +32,14 @@ properties:
>         considered 'near' to the device (an object is near to the
>         sensor).
>   
> +  label:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description: |
> +      All iio devices can have a label, which will be carried on to userspace
> +      as a sysfs attribute. This is useful when having several iio devices that
> +      represent different instances of the same hardware, as the name attribute
> +      would then not be enough to differentiate between them.
> +

The description has a lot of implementation details of the Linux kernel. 
The devicetree bindings should be formulated operating system agnostic.

Something like:

A descriptive label that allows to uniquely identify the device within 
the system.


  reply	other threads:[~2021-12-21 11:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 10:43 [PATCH] dt-bindings: iio: Document "label" property Paul Cercueil
2021-12-21 11:29 ` Lars-Peter Clausen [this message]
2021-12-21 12:38   ` Paul Cercueil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7718b4c6-59f8-c728-87ae-3c85e992e300@metafoo.de \
    --to=lars@metafoo.de \
    --cc=agx@sigxcpu.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.