Re: [Buildroot] [PATCH] relocate-sdk: Allow relocating to any location

[Arnout Vandecappelle <arnout@mind.be>]

On 29/03/2020 00:49, Gleb Mazovetskiy wrote:
> Previously, the script could only relocate to the current location.
> 
> This caused issues for SDK maintainers, as the default target location
> (e.g. /opt/my-sdk) would need to be created and the content copied
> to it during the build process, which is error-prone.
> 
> With this change you can now pass a target location argument to
> ./relocate-sdk.sh (this does not move the directory).

  Even though, as Yann indicated, the use case is a bit iffy, the patch is 
simple enough. So I applied to master, thanks.

  Your Signed-off-by was missing, so I added that.

  Regards,
  Arnout

> ---
>   support/misc/relocate-sdk.sh | 19 ++++++++++++-------
>   1 file changed, 12 insertions(+), 7 deletions(-)
> 
> diff --git a/support/misc/relocate-sdk.sh b/support/misc/relocate-sdk.sh
> index caabeaa6f6..981d272425 100755
> --- a/support/misc/relocate-sdk.sh
> +++ b/support/misc/relocate-sdk.sh
> @@ -1,15 +1,20 @@
>   #!/bin/sh
> -#
> -if [ "$#" -ne 0 ]; then
> -    echo "Run this script to relocate the buildroot SDK at that location"
> +
> +if [ "$#" -gt 1 ]; then
> +    echo "Usage: $0 [path]"
> +    echo "Run this script to relocate the buildroot SDK to the current location"
> +    echo "If [path] is given, sets the location to [path] (without moving it)"
>       exit 1
>   fi
>   
> -LOCFILE="share/buildroot/sdk-location"
> -FILEPATH="$(readlink -f "$0")"
> -NEWPATH="$(dirname "${FILEPATH}")"
> +cd "$(dirname "$(readlink -f "$0")")"
> +if [ "$#" -eq 1 ]; then
> +    NEWPATH="$1"
> +else
> +    NEWPATH="${PWD}"
> +fi
>   
> -cd "${NEWPATH}"
> +LOCFILE="share/buildroot/sdk-location"
>   if [ ! -r "${LOCFILE}" ]; then
>       echo "Previous location of the buildroot SDK not found!"
>       exit 1
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot