On 11/1/20 11:49 PM, Drew Fustini wrote:
>>>> Try these lines in /boot/config.txt
>>>>
>>>> dtoverlay=mcp251xfd-spi0-0,interrupt=25
>>>> dtoverlay=mcp251xfd-spi1-0,interrupt=16

If you use the above lines ^^, the patching of the overlay should not be necessary:

> I changed this in mcp251xfd-spi1-0-overlay.dts:
> -                               interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> +                               interrupts = <16 IRQ_TYPE_LEVEL_LOW>;

[...]

> pi@raspberrypi:~$ dmesg | grep -Ei can\|spi
> [   14.663345] CAN device driver interface
> [   14.669552] spi_master spi0: will run message pump with realtime priority
> [   14.677102] mcp251xfd spi0.0 can0: MCP2517FD rev0.0 (-RX_INT
> +MAB_NO_WARN +CRC_REG +CRC_RX +CRC_TX +ECC -HD c:40.00MHz m:20.00MHz
> r:17.00MHz e:0.00MHz) successfully initialized.
> [   14.677833] spi_master spi1: will run message pump with realtime priority
> [   14.682667] mcp251xfd spi1.0 can1: MCP2517FD rev0.0 (-RX_INT
> +MAB_NO_WARN +CRC_REG +CRC_RX +CRC_TX +ECC -HD c:40.00MHz m:20.00MHz
> r:17.00MHz e:0.00MHz) successfully initialized.

Note: the waveshare module uses a mcp2517fd, which has some erratas. You will
experience error frames generated by sending mcp2517fd modules, during certain
conditions. Sometimes CAN frames in the RX path are dropped.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |