From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD4B9C433EF for ; Sat, 2 Apr 2022 01:25:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230325AbiDBB13 (ORCPT ); Fri, 1 Apr 2022 21:27:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbiDBB13 (ORCPT ); Fri, 1 Apr 2022 21:27:29 -0400 Received: from mail-m17637.qiye.163.com (mail-m17637.qiye.163.com [59.111.176.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF0FF176D08 for ; Fri, 1 Apr 2022 18:25:36 -0700 (PDT) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id 61F4298040C; Sat, 2 Apr 2022 09:25:34 +0800 (CST) Message-ID: <7b2630d8-0575-5d65-dd81-3ef336ad5ba7@rock-chips.com> Date: Sat, 2 Apr 2022 09:25:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Content-Language: en-US To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Kever Yang References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> <20220331081815.GF4012@pengutronix.de> <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> <20220401125527.GM4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220401125527.GM4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRofT0JWT05KS0hPTE seQklDVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MTo6HRw4Ij5PSgNWKyE5UToz KhdPFAxVSlVKTU9DQ01JTEhPQkJLVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTE9MSDcG X-HM-Tid: 0a7fe7e0a98bd992kuws61f4298040c Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sascha: On 4/1/22 20:55, Sascha Hauer wrote: > On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote: >> Hi: >> >> On 3/31/22 16:18, Sascha Hauer wrote: >>> On Thu, Mar 31, 2022 at 03:20:37PM +0800, Andy Yan wrote: >>>> Hi Sascha: >>>> >>>> On 3/31/22 15:06, Sascha Hauer wrote: >>>>> On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote: >>>>>> Hi Sascha: >>>>>> >>>>>> On 3/30/22 14:39, Sascha Hauer wrote: >>>>>>> Hi Andy, >>>>>>> >>>>>>> On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote: >>>>>>>> Hi Sascha: >>>>>>>> >>>>>>>> On 3/28/22 23:11, Sascha Hauer wrote: >>>>>>>>> With upcoming VOP2 support VOP won't be the only choice anymore, so make >>>>>>>>> the VOP driver optional. >>>>>>>>> >>>>>>>>> Signed-off-by: Sascha Hauer >>>>>>>>> --- >>>>>>>>> drivers/gpu/drm/rockchip/Kconfig | 8 ++++++++ >>>>>>>>> drivers/gpu/drm/rockchip/Makefile | 3 ++- >>>>>>>>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- >>>>>>>>> 3 files changed, 11 insertions(+), 2 deletions(-) >>>>>>>>> >>>>>>>>> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig >>>>>>>>> index fa5cfda4e90e3..7d22e2997a571 100644 >>>>>>>>> --- a/drivers/gpu/drm/rockchip/Kconfig >>>>>>>>> +++ b/drivers/gpu/drm/rockchip/Kconfig >>>>>>>>> @@ -23,8 +23,16 @@ config DRM_ROCKCHIP >>>>>>>>> if DRM_ROCKCHIP >>>>>>>>> +config ROCKCHIP_VOP >>>>>>>>> + bool "Rockchip VOP driver" >>>>>>>>> + default y >>>>>>>>> + help >>>>>>>>> + This selects support for the VOP driver. You should enable it >>>>>>>>> + on all older SoCs up to RK3399. >>>>>>> That reminds me that I wanted to rephrase this. Will change in next >>>>>>> round. >>>>>>> >>>>>>>>> + >>>>>>>>> config ROCKCHIP_ANALOGIX_DP >>>>>>>>> bool "Rockchip specific extensions for Analogix DP driver" >>>>>>>>> + depends on ROCKCHIP_VOP >>>>>>>> Aanlogix dp is also on vop2 base soc such as  rk356x and rk3588. >>>>> BTW I just looked at the downstream driver. Here we have the same >>>>> situation that the analogix dp driver calls rockchip_drm_wait_vact_end() >>>>> which is implemented in the VOP driver, so when the analogix dp driver >>>>> is actually used on a VOP2 SoC then it is either used in a way that >>>>> rockchip_drm_wait_vact_end() will never be called or it explodes in all >>>>> colours. >>>>> >>>>>>> I added the dependency because analogix_dp-rockchip.c calls >>>>>>> rockchip_drm_wait_vact_end() which is implemented in the VOP driver, >>>>>>> so this driver currenty can't work with the VOP2 driver and can't >>>>>>> be linked without the VOP driver being present. >>>>>>> I'll add a few words to the commit message. >>>>>> Maybe a better direction is move rockchip_drm_wait_vact_end from the VOP >>>>>> driver to rockchip_drm_drv.c >>>>> I am not sure if that's really worth it. Yes, the direction might be the >>>>> right one, but I would really prefer when somebody does the change who >>>>> can test and confirm that the analogix dp really works with VOP2 in the >>>>> end. >>>> If follow this point, the current DW_MIPI also has not been tested for >>>> confirm that it >>>> >>>> can really work with VOP2, so you should also make it depends on >>>> ROCKCHIP_VOP. >>> Well at least I have patches here which make DW_MIPI work with VOP2 ;) >> >> But you DW_MIPI patches for rk356x didn't come. So this is not keep >> consistency with this point. >> >>> What about the others, like LVDS and RGB? >> >> Yes, we also have other interface , RK356X has LVDS/RGB/BT1120/BT656, RK3588 >> has BT1120/BT656, no LVDS or RGB. >> >>>> I think the current solution is just a workaround to make your patch pass >>>> the kernel compile >>> Indeed. >>> >>> I agree that it would be good to add a note somewhere which outputs >>> work with the VOP2 driver (currently only HDMI), but I wonder if Kconfig >>> dependencies is the right place for it, because only people who deliberately >>> disable VOP support will see this information. >>> Maybe we should rather add it to the Kconfig help text? >> >> If a device is supported for this soc, we will add dt node at the dtsi file. >> >> A Kconfig dependencies don't seems a good idea. > Ok, this means we can keep my current approach with just letting > ROCKCHIP_ANALOGIX_DP depend on ROCKCHIP_VOP to avoid having a non Excuse me? How do you get this conclusion ? I said before,  vop and vop2 based platforms both have ROCKCHIP_ANALOGIX_DP. If this patch will cause the compile error, please do a real fix, not a workaround that may deliver misleading information. > buildable kernel. > > Sascha > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C6CCC433F5 for ; Sat, 2 Apr 2022 01:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kqz6IqWcMsPh6hiFmnJHQ/7UAlEotkbGNVcnzEB3W1I=; b=A0CFQNcBP5fGMi /ehtlKqmhtPgkhgFrSlCVpDYu1wANYWUYR6UiXw1RbsXXEmFXu8dPtV068+PWauASgxEcZtlNH0XS bwFBIR+bMqJeHwjWH/aJgat/TNJnyjlLKcRdnLeDkdbGm5V/nbc2ZUHtV//RwqP4BmOb/6Sq+Yc4Q 6HrOnRaORNHCjInlVi9+Bxhp3xKzwHwK6XjCb+tXMSLenFbnQIpwd+p/siVXGH+nkhPmLI023+nb+ YsD8ydZxb5lZv+Qdo2r4cX54gxpP0rj5CEiukPJnL+UbcHZ1l66B1F6jA6Go95UVQoU8PMmb8mpnb KRp7H/vpJMYCaYaESp3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naSWU-007iZE-0l; Sat, 02 Apr 2022 01:25:50 +0000 Received: from mail-m17637.qiye.163.com ([59.111.176.37]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naSWH-007iWF-Gb; Sat, 02 Apr 2022 01:25:40 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id 61F4298040C; Sat, 2 Apr 2022 09:25:34 +0800 (CST) Message-ID: <7b2630d8-0575-5d65-dd81-3ef336ad5ba7@rock-chips.com> Date: Sat, 2 Apr 2022 09:25:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Content-Language: en-US To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Kever Yang References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> <20220331081815.GF4012@pengutronix.de> <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> <20220401125527.GM4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220401125527.GM4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRofT0JWT05KS0hPTE seQklDVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MTo6HRw4Ij5PSgNWKyE5UToz KhdPFAxVSlVKTU9DQ01JTEhPQkJLVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTE9MSDcG X-HM-Tid: 0a7fe7e0a98bd992kuws61f4298040c X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_182537_912137_5ABCF07D X-CRM114-Status: GOOD ( 29.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgU2FzY2hhOgoKT24gNC8xLzIyIDIwOjU1LCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4gT24gVGh1 LCBNYXIgMzEsIDIwMjIgYXQgMDc6MDA6MzRQTSArMDgwMCwgQW5keSBZYW4gd3JvdGU6Cj4+IEhp Ogo+Pgo+PiBPbiAzLzMxLzIyIDE2OjE4LCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4+PiBPbiBUaHUs IE1hciAzMSwgMjAyMiBhdCAwMzoyMDozN1BNICswODAwLCBBbmR5IFlhbiB3cm90ZToKPj4+PiBI aSBTYXNjaGE6Cj4+Pj4KPj4+PiBPbiAzLzMxLzIyIDE1OjA2LCBTYXNjaGEgSGF1ZXIgd3JvdGU6 Cj4+Pj4+IE9uIFdlZCwgTWFyIDMwLCAyMDIyIGF0IDA4OjUwOjA5UE0gKzA4MDAsIEFuZHkgWWFu IHdyb3RlOgo+Pj4+Pj4gSGkgU2FzY2hhOgo+Pj4+Pj4KPj4+Pj4+IE9uIDMvMzAvMjIgMTQ6Mzks IFNhc2NoYSBIYXVlciB3cm90ZToKPj4+Pj4+PiBIaSBBbmR5LAo+Pj4+Pj4+Cj4+Pj4+Pj4gT24g VHVlLCBNYXIgMjksIDIwMjIgYXQgMDc6NTY6MjdQTSArMDgwMCwgQW5keSBZYW4gd3JvdGU6Cj4+ Pj4+Pj4+IEhpIFNhc2NoYToKPj4+Pj4+Pj4KPj4+Pj4+Pj4gT24gMy8yOC8yMiAyMzoxMSwgU2Fz Y2hhIEhhdWVyIHdyb3RlOgo+Pj4+Pj4+Pj4gV2l0aCB1cGNvbWluZyBWT1AyIHN1cHBvcnQgVk9Q IHdvbid0IGJlIHRoZSBvbmx5IGNob2ljZSBhbnltb3JlLCBzbyBtYWtlCj4+Pj4+Pj4+PiB0aGUg Vk9QIGRyaXZlciBvcHRpb25hbC4KPj4+Pj4+Pj4+Cj4+Pj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBT YXNjaGEgSGF1ZXIgPHMuaGF1ZXJAcGVuZ3V0cm9uaXguZGU+Cj4+Pj4+Pj4+PiAtLS0KPj4+Pj4+ Pj4+ICAgICAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnICAgICAgICAgICAgfCA4 ICsrKysrKysrCj4+Pj4+Pj4+PiAgICAgICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvTWFrZWZp bGUgICAgICAgICAgIHwgMyArKy0KPj4+Pj4+Pj4+ICAgICAgIGRyaXZlcnMvZ3B1L2RybS9yb2Nr Y2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMgfCAyICstCj4+Pj4+Pj4+PiAgICAgICAzIGZpbGVzIGNo YW5nZWQsIDExIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+Pj4+Pj4+Pgo+Pj4+Pj4+ Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnIGIvZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL0tjb25maWcKPj4+Pj4+Pj4+IGluZGV4IGZhNWNmZGE0ZTkwZTMu LjdkMjJlMjk5N2E1NzEgMTAwNjQ0Cj4+Pj4+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvS2NvbmZpZwo+Pj4+Pj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL0tj b25maWcKPj4+Pj4+Pj4+IEBAIC0yMyw4ICsyMywxNiBAQCBjb25maWcgRFJNX1JPQ0tDSElQCj4+ Pj4+Pj4+PiAgICAgICBpZiBEUk1fUk9DS0NISVAKPj4+Pj4+Pj4+ICtjb25maWcgUk9DS0NISVBf Vk9QCj4+Pj4+Pj4+PiArCWJvb2wgIlJvY2tjaGlwIFZPUCBkcml2ZXIiCj4+Pj4+Pj4+PiArCWRl ZmF1bHQgeQo+Pj4+Pj4+Pj4gKwloZWxwCj4+Pj4+Pj4+PiArCSAgVGhpcyBzZWxlY3RzIHN1cHBv cnQgZm9yIHRoZSBWT1AgZHJpdmVyLiBZb3Ugc2hvdWxkIGVuYWJsZSBpdAo+Pj4+Pj4+Pj4gKwkg IG9uIGFsbCBvbGRlciBTb0NzIHVwIHRvIFJLMzM5OS4KPj4+Pj4+PiBUaGF0IHJlbWluZHMgbWUg dGhhdCBJIHdhbnRlZCB0byByZXBocmFzZSB0aGlzLiBXaWxsIGNoYW5nZSBpbiBuZXh0Cj4+Pj4+ Pj4gcm91bmQuCj4+Pj4+Pj4KPj4+Pj4+Pj4+ICsKPj4+Pj4+Pj4+ICAgICAgIGNvbmZpZyBST0NL Q0hJUF9BTkFMT0dJWF9EUAo+Pj4+Pj4+Pj4gICAgICAgCWJvb2wgIlJvY2tjaGlwIHNwZWNpZmlj IGV4dGVuc2lvbnMgZm9yIEFuYWxvZ2l4IERQIGRyaXZlciIKPj4+Pj4+Pj4+ICsJZGVwZW5kcyBv biBST0NLQ0hJUF9WT1AKPj4+Pj4+Pj4gQWFubG9naXggZHAgaXMgYWxzbyBvbiB2b3AyIGJhc2Ug c29jIHN1Y2ggYXPCoCByazM1NnggYW5kIHJrMzU4OC4KPj4+Pj4gQlRXIEkganVzdCBsb29rZWQg YXQgdGhlIGRvd25zdHJlYW0gZHJpdmVyLiBIZXJlIHdlIGhhdmUgdGhlIHNhbWUKPj4+Pj4gc2l0 dWF0aW9uIHRoYXQgdGhlIGFuYWxvZ2l4IGRwIGRyaXZlciBjYWxscyByb2NrY2hpcF9kcm1fd2Fp dF92YWN0X2VuZCgpCj4+Pj4+IHdoaWNoIGlzIGltcGxlbWVudGVkIGluIHRoZSBWT1AgZHJpdmVy LCBzbyB3aGVuIHRoZSBhbmFsb2dpeCBkcCBkcml2ZXIKPj4+Pj4gaXMgYWN0dWFsbHkgdXNlZCBv biBhIFZPUDIgU29DIHRoZW4gaXQgaXMgZWl0aGVyIHVzZWQgaW4gYSB3YXkgdGhhdAo+Pj4+PiBy b2NrY2hpcF9kcm1fd2FpdF92YWN0X2VuZCgpIHdpbGwgbmV2ZXIgYmUgY2FsbGVkIG9yIGl0IGV4 cGxvZGVzIGluIGFsbAo+Pj4+PiBjb2xvdXJzLgo+Pj4+Pgo+Pj4+Pj4+IEkgYWRkZWQgdGhlIGRl cGVuZGVuY3kgYmVjYXVzZSBhbmFsb2dpeF9kcC1yb2NrY2hpcC5jIGNhbGxzCj4+Pj4+Pj4gcm9j a2NoaXBfZHJtX3dhaXRfdmFjdF9lbmQoKSB3aGljaCBpcyBpbXBsZW1lbnRlZCBpbiB0aGUgVk9Q IGRyaXZlciwKPj4+Pj4+PiBzbyB0aGlzIGRyaXZlciBjdXJyZW50eSBjYW4ndCB3b3JrIHdpdGgg dGhlIFZPUDIgZHJpdmVyIGFuZCBjYW4ndAo+Pj4+Pj4+IGJlIGxpbmtlZCB3aXRob3V0IHRoZSBW T1AgZHJpdmVyIGJlaW5nIHByZXNlbnQuCj4+Pj4+Pj4gSSdsbCBhZGQgYSBmZXcgd29yZHMgdG8g dGhlIGNvbW1pdCBtZXNzYWdlLgo+Pj4+Pj4gTWF5YmUgYSBiZXR0ZXIgZGlyZWN0aW9uIGlzIG1v dmUgcm9ja2NoaXBfZHJtX3dhaXRfdmFjdF9lbmQgZnJvbSB0aGUgVk9QCj4+Pj4+PiBkcml2ZXIg dG8gcm9ja2NoaXBfZHJtX2Rydi5jCj4+Pj4+IEkgYW0gbm90IHN1cmUgaWYgdGhhdCdzIHJlYWxs eSB3b3J0aCBpdC4gWWVzLCB0aGUgZGlyZWN0aW9uIG1pZ2h0IGJlIHRoZQo+Pj4+PiByaWdodCBv bmUsIGJ1dCBJIHdvdWxkIHJlYWxseSBwcmVmZXIgd2hlbiBzb21lYm9keSBkb2VzIHRoZSBjaGFu Z2Ugd2hvCj4+Pj4+IGNhbiB0ZXN0IGFuZCBjb25maXJtIHRoYXQgdGhlIGFuYWxvZ2l4IGRwIHJl YWxseSB3b3JrcyB3aXRoIFZPUDIgaW4gdGhlCj4+Pj4+IGVuZC4KPj4+PiBJZiBmb2xsb3cgdGhp cyBwb2ludCwgdGhlIGN1cnJlbnQgRFdfTUlQSSBhbHNvIGhhcyBub3QgYmVlbiB0ZXN0ZWQgZm9y Cj4+Pj4gY29uZmlybSB0aGF0IGl0Cj4+Pj4KPj4+PiBjYW4gcmVhbGx5IHdvcmsgd2l0aCBWT1Ay LCBzbyB5b3Ugc2hvdWxkIGFsc28gbWFrZSBpdCBkZXBlbmRzIG9uCj4+Pj4gUk9DS0NISVBfVk9Q Lgo+Pj4gV2VsbCBhdCBsZWFzdCBJIGhhdmUgcGF0Y2hlcyBoZXJlIHdoaWNoIG1ha2UgRFdfTUlQ SSB3b3JrIHdpdGggVk9QMiA7KQo+Pgo+PiBCdXQgeW91IERXX01JUEkgcGF0Y2hlcyBmb3Igcmsz NTZ4IGRpZG4ndCBjb21lLiBTbyB0aGlzIGlzIG5vdCBrZWVwCj4+IGNvbnNpc3RlbmN5IHdpdGgg dGhpcyBwb2ludC4KPj4KPj4+IFdoYXQgYWJvdXQgdGhlIG90aGVycywgbGlrZSBMVkRTIGFuZCBS R0I/Cj4+Cj4+IFllcywgd2UgYWxzbyBoYXZlIG90aGVyIGludGVyZmFjZSAsIFJLMzU2WCBoYXMg TFZEUy9SR0IvQlQxMTIwL0JUNjU2LCBSSzM1ODgKPj4gaGFzIEJUMTEyMC9CVDY1Niwgbm8gTFZE UyBvciBSR0IuCj4+Cj4+Pj4gSSB0aGluayB0aGUgY3VycmVudCBzb2x1dGlvbiBpcyBqdXN0IGEg d29ya2Fyb3VuZCB0byBtYWtlIHlvdXIgcGF0Y2ggcGFzcwo+Pj4+IHRoZSBrZXJuZWwgY29tcGls ZQo+Pj4gSW5kZWVkLgo+Pj4KPj4+IEkgYWdyZWUgdGhhdCBpdCB3b3VsZCBiZSBnb29kIHRvIGFk ZCBhIG5vdGUgc29tZXdoZXJlIHdoaWNoIG91dHB1dHMKPj4+IHdvcmsgd2l0aCB0aGUgVk9QMiBk cml2ZXIgKGN1cnJlbnRseSBvbmx5IEhETUkpLCBidXQgSSB3b25kZXIgaWYgS2NvbmZpZwo+Pj4g ZGVwZW5kZW5jaWVzIGlzIHRoZSByaWdodCBwbGFjZSBmb3IgaXQsIGJlY2F1c2Ugb25seSBwZW9w bGUgd2hvIGRlbGliZXJhdGVseQo+Pj4gZGlzYWJsZSBWT1Agc3VwcG9ydCB3aWxsIHNlZSB0aGlz IGluZm9ybWF0aW9uLgo+Pj4gTWF5YmUgd2Ugc2hvdWxkIHJhdGhlciBhZGQgaXQgdG8gdGhlIEtj b25maWcgaGVscCB0ZXh0Pwo+Pgo+PiBJZiBhIGRldmljZSBpcyBzdXBwb3J0ZWQgZm9yIHRoaXMg c29jLCB3ZSB3aWxsIGFkZCBkdCBub2RlIGF0IHRoZSBkdHNpIGZpbGUuCj4+Cj4+IEEgS2NvbmZp ZyBkZXBlbmRlbmNpZXMgZG9uJ3Qgc2VlbXMgYSBnb29kIGlkZWEuCj4gT2ssIHRoaXMgbWVhbnMg d2UgY2FuIGtlZXAgbXkgY3VycmVudCBhcHByb2FjaCB3aXRoIGp1c3QgbGV0dGluZwo+IFJPQ0tD SElQX0FOQUxPR0lYX0RQIGRlcGVuZCBvbiBST0NLQ0hJUF9WT1AgdG8gYXZvaWQgaGF2aW5nIGEg bm9uCgpFeGN1c2UgbWU/IEhvdyBkbyB5b3UgZ2V0IHRoaXMgY29uY2x1c2lvbiA/CgpJIHNhaWQg YmVmb3JlLMKgIHZvcCBhbmQgdm9wMiBiYXNlZCBwbGF0Zm9ybXMgYm90aCBoYXZlIFJPQ0tDSElQ X0FOQUxPR0lYX0RQLgoKSWYgdGhpcyBwYXRjaCB3aWxsIGNhdXNlIHRoZSBjb21waWxlIGVycm9y LCBwbGVhc2UgZG8gYSByZWFsIGZpeCwgbm90IGEKCndvcmthcm91bmQgdGhhdCBtYXkgZGVsaXZl ciBtaXNsZWFkaW5nIGluZm9ybWF0aW9uLgoKPiBidWlsZGFibGUga2VybmVsLgo+Cj4gU2FzY2hh Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4 LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2No aXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3138FC433F5 for ; Sat, 2 Apr 2022 01:25:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CC4610E08F; Sat, 2 Apr 2022 01:25:38 +0000 (UTC) Received: from mail-m17637.qiye.163.com (mail-m17637.qiye.163.com [59.111.176.37]) by gabe.freedesktop.org (Postfix) with ESMTPS id C98AA10E08F for ; Sat, 2 Apr 2022 01:25:36 +0000 (UTC) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id 61F4298040C; Sat, 2 Apr 2022 09:25:34 +0800 (CST) Message-ID: <7b2630d8-0575-5d65-dd81-3ef336ad5ba7@rock-chips.com> Date: Sat, 2 Apr 2022 09:25:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Content-Language: en-US To: Sascha Hauer References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> <20220331081815.GF4012@pengutronix.de> <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> <20220401125527.GM4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220401125527.GM4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRofT0JWT05KS0hPTE seQklDVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MTo6HRw4Ij5PSgNWKyE5UToz KhdPFAxVSlVKTU9DQ01JTEhPQkJLVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTE9MSDcG X-HM-Tid: 0a7fe7e0a98bd992kuws61f4298040c X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , dri-devel@lists.freedesktop.org, Kever Yang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sascha: On 4/1/22 20:55, Sascha Hauer wrote: > On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote: >> Hi: >> >> On 3/31/22 16:18, Sascha Hauer wrote: >>> On Thu, Mar 31, 2022 at 03:20:37PM +0800, Andy Yan wrote: >>>> Hi Sascha: >>>> >>>> On 3/31/22 15:06, Sascha Hauer wrote: >>>>> On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote: >>>>>> Hi Sascha: >>>>>> >>>>>> On 3/30/22 14:39, Sascha Hauer wrote: >>>>>>> Hi Andy, >>>>>>> >>>>>>> On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote: >>>>>>>> Hi Sascha: >>>>>>>> >>>>>>>> On 3/28/22 23:11, Sascha Hauer wrote: >>>>>>>>> With upcoming VOP2 support VOP won't be the only choice anymore, so make >>>>>>>>> the VOP driver optional. >>>>>>>>> >>>>>>>>> Signed-off-by: Sascha Hauer >>>>>>>>> --- >>>>>>>>> drivers/gpu/drm/rockchip/Kconfig | 8 ++++++++ >>>>>>>>> drivers/gpu/drm/rockchip/Makefile | 3 ++- >>>>>>>>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- >>>>>>>>> 3 files changed, 11 insertions(+), 2 deletions(-) >>>>>>>>> >>>>>>>>> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig >>>>>>>>> index fa5cfda4e90e3..7d22e2997a571 100644 >>>>>>>>> --- a/drivers/gpu/drm/rockchip/Kconfig >>>>>>>>> +++ b/drivers/gpu/drm/rockchip/Kconfig >>>>>>>>> @@ -23,8 +23,16 @@ config DRM_ROCKCHIP >>>>>>>>> if DRM_ROCKCHIP >>>>>>>>> +config ROCKCHIP_VOP >>>>>>>>> + bool "Rockchip VOP driver" >>>>>>>>> + default y >>>>>>>>> + help >>>>>>>>> + This selects support for the VOP driver. You should enable it >>>>>>>>> + on all older SoCs up to RK3399. >>>>>>> That reminds me that I wanted to rephrase this. Will change in next >>>>>>> round. >>>>>>> >>>>>>>>> + >>>>>>>>> config ROCKCHIP_ANALOGIX_DP >>>>>>>>> bool "Rockchip specific extensions for Analogix DP driver" >>>>>>>>> + depends on ROCKCHIP_VOP >>>>>>>> Aanlogix dp is also on vop2 base soc such as  rk356x and rk3588. >>>>> BTW I just looked at the downstream driver. Here we have the same >>>>> situation that the analogix dp driver calls rockchip_drm_wait_vact_end() >>>>> which is implemented in the VOP driver, so when the analogix dp driver >>>>> is actually used on a VOP2 SoC then it is either used in a way that >>>>> rockchip_drm_wait_vact_end() will never be called or it explodes in all >>>>> colours. >>>>> >>>>>>> I added the dependency because analogix_dp-rockchip.c calls >>>>>>> rockchip_drm_wait_vact_end() which is implemented in the VOP driver, >>>>>>> so this driver currenty can't work with the VOP2 driver and can't >>>>>>> be linked without the VOP driver being present. >>>>>>> I'll add a few words to the commit message. >>>>>> Maybe a better direction is move rockchip_drm_wait_vact_end from the VOP >>>>>> driver to rockchip_drm_drv.c >>>>> I am not sure if that's really worth it. Yes, the direction might be the >>>>> right one, but I would really prefer when somebody does the change who >>>>> can test and confirm that the analogix dp really works with VOP2 in the >>>>> end. >>>> If follow this point, the current DW_MIPI also has not been tested for >>>> confirm that it >>>> >>>> can really work with VOP2, so you should also make it depends on >>>> ROCKCHIP_VOP. >>> Well at least I have patches here which make DW_MIPI work with VOP2 ;) >> >> But you DW_MIPI patches for rk356x didn't come. So this is not keep >> consistency with this point. >> >>> What about the others, like LVDS and RGB? >> >> Yes, we also have other interface , RK356X has LVDS/RGB/BT1120/BT656, RK3588 >> has BT1120/BT656, no LVDS or RGB. >> >>>> I think the current solution is just a workaround to make your patch pass >>>> the kernel compile >>> Indeed. >>> >>> I agree that it would be good to add a note somewhere which outputs >>> work with the VOP2 driver (currently only HDMI), but I wonder if Kconfig >>> dependencies is the right place for it, because only people who deliberately >>> disable VOP support will see this information. >>> Maybe we should rather add it to the Kconfig help text? >> >> If a device is supported for this soc, we will add dt node at the dtsi file. >> >> A Kconfig dependencies don't seems a good idea. > Ok, this means we can keep my current approach with just letting > ROCKCHIP_ANALOGIX_DP depend on ROCKCHIP_VOP to avoid having a non Excuse me? How do you get this conclusion ? I said before,  vop and vop2 based platforms both have ROCKCHIP_ANALOGIX_DP. If this patch will cause the compile error, please do a real fix, not a workaround that may deliver misleading information. > buildable kernel. > > Sascha > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F873C433EF for ; Sat, 2 Apr 2022 01:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xEB9tWBZTEGRtXXdWF27asUUowU6oXKRITmfW75W/D8=; b=JGOncVAT7OaXCQ BZbshyVmEpMlliTRyVmjvUpWxEKoJvYbd5rSa7im9xP1upF1QtumM8acPoSpQy5A0ndcoi9zBkfrQ EIAgJmAM0QysXmiL5klPc1DIzQv6yBDperndt9uQn2Onk5BVjyxenFCitKma3EdmxULDYbA035OLs eNHknfzu80OcDB2ZD4i6MfhTLRquXaE0En/qqFxqVJK1NQ4yciuASQ0Q8zsQNgYwW1v70QZR7yoC6 idXKmzYSY6GucDTGAfzcbNc0WXRW4jYTyJnAYkCEO3F64JlLo3ysPbbNZWFQ5xukkQlh10+a37iWc Ik5mKE6gVyQQfejL0Vlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naSWM-007iXn-BS; Sat, 02 Apr 2022 01:25:42 +0000 Received: from mail-m17637.qiye.163.com ([59.111.176.37]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naSWH-007iWF-Gb; Sat, 02 Apr 2022 01:25:40 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id 61F4298040C; Sat, 2 Apr 2022 09:25:34 +0800 (CST) Message-ID: <7b2630d8-0575-5d65-dd81-3ef336ad5ba7@rock-chips.com> Date: Sat, 2 Apr 2022 09:25:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Content-Language: en-US To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Kever Yang References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> <20220331081815.GF4012@pengutronix.de> <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> <20220401125527.GM4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220401125527.GM4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRofT0JWT05KS0hPTE seQklDVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MTo6HRw4Ij5PSgNWKyE5UToz KhdPFAxVSlVKTU9DQ01JTEhPQkJLVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTE9MSDcG X-HM-Tid: 0a7fe7e0a98bd992kuws61f4298040c X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_182537_912137_5ABCF07D X-CRM114-Status: GOOD ( 29.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU2FzY2hhOgoKT24gNC8xLzIyIDIwOjU1LCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4gT24gVGh1 LCBNYXIgMzEsIDIwMjIgYXQgMDc6MDA6MzRQTSArMDgwMCwgQW5keSBZYW4gd3JvdGU6Cj4+IEhp Ogo+Pgo+PiBPbiAzLzMxLzIyIDE2OjE4LCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4+PiBPbiBUaHUs IE1hciAzMSwgMjAyMiBhdCAwMzoyMDozN1BNICswODAwLCBBbmR5IFlhbiB3cm90ZToKPj4+PiBI aSBTYXNjaGE6Cj4+Pj4KPj4+PiBPbiAzLzMxLzIyIDE1OjA2LCBTYXNjaGEgSGF1ZXIgd3JvdGU6 Cj4+Pj4+IE9uIFdlZCwgTWFyIDMwLCAyMDIyIGF0IDA4OjUwOjA5UE0gKzA4MDAsIEFuZHkgWWFu IHdyb3RlOgo+Pj4+Pj4gSGkgU2FzY2hhOgo+Pj4+Pj4KPj4+Pj4+IE9uIDMvMzAvMjIgMTQ6Mzks IFNhc2NoYSBIYXVlciB3cm90ZToKPj4+Pj4+PiBIaSBBbmR5LAo+Pj4+Pj4+Cj4+Pj4+Pj4gT24g VHVlLCBNYXIgMjksIDIwMjIgYXQgMDc6NTY6MjdQTSArMDgwMCwgQW5keSBZYW4gd3JvdGU6Cj4+ Pj4+Pj4+IEhpIFNhc2NoYToKPj4+Pj4+Pj4KPj4+Pj4+Pj4gT24gMy8yOC8yMiAyMzoxMSwgU2Fz Y2hhIEhhdWVyIHdyb3RlOgo+Pj4+Pj4+Pj4gV2l0aCB1cGNvbWluZyBWT1AyIHN1cHBvcnQgVk9Q IHdvbid0IGJlIHRoZSBvbmx5IGNob2ljZSBhbnltb3JlLCBzbyBtYWtlCj4+Pj4+Pj4+PiB0aGUg Vk9QIGRyaXZlciBvcHRpb25hbC4KPj4+Pj4+Pj4+Cj4+Pj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBT YXNjaGEgSGF1ZXIgPHMuaGF1ZXJAcGVuZ3V0cm9uaXguZGU+Cj4+Pj4+Pj4+PiAtLS0KPj4+Pj4+ Pj4+ICAgICAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnICAgICAgICAgICAgfCA4 ICsrKysrKysrCj4+Pj4+Pj4+PiAgICAgICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvTWFrZWZp bGUgICAgICAgICAgIHwgMyArKy0KPj4+Pj4+Pj4+ICAgICAgIGRyaXZlcnMvZ3B1L2RybS9yb2Nr Y2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMgfCAyICstCj4+Pj4+Pj4+PiAgICAgICAzIGZpbGVzIGNo YW5nZWQsIDExIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+Pj4+Pj4+Pgo+Pj4+Pj4+ Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnIGIvZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL0tjb25maWcKPj4+Pj4+Pj4+IGluZGV4IGZhNWNmZGE0ZTkwZTMu LjdkMjJlMjk5N2E1NzEgMTAwNjQ0Cj4+Pj4+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvS2NvbmZpZwo+Pj4+Pj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL0tj b25maWcKPj4+Pj4+Pj4+IEBAIC0yMyw4ICsyMywxNiBAQCBjb25maWcgRFJNX1JPQ0tDSElQCj4+ Pj4+Pj4+PiAgICAgICBpZiBEUk1fUk9DS0NISVAKPj4+Pj4+Pj4+ICtjb25maWcgUk9DS0NISVBf Vk9QCj4+Pj4+Pj4+PiArCWJvb2wgIlJvY2tjaGlwIFZPUCBkcml2ZXIiCj4+Pj4+Pj4+PiArCWRl ZmF1bHQgeQo+Pj4+Pj4+Pj4gKwloZWxwCj4+Pj4+Pj4+PiArCSAgVGhpcyBzZWxlY3RzIHN1cHBv cnQgZm9yIHRoZSBWT1AgZHJpdmVyLiBZb3Ugc2hvdWxkIGVuYWJsZSBpdAo+Pj4+Pj4+Pj4gKwkg IG9uIGFsbCBvbGRlciBTb0NzIHVwIHRvIFJLMzM5OS4KPj4+Pj4+PiBUaGF0IHJlbWluZHMgbWUg dGhhdCBJIHdhbnRlZCB0byByZXBocmFzZSB0aGlzLiBXaWxsIGNoYW5nZSBpbiBuZXh0Cj4+Pj4+ Pj4gcm91bmQuCj4+Pj4+Pj4KPj4+Pj4+Pj4+ICsKPj4+Pj4+Pj4+ICAgICAgIGNvbmZpZyBST0NL Q0hJUF9BTkFMT0dJWF9EUAo+Pj4+Pj4+Pj4gICAgICAgCWJvb2wgIlJvY2tjaGlwIHNwZWNpZmlj IGV4dGVuc2lvbnMgZm9yIEFuYWxvZ2l4IERQIGRyaXZlciIKPj4+Pj4+Pj4+ICsJZGVwZW5kcyBv biBST0NLQ0hJUF9WT1AKPj4+Pj4+Pj4gQWFubG9naXggZHAgaXMgYWxzbyBvbiB2b3AyIGJhc2Ug c29jIHN1Y2ggYXPCoCByazM1NnggYW5kIHJrMzU4OC4KPj4+Pj4gQlRXIEkganVzdCBsb29rZWQg YXQgdGhlIGRvd25zdHJlYW0gZHJpdmVyLiBIZXJlIHdlIGhhdmUgdGhlIHNhbWUKPj4+Pj4gc2l0 dWF0aW9uIHRoYXQgdGhlIGFuYWxvZ2l4IGRwIGRyaXZlciBjYWxscyByb2NrY2hpcF9kcm1fd2Fp dF92YWN0X2VuZCgpCj4+Pj4+IHdoaWNoIGlzIGltcGxlbWVudGVkIGluIHRoZSBWT1AgZHJpdmVy LCBzbyB3aGVuIHRoZSBhbmFsb2dpeCBkcCBkcml2ZXIKPj4+Pj4gaXMgYWN0dWFsbHkgdXNlZCBv biBhIFZPUDIgU29DIHRoZW4gaXQgaXMgZWl0aGVyIHVzZWQgaW4gYSB3YXkgdGhhdAo+Pj4+PiBy b2NrY2hpcF9kcm1fd2FpdF92YWN0X2VuZCgpIHdpbGwgbmV2ZXIgYmUgY2FsbGVkIG9yIGl0IGV4 cGxvZGVzIGluIGFsbAo+Pj4+PiBjb2xvdXJzLgo+Pj4+Pgo+Pj4+Pj4+IEkgYWRkZWQgdGhlIGRl cGVuZGVuY3kgYmVjYXVzZSBhbmFsb2dpeF9kcC1yb2NrY2hpcC5jIGNhbGxzCj4+Pj4+Pj4gcm9j a2NoaXBfZHJtX3dhaXRfdmFjdF9lbmQoKSB3aGljaCBpcyBpbXBsZW1lbnRlZCBpbiB0aGUgVk9Q IGRyaXZlciwKPj4+Pj4+PiBzbyB0aGlzIGRyaXZlciBjdXJyZW50eSBjYW4ndCB3b3JrIHdpdGgg dGhlIFZPUDIgZHJpdmVyIGFuZCBjYW4ndAo+Pj4+Pj4+IGJlIGxpbmtlZCB3aXRob3V0IHRoZSBW T1AgZHJpdmVyIGJlaW5nIHByZXNlbnQuCj4+Pj4+Pj4gSSdsbCBhZGQgYSBmZXcgd29yZHMgdG8g dGhlIGNvbW1pdCBtZXNzYWdlLgo+Pj4+Pj4gTWF5YmUgYSBiZXR0ZXIgZGlyZWN0aW9uIGlzIG1v dmUgcm9ja2NoaXBfZHJtX3dhaXRfdmFjdF9lbmQgZnJvbSB0aGUgVk9QCj4+Pj4+PiBkcml2ZXIg dG8gcm9ja2NoaXBfZHJtX2Rydi5jCj4+Pj4+IEkgYW0gbm90IHN1cmUgaWYgdGhhdCdzIHJlYWxs eSB3b3J0aCBpdC4gWWVzLCB0aGUgZGlyZWN0aW9uIG1pZ2h0IGJlIHRoZQo+Pj4+PiByaWdodCBv bmUsIGJ1dCBJIHdvdWxkIHJlYWxseSBwcmVmZXIgd2hlbiBzb21lYm9keSBkb2VzIHRoZSBjaGFu Z2Ugd2hvCj4+Pj4+IGNhbiB0ZXN0IGFuZCBjb25maXJtIHRoYXQgdGhlIGFuYWxvZ2l4IGRwIHJl YWxseSB3b3JrcyB3aXRoIFZPUDIgaW4gdGhlCj4+Pj4+IGVuZC4KPj4+PiBJZiBmb2xsb3cgdGhp cyBwb2ludCwgdGhlIGN1cnJlbnQgRFdfTUlQSSBhbHNvIGhhcyBub3QgYmVlbiB0ZXN0ZWQgZm9y Cj4+Pj4gY29uZmlybSB0aGF0IGl0Cj4+Pj4KPj4+PiBjYW4gcmVhbGx5IHdvcmsgd2l0aCBWT1Ay LCBzbyB5b3Ugc2hvdWxkIGFsc28gbWFrZSBpdCBkZXBlbmRzIG9uCj4+Pj4gUk9DS0NISVBfVk9Q Lgo+Pj4gV2VsbCBhdCBsZWFzdCBJIGhhdmUgcGF0Y2hlcyBoZXJlIHdoaWNoIG1ha2UgRFdfTUlQ SSB3b3JrIHdpdGggVk9QMiA7KQo+Pgo+PiBCdXQgeW91IERXX01JUEkgcGF0Y2hlcyBmb3Igcmsz NTZ4IGRpZG4ndCBjb21lLiBTbyB0aGlzIGlzIG5vdCBrZWVwCj4+IGNvbnNpc3RlbmN5IHdpdGgg dGhpcyBwb2ludC4KPj4KPj4+IFdoYXQgYWJvdXQgdGhlIG90aGVycywgbGlrZSBMVkRTIGFuZCBS R0I/Cj4+Cj4+IFllcywgd2UgYWxzbyBoYXZlIG90aGVyIGludGVyZmFjZSAsIFJLMzU2WCBoYXMg TFZEUy9SR0IvQlQxMTIwL0JUNjU2LCBSSzM1ODgKPj4gaGFzIEJUMTEyMC9CVDY1Niwgbm8gTFZE UyBvciBSR0IuCj4+Cj4+Pj4gSSB0aGluayB0aGUgY3VycmVudCBzb2x1dGlvbiBpcyBqdXN0IGEg d29ya2Fyb3VuZCB0byBtYWtlIHlvdXIgcGF0Y2ggcGFzcwo+Pj4+IHRoZSBrZXJuZWwgY29tcGls ZQo+Pj4gSW5kZWVkLgo+Pj4KPj4+IEkgYWdyZWUgdGhhdCBpdCB3b3VsZCBiZSBnb29kIHRvIGFk ZCBhIG5vdGUgc29tZXdoZXJlIHdoaWNoIG91dHB1dHMKPj4+IHdvcmsgd2l0aCB0aGUgVk9QMiBk cml2ZXIgKGN1cnJlbnRseSBvbmx5IEhETUkpLCBidXQgSSB3b25kZXIgaWYgS2NvbmZpZwo+Pj4g ZGVwZW5kZW5jaWVzIGlzIHRoZSByaWdodCBwbGFjZSBmb3IgaXQsIGJlY2F1c2Ugb25seSBwZW9w bGUgd2hvIGRlbGliZXJhdGVseQo+Pj4gZGlzYWJsZSBWT1Agc3VwcG9ydCB3aWxsIHNlZSB0aGlz IGluZm9ybWF0aW9uLgo+Pj4gTWF5YmUgd2Ugc2hvdWxkIHJhdGhlciBhZGQgaXQgdG8gdGhlIEtj b25maWcgaGVscCB0ZXh0Pwo+Pgo+PiBJZiBhIGRldmljZSBpcyBzdXBwb3J0ZWQgZm9yIHRoaXMg c29jLCB3ZSB3aWxsIGFkZCBkdCBub2RlIGF0IHRoZSBkdHNpIGZpbGUuCj4+Cj4+IEEgS2NvbmZp ZyBkZXBlbmRlbmNpZXMgZG9uJ3Qgc2VlbXMgYSBnb29kIGlkZWEuCj4gT2ssIHRoaXMgbWVhbnMg d2UgY2FuIGtlZXAgbXkgY3VycmVudCBhcHByb2FjaCB3aXRoIGp1c3QgbGV0dGluZwo+IFJPQ0tD SElQX0FOQUxPR0lYX0RQIGRlcGVuZCBvbiBST0NLQ0hJUF9WT1AgdG8gYXZvaWQgaGF2aW5nIGEg bm9uCgpFeGN1c2UgbWU/IEhvdyBkbyB5b3UgZ2V0IHRoaXMgY29uY2x1c2lvbiA/CgpJIHNhaWQg YmVmb3JlLMKgIHZvcCBhbmQgdm9wMiBiYXNlZCBwbGF0Zm9ybXMgYm90aCBoYXZlIFJPQ0tDSElQ X0FOQUxPR0lYX0RQLgoKSWYgdGhpcyBwYXRjaCB3aWxsIGNhdXNlIHRoZSBjb21waWxlIGVycm9y LCBwbGVhc2UgZG8gYSByZWFsIGZpeCwgbm90IGEKCndvcmthcm91bmQgdGhhdCBtYXkgZGVsaXZl ciBtaXNsZWFkaW5nIGluZm9ybWF0aW9uLgoKPiBidWlsZGFibGUga2VybmVsLgo+Cj4gU2FzY2hh Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK