All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Jan Kara <jack@suse.cz>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [RFC PATCH] ext4: remove conflict comment from __ext4_forget
Date: Wed, 14 Jul 2021 13:52:04 +0800	[thread overview]
Message-ID: <7c151f94-75af-1e8d-4e04-0dd2fdf43b24@linux.dev> (raw)
In-Reply-To: <20210713151746.GD24271@quack2.suse.cz>



On 7/13/21 11:17 PM, Jan Kara wrote:
> On Wed 23-06-21 16:58:46, Guoqing Jiang wrote:
>> From: Guoqing Jiang <jiangguoqing@kylinos.cn>
>>
>> We do a bforget and return for no journal case, so let's remove this
>> conflict comment.
>>
>> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
> Looks good. I agree the comment seems stale. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks for your review! Will send an updated one with your Reviewed-by.

BRs,
Guoqing

      reply	other threads:[~2021-07-14  5:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  8:58 [RFC PATCH] ext4: remove conflict comment from __ext4_forget Guoqing Jiang
2021-07-13 15:17 ` Jan Kara
2021-07-14  5:52   ` Guoqing Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c151f94-75af-1e8d-4e04-0dd2fdf43b24@linux.dev \
    --to=guoqing.jiang@linux.dev \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.