Re: [PATCH v1 7/7] power: bq24190_charger: Set bq24190-battery device .type=unknown

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 21-03-17 23:09, Liam Breck wrote:
> From: Liam Breck <kernel@networkimprov.net>
>
> Not for upstream. Temporary workaround to prevent bq24190-battery device
> from interfering with a fuel gauge that has .type=power_supply_type_battery
>
> I'll move properties from -battery device to -charger in a subsequent version.
>
> Cc: Hans de Goede <hdegoede@redhat.com>

Hmm, I don't like this. I was about to post v2 of my patches (which I will
rebase on top of this series), which contains a patch to completely remove
the battery power_supply. I understand if you think it is too early for
that, but I believe that if we (temporarily) want to keep it around,
it would be better to do something like this:

     /*
      * Note the disable-battery-power-supply property is purely an in
      * kernel interface to avoid having 2 battery type power_supplies for
      * a single physical battery when there also is a fuel-gauge driver.
      * The plan is to remove the battery power_supply from the bq24190
      * driver completely, but that still needs some work.
      * Do NOT use this property in DT files.
      */
     if (!device_property_read_bool(dev, "disable-battery-power-supply")) {
         register(battery)...
     }

Sebastian would something like the above work for you as an interim
solution ? Since this uses device-properties I can easily add the
property to my i2c_board_info, and when the battery power_supply gets
removed all together the board_info can be updated independently of
the power_supply driver, so we can easily clean this up afterwards.

Regards,

Hans


> ---
>  drivers/power/supply/bq24190_charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> index a52816b..12f3780 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -1228,7 +1228,7 @@ static enum power_supply_property bq24190_battery_properties[] = {
>
>  static const struct power_supply_desc bq24190_battery_desc = {
>  	.name			= "bq24190-battery",
> -	.type			= POWER_SUPPLY_TYPE_BATTERY,
> +	.type			= POWER_SUPPLY_TYPE_UNKNOWN,
>  	.properties		= bq24190_battery_properties,
>  	.num_properties		= ARRAY_SIZE(bq24190_battery_properties),
>  	.get_property		= bq24190_battery_get_property,
>