From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66131C33CA9 for ; Tue, 14 Jan 2020 02:42:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33B9A20CC7 for ; Tue, 14 Jan 2020 02:42:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GddnC7YS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33B9A20CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irC9z-0000Dt-BW for qemu-devel@archiver.kernel.org; Mon, 13 Jan 2020 21:42:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52201) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irC9G-0007t1-LU for qemu-devel@nongnu.org; Mon, 13 Jan 2020 21:41:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irC9F-0003Oe-JA for qemu-devel@nongnu.org; Mon, 13 Jan 2020 21:41:42 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:37665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irC9F-0003NS-Cc for qemu-devel@nongnu.org; Mon, 13 Jan 2020 21:41:41 -0500 Received: by mail-pl1-x632.google.com with SMTP id c23so4616103plz.4 for ; Mon, 13 Jan 2020 18:41:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Z+qU3ZjV3dgL6PtSDGYYuA+a9MNC/JVybRb2augdjhg=; b=GddnC7YSCjqU3BnJ9b1ETTwxYW1SIYhDYGjx1HCLT1cD/L4f3k0Qe1jUeyE7Q5M4WP l+Yw+sa4kSKmPN4v+tqCfbgdtUEPbvlCFv5MdVT7Ae2aPgO+syhYWiT03lGJqorLksp2 jNfE5oq/bdDPGCrCuU3mvh+olzD0nRB6E9gzZUHAk8NcrMxj1+mivuwROvrXU2hR6WJ0 nc/otnyYOWQnENLvstNberygjCFLF5+BvnmreROUJkW1QRZKa2NCJ5KbSmfQErySPPaM s9g/WJ622VV+fRyjHx6ezKjfPG+f+6zpzALpQ1UOdhP7wawJ2Hq+CmSfyDHupbCnBStR N5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z+qU3ZjV3dgL6PtSDGYYuA+a9MNC/JVybRb2augdjhg=; b=WyZqRMtV0g1A1GaAAG5oTsyxkOaIZkBODXtfKXCLMz6ylbHg4KSgP1iG4SYTXFcgVo cpba0IDeValOIl4PBOuQlMlNbTv+L8lSjx36o15BO6O4yaHpFqKH6nt0mJvB6vqX1Kxx IGf/73TRey4b1gTI/ws5J99Hjt8H5NDpei94s6Wzk25GJtOGuFK4OPQxgvaAURcyvCEi Hx3wJDoQJTfg3cljChaVD1plYIltoXqliJc0+2I588bpFaLqY3YiFc2PVWU47Js0UShl m0O7cRFgw+ECDOxMuT9DJAvfrbmNGYETal1NICkvYcnezaY66D3E2kuY6JCeY2zshHqT eU4Q== X-Gm-Message-State: APjAAAUZKZ9e748JDMhxWC9YN0Z8bo71Xw08VpUheY3iTmQZQVec2M/4 HNJh5wuDNgPJnJFoLzykprIiqg== X-Google-Smtp-Source: APXvYqzI0C+ywTjnTTXOAkCgRAKWol5pY8q1ZH42LSaGXD4yimS1fh6O3LjTihyaXpdqjkl3QqZk4w== X-Received: by 2002:a17:902:b48c:: with SMTP id y12mr19688980plr.153.1578969699968; Mon, 13 Jan 2020 18:41:39 -0800 (PST) Received: from [192.168.3.43] (rrcs-66-91-136-155.west.biz.rr.com. [66.91.136.155]) by smtp.gmail.com with ESMTPSA id f8sm15072560pjg.28.2020.01.13.18.41.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2020 18:41:39 -0800 (PST) Subject: Re: [PATCH] target/arm: adjust program counter for wfi exception in AArch32 To: Jeff Kubascik , Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20200110180211.29025-1-jeff.kubascik@dornerworks.com> From: Richard Henderson Message-ID: <7f45c4a2-0192-aaaa-8d0f-7ea7890ca448@linaro.org> Date: Mon, 13 Jan 2020 16:41:34 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200110180211.29025-1-jeff.kubascik@dornerworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::632 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stewart Hildebrand , Jarvis Roach Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/10/20 8:02 AM, Jeff Kubascik wrote: > - env->pc -= insn_len; > + if (env->aarch64) > + env->pc -= insn_len; > + else > + env->regs[15] -= insn_len; QEMU requires all braces. See CODING_STYLE. Otherwise, Reviewed-by: Richard Henderson r~