From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lWMoX-0000fq-Pk for mharc-grub-devel@gnu.org; Tue, 13 Apr 2021 13:27:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWMoV-0000fF-RC for grub-devel@gnu.org; Tue, 13 Apr 2021 13:26:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWMoT-0000qX-IE for grub-devel@gnu.org; Tue, 13 Apr 2021 13:26:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618334816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JuUNLdV/dJbMGQrIHMs74dYPXwGnGAIhKEqBK8rYvfs=; b=OmTDKjYsOgHwhQyRhSLPJoNVwRpHo8JYdKqgow9f26gMjkPRuR5odtJGx8nXuucgrsxY16 5mMYG4jUGoJZ0m93fSQN6vE0+mVKltPG2a11RW7kduE993RmY4p+PZoas8+pNT7vhiKuld uSaIWD2oGi78ghj+PV8VA69+YOCClB4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-O5f0RRemNemCbXBML-O7uA-1; Tue, 13 Apr 2021 13:26:53 -0400 X-MC-Unique: O5f0RRemNemCbXBML-O7uA-1 Received: by mail-wm1-f71.google.com with SMTP id i5-20020a05600c3545b029010c8bb11782so1405147wmq.7 for ; Tue, 13 Apr 2021 10:26:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JuUNLdV/dJbMGQrIHMs74dYPXwGnGAIhKEqBK8rYvfs=; b=kmqcFKVp2cZxGPkCd8WEOaVqu8BC174Wh20/PNtKEtPKVAXM12eCw8qPOx0iETab69 G07UfpEc0y5qYfXEIFxn3Kvb6OKs6x6ZTBSMfh8hebrrbMqMZyl43IP54xMyly0O6MeL imxaaQYEwR7esp5BuY1D3D8UH7xfpwUdnrx8RqiF9bsEXvceiBHR52XR1EJ0g21vkq16 8q/aNSqF24k9F/1/J9gNfkTKTKzPN5ykd9ZglcwMEI4w5jC5QVXwIghMonfib7JKHFq4 HyyDFw1Pq7seYZlVTu6xrQ8jwuhjNbfXkVN/K1kw/de0PJgHedgKZMi4vBHjrEmuaAvQ ZhfA== X-Gm-Message-State: AOAM530lBW9+pvogbCfr2FuAXG+MJPdp6r30xy0OiQHR2dLW/G6VdB+m EYKWMq+8TqQyZt8OoqzwsiQLSrDPmjOBVxJHtFBmRK+sEV3boSHPckRFXuWPJhoApKLmAclKM6u O6bdngB6xo/c= X-Received: by 2002:adf:ef8b:: with SMTP id d11mr13736172wro.107.1618334812307; Tue, 13 Apr 2021 10:26:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeQ0LZtbv7zS4CNxtA5V08kmpWnTECt1VssyTqgLTpXMoRtx8i180ueUiidMCEObH2GLP2Ww== X-Received: by 2002:adf:ef8b:: with SMTP id d11mr13736157wro.107.1618334812098; Tue, 13 Apr 2021 10:26:52 -0700 (PDT) Received: from [192.168.1.101] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id s10sm2842143wrt.23.2021.04.13.10.26.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 10:26:51 -0700 (PDT) Subject: Re: [PATCH 2/2] Use 64bit type for filesystem timestamp To: Carlos Maiolino , grub-devel@gnu.org Cc: daniel.kiper@oracle.com References: <20210323132959.1594989-1-cmaiolino@redhat.com> <20210323132959.1594989-3-cmaiolino@redhat.com> From: Javier Martinez Canillas Message-ID: <8116fa51-0756-89ef-db7f-4a79910a6e1d@redhat.com> Date: Tue, 13 Apr 2021 19:26:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210323132959.1594989-3-cmaiolino@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=javierm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 17:27:00 -0000 Please also add a "fs:" prefix to the subject line here. On 3/23/21 2:29 PM, Carlos Maiolino wrote: > Some filesystems nowadays uses 64bit timestamps for timestamps, so, > update grub_dirhook_info struct to use an int64 type to store mtime. > This also updates grub_unixtime2datetime() to receive a 64-bit timestamp > argument and do 64bit-safe divisions. > > Both changes enables grub to support dates beyond y2038. > > Signed-off-by: Carlos Maiolino > --- Assuming changing this doesn't cause issues for 32-bit arches: Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat