From: Wesley Cheng <wcheng@codeaurora.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: peter.chen@nxp.com, balbi@kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/3] usb: gadget: configfs: Add a specific configFS reset callback
Date: Mon, 4 Jan 2021 11:03:38 -0800 [thread overview]
Message-ID: <81ae4b83-2dd8-e605-4f7b-e7b63f959d8d@codeaurora.org> (raw)
In-Reply-To: <X/M4EaLuiuHstHeX@kroah.com>
On 1/4/2021 7:45 AM, Greg KH wrote:
> On Tue, Dec 29, 2020 at 03:03:31PM -0800, Wesley Cheng wrote:
>> In order for configFS based USB gadgets to set the proper charge current
>> for bus reset scenarios, expose a separate reset callback to set the
>> current to 100mA based on the USB battery charging specification.
>>
>> Reviewed-by: Peter Chen <peter.chen@nxp.com>
>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
>> ---
>> drivers/usb/gadget/configfs.c | 24 +++++++++++++++++++++++-
>> 1 file changed, 23 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>> index 56051bb97349..80ca7ff2fb97 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -1481,6 +1481,28 @@ static void configfs_composite_disconnect(struct usb_gadget *gadget)
>> spin_unlock_irqrestore(&gi->spinlock, flags);
>> }
>>
>> +static void configfs_composite_reset(struct usb_gadget *gadget)
>> +{
>> + struct usb_composite_dev *cdev;
>> + struct gadget_info *gi;
>> + unsigned long flags;
>> +
>> + cdev = get_gadget_data(gadget);
>> + if (!cdev)
>> + return;
>> +
>> + gi = container_of(cdev, struct gadget_info, cdev);
>> + spin_lock_irqsave(&gi->spinlock, flags);
>> + cdev = get_gadget_data(gadget);
>> + if (!cdev || gi->unbind) {
>> + spin_unlock_irqrestore(&gi->spinlock, flags);
>> + return;
>> + }
>> +
>> + composite_reset(gadget);
>> + spin_unlock_irqrestore(&gi->spinlock, flags);
>> +}
>> +
>> static void configfs_composite_suspend(struct usb_gadget *gadget)
>> {
>> struct usb_composite_dev *cdev;
>> @@ -1530,7 +1552,7 @@ static const struct usb_gadget_driver configfs_driver_template = {
>> .unbind = configfs_composite_unbind,
>>
>> .setup = configfs_composite_setup,
>> - .reset = configfs_composite_disconnect,
>> + .reset = configfs_composite_reset,
>> .disconnect = configfs_composite_disconnect,
>>
>> .suspend = configfs_composite_suspend,
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>
> So this changes the existing userspace functionality? What will break
> because of this now unexpected change?
>
> thanks,
>
> greg k-h
>
Hi Greg,
Happy new years! This wouldn't affect the userspace interaction with
configFS, as this is modifying the reset callback for the UDC core. The
reset callback is only executed during usb_gadget_udc_reset(), which is
specifically run when vendor UDC drivers (i.e. DWC3 gadget) receive a
USB bus reset interrupt. This is similar to the composite.c patch,
because for configFS based gadgets, they do not directly register the
USB composite ops and have their own routines.
Thanks
Wesley Cheng
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-01-04 19:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 23:03 [PATCH 0/3] Add vbus draw support to DWC3 Wesley Cheng
2020-12-29 23:03 ` [PATCH 1/3] usb: dwc3: gadget: Introduce a DWC3 VBUS draw callback Wesley Cheng
2020-12-29 23:03 ` [PATCH 2/3] usb: gadget: composite: Split composite reset and disconnect Wesley Cheng
2021-01-05 13:14 ` Felipe Balbi
2021-01-08 2:19 ` Thinh Nguyen
2021-01-08 8:35 ` Jack Pham
2021-01-08 22:04 ` Thinh Nguyen
2021-01-08 9:13 ` gregkh
2021-01-08 22:13 ` Thinh Nguyen
2020-12-29 23:03 ` [PATCH 3/3] usb: gadget: configfs: Add a specific configFS reset callback Wesley Cheng
2021-01-04 15:45 ` Greg KH
2021-01-04 19:03 ` Wesley Cheng [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-14 8:12 [PATCH 0/3] Add vbus draw support to DWC3 Wesley Cheng
2020-11-14 8:12 ` [PATCH 3/3] usb: gadget: configfs: Add a specific configFS reset callback Wesley Cheng
2020-11-16 13:55 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81ae4b83-2dd8-e605-4f7b-e7b63f959d8d@codeaurora.org \
--to=wcheng@codeaurora.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.