All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Mina Almasry <almasrymina@google.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm, hugetlb: fix allocation error check and copy func name
Date: Mon, 7 Jun 2021 13:32:32 -0700	[thread overview]
Message-ID: <82674cdb-2b1e-cd12-5e60-8b19f596bf99@oracle.com> (raw)
In-Reply-To: <20210605010626.1459873-1-almasrymina@google.com>

On 6/4/21 6:06 PM, Mina Almasry wrote:
> The alloc_huge_page_vma() doesn't return error pointers, it returns
> NULL.
> 
> There is an existing migrate_page_copy() which not only copies the page
> contents, but also page state/metadata.  People could get confused that
> 'migrate_page_copy' and 'migrate_copy_huge_page' do not have the same
> functionality.  Rename to 'copy_huge_page()' to make it less likely
> folks get confused.
> 
> Fixes: 6a0badc266df ("mm, hugetlb: fix racy resv_huge_pages underflow on
> UFFDIO_COPY")
> 
> Signed-off-by: Mina Almasry <almasrymina@google.com>
> Cc: linux-mm@kvack.org
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-kernel@vger.kernel.org
> 
> ---
>  include/linux/migrate.h | 4 ++--
>  mm/hugetlb.c            | 4 ++--
>  mm/migrate.c            | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)

As mentioned by Muchun, Andrew should squash this and original patch.
With the combined patches,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz

      parent reply	other threads:[~2021-06-07 20:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28  0:50 [PATCH v4] mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY Mina Almasry
2021-05-28  0:50 ` Mina Almasry
2021-05-31 23:25 ` Andrew Morton
2021-06-01  0:11   ` Mina Almasry
2021-06-01  0:11     ` Mina Almasry
2021-06-01  0:36     ` Andrew Morton
2021-06-01  2:48       ` Mina Almasry
2021-06-01  2:48         ` Mina Almasry
2021-06-01 17:09         ` Mike Kravetz
2021-06-01 18:04           ` Mina Almasry
2021-06-01 18:04             ` Mina Almasry
2021-06-01 18:05             ` Mina Almasry
2021-06-01 18:05               ` Mina Almasry
2021-06-04 21:41 ` Mike Kravetz
2021-06-05  1:06   ` [PATCH] mm, hugetlb: fix allocation error check and copy func name Mina Almasry
2021-06-05  1:06     ` Mina Almasry
2021-06-05 12:49     ` [External] " Muchun Song
2021-06-05 12:49       ` Muchun Song
2021-06-07 20:32     ` Mike Kravetz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82674cdb-2b1e-cd12-5e60-8b19f596bf99@oracle.com \
    --to=mike.kravetz@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.