From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons Date: Thu, 07 Feb 2013 11:30:49 +0100 Message-ID: <8299289.2GSO3WcaG5@amdc1227> References: <1360214129-4096-1-git-send-email-tushar.behera@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: In-reply-to: <1360214129-4096-1-git-send-email-tushar.behera@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tushar Behera Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com, patches@linaro.org, Thomas Abraham List-Id: devicetree@vger.kernel.org Hi, I'm wondering why Exynos5250 has not been migrated to use pinctrl yet. Support for it in pinctrl-samsung driver has been already merged, but I don't see any pinctrl nodes in exynos5250.dtsi. This is important because the legacy gpio-samsung support is going to be dropped, as it already happened in case of Exynos 4. CC'ing Thomas Abraham as he might know something. Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform On Thursday 07 of February 2013 10:45:25 Tushar Behera wrote: > Added GPIO buttons DT node to Arndale board file. > > Signed-off-by: Tushar Behera > Signed-off-by: Sachin Kamat > --- > This series is based on for-next branch of Kukjin Kim's tree > and added on top of the below patch: > https://patchwork.kernel.org/patch/2042451/ > --- > arch/arm/boot/dts/exynos5250-arndale.dts | 48 > ++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 > deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts > b/arch/arm/boot/dts/exynos5250-arndale.dts index 63572f9..9ce40df > 100644 > --- a/arch/arm/boot/dts/exynos5250-arndale.dts > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts > @@ -119,4 +119,52 @@ > spi_2: spi@12d40000 { > status = "disabled"; > }; > + > + gpio_keys { > + compatible = "gpio-keys"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + menu { > + label = "SW-TACT2"; > + gpios = <&gpx1 4 0 0x10000 2>; > + linux,code = <139>; > + gpio-key,wakeup; > + }; > + > + home { > + label = "SW-TACT3"; > + gpios = <&gpx1 5 0 0x10000 2>; > + linux,code = <102>; > + gpio-key,wakeup; > + }; > + > + up { > + label = "SW-TACT4"; > + gpios = <&gpx1 6 0 0x10000 2>; > + linux,code = <103>; > + gpio-key,wakeup; > + }; > + > + down { > + label = "SW-TACT5"; > + gpios = <&gpx1 7 0 0x10000 2>; > + linux,code = <108>; > + gpio-key,wakeup; > + }; > + > + back { > + label = "SW-TACT6"; > + gpios = <&gpx2 0 0 0x10000 2>; > + linux,code = <158>; > + gpio-key,wakeup; > + }; > + > + wakeup { > + label = "SW-TACT7"; > + gpios = <&gpx2 1 0 0x10000 2>; > + linux,code = <143>; > + gpio-key,wakeup; > + }; > + }; > }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Thu, 07 Feb 2013 11:30:49 +0100 Subject: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons In-Reply-To: <1360214129-4096-1-git-send-email-tushar.behera@linaro.org> References: <1360214129-4096-1-git-send-email-tushar.behera@linaro.org> Message-ID: <8299289.2GSO3WcaG5@amdc1227> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, I'm wondering why Exynos5250 has not been migrated to use pinctrl yet. Support for it in pinctrl-samsung driver has been already merged, but I don't see any pinctrl nodes in exynos5250.dtsi. This is important because the legacy gpio-samsung support is going to be dropped, as it already happened in case of Exynos 4. CC'ing Thomas Abraham as he might know something. Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform On Thursday 07 of February 2013 10:45:25 Tushar Behera wrote: > Added GPIO buttons DT node to Arndale board file. > > Signed-off-by: Tushar Behera > Signed-off-by: Sachin Kamat > --- > This series is based on for-next branch of Kukjin Kim's tree > and added on top of the below patch: > https://patchwork.kernel.org/patch/2042451/ > --- > arch/arm/boot/dts/exynos5250-arndale.dts | 48 > ++++++++++++++++++++++++++++++ 1 files changed, 48 insertions(+), 0 > deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts > b/arch/arm/boot/dts/exynos5250-arndale.dts index 63572f9..9ce40df > 100644 > --- a/arch/arm/boot/dts/exynos5250-arndale.dts > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts > @@ -119,4 +119,52 @@ > spi_2: spi at 12d40000 { > status = "disabled"; > }; > + > + gpio_keys { > + compatible = "gpio-keys"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + menu { > + label = "SW-TACT2"; > + gpios = <&gpx1 4 0 0x10000 2>; > + linux,code = <139>; > + gpio-key,wakeup; > + }; > + > + home { > + label = "SW-TACT3"; > + gpios = <&gpx1 5 0 0x10000 2>; > + linux,code = <102>; > + gpio-key,wakeup; > + }; > + > + up { > + label = "SW-TACT4"; > + gpios = <&gpx1 6 0 0x10000 2>; > + linux,code = <103>; > + gpio-key,wakeup; > + }; > + > + down { > + label = "SW-TACT5"; > + gpios = <&gpx1 7 0 0x10000 2>; > + linux,code = <108>; > + gpio-key,wakeup; > + }; > + > + back { > + label = "SW-TACT6"; > + gpios = <&gpx2 0 0 0x10000 2>; > + linux,code = <158>; > + gpio-key,wakeup; > + }; > + > + wakeup { > + label = "SW-TACT7"; > + gpios = <&gpx2 1 0 0x10000 2>; > + linux,code = <143>; > + gpio-key,wakeup; > + }; > + }; > };