All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tiecheng Zhou <Tiecheng.Zhou-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Emily Deng <Emily.Deng-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu/sriov: Need to initialize the HDP_NONSURFACE_BAStE
Date: Tue, 14 May 2019 13:04:52 +0200	[thread overview]
Message-ID: <82fa6b02-473c-5d83-6cec-7d72fd19f48f@gmail.com> (raw)
In-Reply-To: <1557831559-6925-1-git-send-email-Tiecheng.Zhou-5C7GfCeVMHo@public.gmane.org>

Am 14.05.19 um 12:59 schrieb Tiecheng Zhou:
> it requires to initialize HDP_NONSURFACE_BASE, so as to avoid
> using the value left by a previous VM under sriov scenario.
>
> v2: it should not hurt baremetal, generalize it for both sriov
> and baremetal
>
> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
> Signed-off-by: Tiecheng Zhou <Tiecheng.Zhou@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index be729e7..c221570 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1181,6 +1181,9 @@ static int gmc_v9_0_gart_enable(struct amdgpu_device *adev)
>   	tmp = RREG32_SOC15(HDP, 0, mmHDP_HOST_PATH_CNTL);
>   	WREG32_SOC15(HDP, 0, mmHDP_HOST_PATH_CNTL, tmp);
>   
> +	WREG32_SOC15(HDP, 0, mmHDP_NONSURFACE_BASE, (adev->gmc.vram_start >> 8));
> +	WREG32_SOC15(HDP, 0, mmHDP_NONSURFACE_BASE_HI, (adev->gmc.vram_start >> 40));
> +
>   	/* After HDP is initialized, flush HDP.*/
>   	adev->nbio_funcs->hdp_flush(adev, NULL);
>   

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-05-14 11:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 10:59 [PATCH] drm/amdgpu/sriov: Need to initialize the HDP_NONSURFACE_BAStE Tiecheng Zhou
     [not found] ` <1557831559-6925-1-git-send-email-Tiecheng.Zhou-5C7GfCeVMHo@public.gmane.org>
2019-05-14 11:04   ` Christian König [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-05-14 10:24 Tiecheng Zhou
     [not found] ` <1557829492-5991-1-git-send-email-Tiecheng.Zhou-5C7GfCeVMHo@public.gmane.org>
2019-05-14 10:33   ` Christian König
     [not found]     ` <8cca3031-e258-785c-331c-6c6d32421ed0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-05-14 14:17       ` Deucher, Alexander
2019-05-14  3:34 Tiecheng Zhou
     [not found] ` <1557804896-4032-1-git-send-email-Tiecheng.Zhou-5C7GfCeVMHo@public.gmane.org>
2019-05-14 14:06   ` Deucher, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82fa6b02-473c-5d83-6cec-7d72fd19f48f@gmail.com \
    --to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=Emily.Deng-5C7GfCeVMHo@public.gmane.org \
    --cc=Tiecheng.Zhou-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.