From: Roger Quadros <rogerq@ti.com>
To: Pawel Laszczak <pawell@cadence.com>, <peter.chen@nxp.com>
Cc: <linux-usb@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<kurahul@cadence.com>, <a-govindraju@ti.com>
Subject: Re: [PATCH] usb: cdns3: Removes xhci_cdns3_suspend_quirk from host-export.h
Date: Fri, 11 Dec 2020 10:51:38 +0200 [thread overview]
Message-ID: <835fe013-e070-76ec-d102-5c9e3a5d8fa3@ti.com> (raw)
In-Reply-To: <20201211050954.14616-1-pawell@cadence.com>
On 11/12/2020 07:09, Pawel Laszczak wrote:
> Function xhci_cdns3_suspend_quirk is used only in host.c file.
> We can make it as static and removes it from host-export.h.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
> ---
> drivers/usb/cdns3/host-export.h | 7 -------
> drivers/usb/cdns3/host.c | 4 +++-
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/cdns3/host-export.h b/drivers/usb/cdns3/host-export.h
> index fb8541b8adbc..cf92173ecf00 100644
> --- a/drivers/usb/cdns3/host-export.h
> +++ b/drivers/usb/cdns3/host-export.h
> @@ -9,12 +9,9 @@
> #ifndef __LINUX_CDNS3_HOST_EXPORT
> #define __LINUX_CDNS3_HOST_EXPORT
>
> -struct usb_hcd;
> -
> #if IS_ENABLED(CONFIG_USB_CDNS_HOST)
>
> int cdns_host_init(struct cdns *cdns);
> -int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);
>
> #else
>
> @@ -24,10 +21,6 @@ static inline int cdns_host_init(struct cdns *cdns)
> }
>
> static inline void cdns_host_exit(struct cdns *cdns) { }
> -static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
> -{
> - return 0;
> -}
>
> #endif /* USB_CDNS_HOST */
>
> diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> index 3ff19182b0c0..84dadfa726aa 100644
> --- a/drivers/usb/cdns3/host.c
> +++ b/drivers/usb/cdns3/host.c
> @@ -23,6 +23,8 @@
> #define CFG_RXDET_P3_EN BIT(15)
> #define LPM_2_STB_SWITCH_EN BIT(25)
>
> +static int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);
> +
> static const struct xhci_plat_priv xhci_plat_cdns3_xhci = {
> .quirks = XHCI_SKIP_PHY_INIT | XHCI_AVOID_BEI,
> .suspend_quirk = xhci_cdns3_suspend_quirk,
> @@ -87,7 +89,7 @@ static int __cdns_host_init(struct cdns *cdns)
> return ret;
> }
>
> -int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
> +static int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
> {
> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> u32 value;
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2020-12-11 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 5:09 [PATCH] usb: cdns3: Removes xhci_cdns3_suspend_quirk from host-export.h Pawel Laszczak
2020-12-11 8:51 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835fe013-e070-76ec-d102-5c9e3a5d8fa3@ti.com \
--to=rogerq@ti.com \
--cc=a-govindraju@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.