All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH v5 1/4] gdb: Add OpenRISC or1k and or1knd target support
Date: Fri, 17 Mar 2017 11:35:27 +0200	[thread overview]
Message-ID: <83fuicz1nk.fsf@gnu.org> (raw)
In-Reply-To: <20170317093247.GO2418@lianli.shorne-pla.net> (message from Stafford Horne on Fri, 17 Mar 2017 18:32:47 +0900)

> Date: Fri, 17 Mar 2017 18:32:47 +0900
> From: Stafford Horne <shorne@gmail.com>
> Cc: gdb-patches at sourceware.org, franck.jullien at gmail.com,
> 	openrisc at lists.librecores.org
> 
> > > +The OpenRISC 1000 architecture has evolved since the first port for
> > > + at value{GDBN}.  In particular the structure of the Unit Present register has
> > > +changed and the CPU Configuration register has been added.  The port of
> > > + at value{GDBN} version @value{GDBVN} uses the @emph{current}
> > > +specification of the OpenRISC 1000.
> > 
> > I'm not sure what this text conveys.  Can you tell why it is important
> > to have this information in the manual?  I might then suggest a change
> > in wording.
> 
> Its saying that if you are using an old version of the CPU it might not
> run as expected with this version of GDB.  Ill change to explain that
> without talking about previous ports of GDB.
> 
> Something like:
> 
>   Earlier version of the OpenRISC architecture did not include the UPR
>   (unit present) or CPUCFGR (CPU configuration) registers.  This version
>   of @value{GDBN} expects these to be present.

That's okay, but we should also tell the reader what to do if the
expected registers are not present.  Is there anything they could do
except upgrade to a newer version of OpenRISC?

  reply	other threads:[~2017-03-17  9:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17  5:43 [OpenRISC] [PATCH v5 0/4] OpenRISC gdb port Stafford Horne
2017-03-17  5:43 ` [OpenRISC] [PATCH v5 1/4] gdb: Add OpenRISC or1k and or1knd target support Stafford Horne
2017-03-17  8:48   ` Eli Zaretskii
2017-03-17  9:32     ` Stafford Horne
2017-03-17  9:35       ` Eli Zaretskii [this message]
2017-03-17 10:03         ` Stafford Horne
2017-04-04 21:17   ` Yao Qi
2017-04-08  9:36     ` Stafford Horne
2017-03-17  5:43 ` [OpenRISC] [PATCH v5 2/4] gdb: provide openrisc target description XML files Stafford Horne
2017-04-04 21:25   ` Yao Qi
2017-04-08  9:38     ` Stafford Horne
2017-03-17  5:43 ` [OpenRISC] [PATCH v5 3/4] gdb: testsuite: Add or1k l.nop inscruction Stafford Horne
2017-04-04 21:29   ` Yao Qi
2017-03-17  5:43 ` [OpenRISC] [PATCH v5 4/4] Add gdb for or1k build Stafford Horne
2017-04-04 21:32   ` Yao Qi
2017-03-21  9:14 ` [OpenRISC] [PATCH v5 0/4] OpenRISC gdb port Yao Qi
2017-03-21 14:17   ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fuicz1nk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=openrisc@lists.librecores.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.